New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756537 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 741988

Blocking:
issue 702336



Sign in to add a comment

mac retina release WebglConformance_deqp_functional_gles3_shaderoperator_common_functions failures

Project Member Reported by enne@chromium.org, Aug 17 2017

Issue description

It looks like WebglConformance_deqp_functional_gles3_shaderoperator_common_functions has been flakily failing for a while: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release%20%28NVIDIA%29?numbuilds=200

It looks like a timeout.  There are some cases of passing, so this appears to be flaky.

First failure: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release%20%28NVIDIA%29/builds/4677

Looking at builds 4671..4677 all the parent_got_angle_revision are the same, so it seems likely this is not some ToT angle issue and instead something changing on the Chromium side.

Most likely change in the 4677 build:
https://chromium.googlesource.com/chromium/src/+/2f878841370d32a95296a3455a381c5ec4bf3f4e
 

Comment 1 by kbr@chromium.org, Aug 17 2017

Blocking: 702336
Cc: ericrk@chromium.org
Components: Blink>WebGL
Owner: kbr@chromium.org
Status: Assigned (was: Available)
It was probably 938e2fc0adf875e3d8b9a64d47213a6b2d09d751 . The NVIDIA Retina bots aren't even close to passing the WebGL 2.0 conformance suite and probably never will be (unless Apple starts shipping hardware containing NVIDIA GPUs again and fixes up their drivers), so I'll mark it as failing on that configuration.

Comment 2 by kbr@chromium.org, Aug 17 2017

Blockedon: 741988
That CL landed in https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Mac%20Retina%20Release%20%28NVIDIA%29/4676 , btw, so that's probably the cause.

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a075ab67ed5cd21459b0d230acbb03b80e07bf0

commit 7a075ab67ed5cd21459b0d230acbb03b80e07bf0
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Aug 17 23:59:38 2017

Suppress deqp/functional/gles3/shaderoperator/common_functions on Mac NVIDIA.

It fails too often on this configuration. Since the bot's not close to
passing WebGL conformance, just mark as failing again.

BUG= 756537 
TBR=ericrk@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I87356f1e98af3f985769db1b6f71293e3b6c847e
Reviewed-on: https://chromium-review.googlesource.com/619697
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495390}
[modify] https://crrev.com/7a075ab67ed5cd21459b0d230acbb03b80e07bf0/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 4 by kbr@chromium.org, Aug 18 2017

Status: Fixed (was: Assigned)
Calling this fixed so that the parent bug can also finally be closed.

Comment 5 by kbr@chromium.org, May 10 2018

More flakes seen on this configuration:
WebglConformance_deqp_functional_gles3_shaderoperator_unary_operator_01:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28NVIDIA%29/1360

WebglConformance_deqp_functional_gles3_shaderoperator_binary_operator_01:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28NVIDIA%29/1361

Same symptom, a timeout with no additional information:

[112/135] gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_deqp_functional_gles3_shaderoperator_unary_operator_01 failed unexpectedly 323.3722s:
  
  Traceback (most recent call last):
    _RunGpuTest at content/test/gpu/gpu_tests/gpu_integration_test.py:132
      self.RunActualGpuTest(url, *args)
    RunActualGpuTest at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:188
      getattr(self, test_name)(test_path, *args[1:])
    _RunConformanceTest at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:202
      self._CheckTestCompletion()
    _CheckTestCompletion at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:196
      'webglTestHarness._finished', timeout=self._GetTestTimeout())
    traced_function at third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
      return func(*args, **kwargs)
    WaitForJavaScriptCondition at third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py:261
      return self._tab.WaitForJavaScriptCondition(*args, **kwargs)
    traced_function at third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
      return func(*args, **kwargs)
    WaitForJavaScriptCondition at third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py:239
      return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
    traced_function at third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
      return func(*args, **kwargs)
    WaitForJavaScriptCondition at third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py:302
      e.message + '\n' + debug_message)
  TimeoutException: Timed out while waiting 300s for IsJavaScriptExpressionTrue.
  Console output:
  
  Locals:
    IsJavaScriptExpressionTrue : <function IsJavaScriptExpressionTrue at 0x1168f45f0>
    condition                  : 'webglTestHarness._finished'
    context_id                 : None
    debug_message              : 'Console output:\n'
    e                          : TimeoutException('Timed out while waiting 300s for IsJavaScriptExpressionTrue.',)
    kwargs                     : {}
    timeout                    : 300

Suppressing these failures under this old bug since there's not much point in filing a new one.

Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b31e7360cd3076dd5aca1b60f26aba8d2e4e21b

commit 5b31e7360cd3076dd5aca1b60f26aba8d2e4e21b
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri May 11 00:56:41 2018

Suppress shaderoperator flakes on Mac NVIDIA.

Mark these two tests as failing:
  deqp/functional/gles3/shaderoperator/binary_operator_01.html
  deqp/functional/gles3/shaderoperator/unary_operator_01.html

Bug:  756537 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I08a3d1b7ba3e240aec2347a92e8b52156780c510
Tbr: rjkroege@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1054773
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557746}
[modify] https://crrev.com/5b31e7360cd3076dd5aca1b60f26aba8d2e4e21b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 7 by kbr@chromium.org, May 11 2018

Still seeing other flakes of these shaderoperator tests on this bot, for example WebglConformance_deqp_functional_gles3_shaderoperator_binary_operator_00 in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28NVIDIA%29/1372 . Going to add a wildcard suppression.

Project Member

Comment 8 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f50d6103e9146a37ba6f19eb7d4f7bf38d0fd001

commit f50d6103e9146a37ba6f19eb7d4f7bf38d0fd001
Author: Kenneth Russell <kbr@chromium.org>
Date: Mon May 14 19:33:46 2018

Suppress the whole shaderoperator suite on Mac NVIDIA.

Enough of these tests are flaky on this bot that we should just use a
wildcard suppression. This bot is not expected to pass WebGL 2.0
conformance.

Bug:  756537 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I824d00e5f05bc42b119baa8089ef2cb81f0675a1
Tbr: rjkroege@chromium.org
Tbr: zmo@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1054360
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558416}
[modify] https://crrev.com/f50d6103e9146a37ba6f19eb7d4f7bf38d0fd001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Sign in to add a comment