New issue
Advanced search Search tips

Issue 756532 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTest hittesting/inner-border-radius-hittest.html is failing

Project Member Reported by schenney@chromium.org, Aug 17 2017

Issue description

The LayoutTest hittesting/inner-border-radius-hittest.html is failing is failing one of the testharness asserts.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d420d59da518424cae8a3ba3fbc3f9c9eca04ab

commit 8d420d59da518424cae8a3ba3fbc3f9c9eca04ab
Author: Stephen Chenney <schenney@chromium.org>
Date: Wed Aug 23 20:53:50 2017

Fix hit testing on border-radius elements

When an element with border radius has children, and
the element should clip overflow and has it's own paint
layer, we were not detecting that children should be
skipped for hit testing when the point is outside the
inner border clip rect.

This change refactors the code to always check for
border radius when ShouldClipOverflow is true,
regardless of the self painting layer status.

We already had test coverage with the failure hidden
in js-test expectations. A previous change converted
the test to testharness.js and now we can delete the
failing expectations file.

R=pdr@chromium.org
BUG= 756532 , 647969 

Change-Id: I5eccbe446a6dd502fe73c8ba66df2c2376202e6f
Reviewed-on: https://chromium-review.googlesource.com/621629
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496800}
[delete] https://crrev.com/6ff12d91d13647088a2502fae2c8ec1c8d0b5750/third_party/WebKit/LayoutTests/hittesting/inner-border-radius-hittest-expected.txt
[modify] https://crrev.com/8d420d59da518424cae8a3ba3fbc3f9c9eca04ab/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment