New issue
Advanced search Search tips

Issue 756524 link

Starred by 1 user
Status: Fixed
Owner:
sahel@chromium.org
Closed: Sep 2017
Cc:
dgozman@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , All
Pri: 3
Type: Bug



Sign in to add a comment

Input.dispatchMouseEvent should populate phase for wheel events

Project Member Reported by sahel@chromium.org, Aug 17 2017 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1)Run inspector-protocol/input/dispatchMouseEvent.js test with --enable-features=TouchpadAndWheelScrollLatching,AsyncWheelEvents  

What is the expected result?
The test should pass.

What happens instead?
It crashes instead since DispatchMouseEvent doesn't populate phase information for wheel events. In real case scenarios the phase information is added to wheel events in renderWidgetHostView*::SendMouseEvent function before forwarding them,
Since the event injection skips this function call and directly forwards wheel events, it should add phase info to them before forwarding.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2abac3742f431d44ebad70c8c052d55432bfbd9d

commit 2abac3742f431d44ebad70c8c052d55432bfbd9d
Author: Sahel Sharify <sahel@chromium.org>
Date: Wed Aug 23 20:12:16 2017

DispatchMouseEvent adds wheel phase info before sending wheel events.

When wheel scroll latching and async wheel events are enabled, phase
information gets added to WebMouseWheelEvents when they are generated
from native events and before routing them. So, when wheel events are
added to the Wheel event queue, it is expected for them to have the
phase information. DispatchMouseEvent directly generates web events and
forwards them skipping the creation from native events and routing them.
This changes DispatchMouseEvent to add the phase information before
forwarding the generated wheel events.

To test the change locally run the following test with --enable-features=
TouchpadAndWheelScrollLatching, AsyncWheelEvents runtime flag. The test
would crash without applying this cl.

Bug:  756524 , 526463
test: inspector-protocol/input/dispatchMouseEvent.js
Change-Id: I864a33b08e6398bac04da5092df16ac1eae7a0be
Reviewed-on: https://chromium-review.googlesource.com/619832
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496783}
[modify] https://crrev.com/2abac3742f431d44ebad70c8c052d55432bfbd9d/content/browser/devtools/protocol/input_handler.cc

Comment 2 by sahel@chromium.org, Sep 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment