New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756523 link

Starred by 3 users

Issue metadata

Status: Verified
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in content::mojom::URLLoaderFactoryStubDispatch::Accept

Project Member Reported by ClusterFuzz, Aug 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6483255074488320

Fuzzer: inferno_twister
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::mojom::URLLoaderFactoryStubDispatch::Accept
  content::mojom::URLLoaderFactoryStub<mojo::RawPtrImplRefTraits<content::mojom::U
  mojo::InterfaceEndpointClient::HandleValidatedMessage
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=495096:495101

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6483255074488320

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Components: Internals>Mojo
Perhaps related to Issue 753672?
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 18 2017

Labels: M-62
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 18 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 18 2017

Labels: Pri-1

Comment 5 by rsesek@chromium.org, Aug 21 2017

Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
rockot: This looks similar to issue 753672, but Clusterfuzz doesn't think it's fixed yet.

Comment 6 by roc...@chromium.org, Aug 21 2017

Cc: roc...@chromium.org jam@chromium.org yzshen@chromium.org yhirano@chromium.org
Owner: ----
Status: Available (was: Assigned)
I don't think it's related to bug 753672, which was a UAF. This is an uninitialized value sent over some URLLoaderFactoryPtr. Unless we're seeing similar bugs across many different interfaces/messages, it's probably a bug with a specific client of URLLoaderFactory.

The regression range is unfortunately not helpful, but +CC some folks working on network service and/or loading.

Comment 7 by roc...@chromium.org, Aug 21 2017

Hmm - unless this |impl| itself (or its vtable) is the uninitialized value here. Note that the crash is triggered by this line: https://cs.chromium.org/chromium/src/out/Debug/gen/content/public/common/url_loader_factory.mojom.cc?rcl=07237c8fd68bf051ce5f6b80adb13e30ed3b9efb&l=172

Comment 8 by yzshen@chromium.org, Aug 21 2017

I didn't find any interesting thing by looking at the report, either.
Impl is provided by the user code of the bindings, so it is possible that it is a bug in some user code.
But if this is reproducible locally, it should not be hard to fix.

Comment 9 by roc...@chromium.org, Aug 22 2017

Cc: reillyg@chromium.org
Project Member

Comment 10 by ClusterFuzz, Aug 26 2017

ClusterFuzz has detected this issue as fixed in range 497420:497431.

Detailed report: https://clusterfuzz.com/testcase?key=6483255074488320

Fuzzer: inferno_twister
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::mojom::URLLoaderFactoryStubDispatch::Accept
  content::mojom::URLLoaderFactoryStub<mojo::RawPtrImplRefTraits<content::mojom::U
  mojo::InterfaceEndpointClient::HandleValidatedMessage
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=495096:495101
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=497420:497431

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6483255074488320

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Aug 26 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 6483255074488320 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 26 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 14 by sheriffbot@chromium.org, Dec 2 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment