New issue
Advanced search Search tips

Issue 756522 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in blink::PaintController::CommitNewDisplayItems

Project Member Reported by ClusterFuzz, Aug 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6408589886619648

Fuzzer: inferno_twister
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Heap-use-after-free WRITE 4
Crash Address: 0x074153c8
Crash State:
  blink::PaintController::CommitNewDisplayItems
  blink::GraphicsLayer::Paint
  blink::LocalFrameView::PaintGraphicsLayerRecursively
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=480516:480579

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6408589886619648

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: wangxianzhu@chromium.org
Components: Blink>Paint
This looks like  Issue 729383 ?
Cc: -wangxianzhu@chromium.org
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 18 2017

Labels: M-62
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 18 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 18 2017

Labels: Pri-1
Project Member

Comment 6 by ClusterFuzz, Aug 19 2017

ClusterFuzz has detected this issue as fixed in range 495551:495803.

Detailed report: https://clusterfuzz.com/testcase?key=6408589886619648

Fuzzer: inferno_twister
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Heap-use-after-free WRITE 4
Crash Address: 0x074153c8
Crash State:
  blink::PaintController::CommitNewDisplayItems
  blink::GraphicsLayer::Paint
  blink::LocalFrameView::PaintGraphicsLayerRecursively
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=480516:480579
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=495551:495803

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6408589886619648

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Aug 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6408589886619648 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 19 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Cc: chrishtr@chromium.org
Labels: -ClusterFuzz-Verified ClusterFuzz-Wrong
Status: Assigned (was: Verified)
The test is flaky. The problem still exists. https://chromium-review.googlesource.com/c/621881 will fix it.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f32ca4df5b7b468e063b35a6e9cc36879a6d96e

commit 7f32ca4df5b7b468e063b35a6e9cc36879a6d96e
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Aug 22 02:38:38 2017

Invalidate on change of stacked status

Change of stacked status may cause change of PaintLayer's
CompositingContainer which may have painted a cached subsequence
containing the object.

BUG= 756522 

Change-Id: I6d0fa32254cedaf6a5d0a9271a6b01cc8c11d4c8
Reviewed-on: https://chromium-review.googlesource.com/621881
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496187}
[modify] https://crrev.com/7f32ca4df5b7b468e063b35a6e9cc36879a6d96e/third_party/WebKit/LayoutTests/paint/invalidation/fixed-and-absolute-position-scrolled-expected.txt
[delete] https://crrev.com/f7ed74d2df3e2de6231675eea8607c0d6d7727f7/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/containing-block-position-change-expected.txt
[delete] https://crrev.com/f7ed74d2df3e2de6231675eea8607c0d6d7727f7/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/static-to-positioned-expected.txt
[rename] https://crrev.com/7f32ca4df5b7b468e063b35a6e9cc36879a6d96e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/containing-block-position-change-expected.txt
[rename] https://crrev.com/7f32ca4df5b7b468e063b35a6e9cc36879a6d96e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/static-to-positioned-expected.txt
[modify] https://crrev.com/7f32ca4df5b7b468e063b35a6e9cc36879a6d96e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/containing-block-position-change-expected.txt
[modify] https://crrev.com/7f32ca4df5b7b468e063b35a6e9cc36879a6d96e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/static-to-positioned-expected.txt
[modify] https://crrev.com/7f32ca4df5b7b468e063b35a6e9cc36879a6d96e/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/7f32ca4df5b7b468e063b35a6e9cc36879a6d96e/third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp

Status: Fixed (was: Assigned)
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.
Labels: -ReleaseBlock-Stable
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 29 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment