Of the changes that we've merged recently to the branch, this one: https://chromium-review.googlesource.com/c/618275 might be the most promising.

Alex, Joe, can you follow up on this?

warx@ looks like tests weren't updated? 
Also shouldn't there be a new test that tests this new behavior?

I am investigating. Weird that m61 has test failure.
The modified tests should be no difference. New tests are added in app_list_unittests.

My cl is not the culprit. My investigation is that SearchBoxView::OnMouseEvent is not triggered. If I change GetPointInsideSearchbox() in the test:

from app_list_presenter_impl_.GetView()->search_box_view()->GetBoundsInScreen().origin() to app_list_presenter_impl_.GetView()->search_box_view()->GetBoundsInScreen().CenterPoint(),

then the test could pass. The test file itself has no difference from tot. I checked several related files/dirs, cannot see obvious changes missed.

Attached diffs between 3163 branch and tot:
git diff origin/master -- ui/app_list/views/
git diff origin/master -- chrome/browser/ui/app_list/
git diff origin/master -- ash/app_list/

Deleted: app_list_views_diffs.diff 52.6 KB

app_list_views_diffs.diff 52.6 KB Download

Deleted: chrome_browser_ui_app_list_diffs.diff 7.2 KB

chrome_browser_ui_app_list_diffs.diff 7.2 KB Download

Deleted: ash_app_list_diffs.diff 1.5 KB

ash_app_list_diffs.diff 1.5 KB Download

+weidongg for SearchBox active related changes
+xiyuan reviewer

test is passed on tot, but failed on 3163

There are no changes that we've made that I see as potential culprits either. We'll probably need to bisect and then try to figure out what needs to be merged from there.

I just found the reason:
it is because we didn't merge this back: https://chromium-review.googlesource.com/c/567486.

We would like to know whether merging the whole cl back or just the changes in ui/app_list/views back.

ok, the cl owner is actually varkha@.

This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

btw, changing origin() to CenterPoint() is another option, IMO. I will delegate to the cl owner or xiyuan for decision : )

Approving merge to M61 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/820a7a5574b570545f06f716c5b19c7f5f2a1360

commit 820a7a5574b570545f06f716c5b19c7f5f2a1360
Author: Qiang Xu <warx@chromium.org>
Date: Fri Aug 18 20:50:43 2017

app_list: make GetPointInsideSearchbox picking CenterPoint

changes:
Mainly for addressing the issue in  crbug.com/756516 , where in 3163
branch https://chromium-review.googlesource.com/c/567486 is not merged
back. In that change, the whole search box is the event target rather
than just the part inside the shadow.

Contacted varkha@, better changing the tapping point, not the margin of
search box.

Bug:  756516 
Test: covered by tests
Change-Id: If66f70b223ffb1c53ddeb148b9a708def7385f41
Reviewed-on: https://chromium-review.googlesource.com/621533
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495673}
[modify] https://crrev.com/820a7a5574b570545f06f716c5b19c7f5f2a1360/ash/app_list/app_list_presenter_delegate_unittest.cc

as an FYI I'm holding off on merging further launcher changes to M61 until we can get this change merged back to M61 and confirm the tests pass at ToT on 3163.

Joe, thanks for finding and taking up the fix!

I will merge it right now. It should have no conflict.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e671ba04d1450efda2a6f9c5b07b1d0925c1a68

commit 5e671ba04d1450efda2a6f9c5b07b1d0925c1a68
Author: Qiang Xu <warx@chromium.org>
Date: Fri Aug 18 21:10:58 2017

m61 merge: app_list: make GetPointInsideSearchbox picking CenterPoint

changes:
Mainly for addressing the issue in  crbug.com/756516 , where in 3163
branch https://chromium-review.googlesource.com/c/567486 is not merged
back. In that change, the whole search box is the event target rather
than just the part inside the shadow.

Contacted varkha@, better changing the tapping point, not the margin of
search box.

TBR: xiyuan@chromium.org

(cherry picked from commit 820a7a5574b570545f06f716c5b19c7f5f2a1360)

Bug:  756516 
Test: covered by tests
Change-Id: If66f70b223ffb1c53ddeb148b9a708def7385f41
Reviewed-on: https://chromium-review.googlesource.com/621533
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495673}
Reviewed-on: https://chromium-review.googlesource.com/621195
Cr-Commit-Position: refs/branch-heads/3163@{#685}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/5e671ba04d1450efda2a6f9c5b07b1d0925c1a68/ash/app_list/app_list_presenter_delegate_unittest.cc

Verified that tests pass on branch, going to start merges for launcher again.