New issue
Advanced search Search tips

Issue 756505 link

Starred by 1 user
Status: Fixed
Owner:
jbroman@chromium.org
Closed: Sep 2017
Cc:
jkarlin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

YouCompleteMe and SublimeClang do not use bundled libc++

Project Member Reported by jbroman@chromium.org, Aug 17 2017 
Reported by jkarlin:
https://chromium-review.googlesource.com/c/617300#message-0b9576fae0f632eaa58cef3f20475403404e9bce

This being out of sync causes such editor plugins to now support C++14 library features, even though our toolchain does.

I have a candidate fix for YCM.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/807200c447b8c16b4c8b0f6316c67ed229390ec2

commit 807200c447b8c16b4c8b0f6316c67ed229390ec2
Author: Jeremy Roman <jbroman@chromium.org>
Date: Thu Aug 17 18:51:58 2017

Fix YouCompleteMe config to forward flags to use libc++.

Bug:  756505 
Change-Id: Ica9716aacb48eec1796c7264c1148ca06699c446
Reviewed-on: https://chromium-review.googlesource.com/619289
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495259}
[modify] https://crrev.com/807200c447b8c16b4c8b0f6316c67ed229390ec2/tools/vim/chromium.ycm_extra_conf.py
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b0eeba7e0d952c6617e232fa8ed53257c35dd2f

commit 4b0eeba7e0d952c6617e232fa8ed53257c35dd2f
Author: Josh Karlin <jkarlin@chromium.org>
Date: Thu Sep 07 11:08:50 2017

[Sublime Text] Update instructions for SublimeClang to use a newer libclang.so

In order to parse modern Chromium code, we need a more recent libclang and supporting headers.

Bug:  756505 
Change-Id: I3b731fad4842c46946391fccbcf08235d4d98b70
Reviewed-on: https://chromium-review.googlesource.com/629138
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500270}
[modify] https://crrev.com/4b0eeba7e0d952c6617e232fa8ed53257c35dd2f/docs/sublime_ide.md

Comment 3 by jbroman@chromium.org, Sep 7 2017

Status: Fixed (was: Started)
With YCM and SublimeClang presumably both working, marking as fixed.
►

Sign in to add a comment