New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756484 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

include h instead of cc in 750666

Project Member Reported by newcomer@chromium.org, Aug 17 2017

Issue description

Include the h file instead of the cc file in 750666



 
Labels: OS-Chrome
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 17 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/844f32c71f1ea18c47a7905b311bbff30381f2e7

commit 844f32c71f1ea18c47a7905b311bbff30381f2e7
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Aug 17 18:38:10 2017

cros:Peeking Launcher:webstore search

Include the header file instead of the cc file in search_controller_factory.cc.

Bug:  756484 
Change-Id: I11fee5ca367165b622f186971e3040161d0faef3
Reviewed-on: https://chromium-review.googlesource.com/619269
Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495244}
[modify] https://crrev.com/844f32c71f1ea18c47a7905b311bbff30381f2e7/chrome/browser/ui/app_list/search/search_controller_factory.cc

Project Member

Comment 5 by sheriffbot@chromium.org, Aug 21 2017

Cc: keta...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 24 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Labels: -Merge-Approved-61

Sign in to add a comment