include h instead of cc in 750666 |
|||||||
Issue descriptionInclude the h file instead of the cc file in 750666
,
Aug 17 2017
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 17 2017
Approving merge to M61 Chrome OS.
,
Aug 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/844f32c71f1ea18c47a7905b311bbff30381f2e7 commit 844f32c71f1ea18c47a7905b311bbff30381f2e7 Author: Alex Newcomer <newcomer@chromium.org> Date: Thu Aug 17 18:38:10 2017 cros:Peeking Launcher:webstore search Include the header file instead of the cc file in search_controller_factory.cc. Bug: 756484 Change-Id: I11fee5ca367165b622f186971e3040161d0faef3 Reviewed-on: https://chromium-review.googlesource.com/619269 Reviewed-by: Elijah Taylor <elijahtaylor@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#495244} [modify] https://crrev.com/844f32c71f1ea18c47a7905b311bbff30381f2e7/chrome/browser/ui/app_list/search/search_controller_factory.cc
,
Aug 21 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 24 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 24 2017
,
Jan 22 2018
,
Dec 17
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by newcomer@chromium.org
, Aug 17 2017