New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756468 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Quads with subpixel positioning are never getting promoted to HW overlays.

Project Member Reported by dcasta...@chromium.org, Aug 17 2017

Issue description

Checking why we don't get HW overlays for non integer scale-factors we noticed that quads display_rects might have subpixel position/size.

KMS supports subpixel positioning for planes (with fixed point), but Chrome rejects them.
Chrome overlay APIs seem to be using gfx::Rect instead of a gfx::Rectf for overlays rects in many places.

If we want to use HW overlays in more scenarios, we should change the APIs to use gfx::Rectf, or we need to make sure that quads are aligned to the display pixel grid.


 
Labels: Proj-Ozone-DRM
Cc: domlasko...@chromium.org
Not sure it's necessary to improve the HW overlay code to support this but it definitely wouldn't hurt.

The reason we're seeing sub-pixel coordinates for arc apps can be fixed, I think. It's a side-effect of how we handle dynamic density changes and I think it would be fine to snap window locations to the physical pixel grid on the client side.

Comment 3 by enne@chromium.org, Aug 17 2017

Status: Assigned (was: Untriaged)

Sign in to add a comment