New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756445 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CSP layout tests that use registerURLSchemeAsBypassingContentSecurityPolicy flakily fail

Project Member Reported by jbroman@chromium.org, Aug 17 2017

Issue description

This is infrequent, so I haven't disabled the tests.

e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10555
http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html

The issue reported here is that a thread had been created by the time the SchemeRegistry was modified (by calls via |internals|). These tests violate the assumption there that this is only changed during startup.

Either these tests should be changed, or they should be somehow exempt from this DCHECK.

I also suspect that these tests leave the state of the content_shell hosting them modified (because I don't see a mechanism for resetting the SchemeRegistry), but I haven't investigated.
 
Summary: CSP layout tests that use registerURLSchemeAsBypassingContentSecurityPolicy flakily fail (was: CSP tests flakily fail)
I looked into converting all such tests to be simtests that could properly mutate the scheme registry during startup, but I never got around to it. You're right that they leave the content_shell modified, which is non-ideal.

I would be OK just letting those call an UnsafeMutateForTesting() method
Cc: mkwst@chromium.org
Components: -Blink>SecurityFeature Blink>SecurityFeature>ContentSecurityPolicy
Labels: Test-Layout
Owner: andypaicu@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 5 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment