CSP layout tests that use registerURLSchemeAsBypassingContentSecurityPolicy flakily fail |
||||
Issue descriptionThis is infrequent, so I haven't disabled the tests. e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10555 http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html The issue reported here is that a thread had been created by the time the SchemeRegistry was modified (by calls via |internals|). These tests violate the assumption there that this is only changed during startup. Either these tests should be changed, or they should be somehow exempt from this DCHECK. I also suspect that these tests leave the state of the content_shell hosting them modified (because I don't see a mechanism for resetting the SchemeRegistry), but I haven't investigated.
,
Aug 17 2017
I looked into converting all such tests to be simtests that could properly mutate the scheme registry during startup, but I never got around to it. You're right that they leave the content_shell modified, which is non-ideal. I would be OK just letting those call an UnsafeMutateForTesting() method
,
Oct 5 2017
,
Nov 10 2017
,
Feb 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jbroman@chromium.org
, Aug 17 2017