New issue
Advanced search Search tips

Issue 756439 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 624363



Sign in to add a comment

Merge the foo and foo_arc targets

Project Member Reported by stkhapugin@chromium.org, Aug 17 2017

Issue description

As part of post-ARC-migration cleanup, all of the foo_arc targets should be merged with foo, and dependencies are to be updated accordingly. 
 
Status: Assigned (was: ass)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b48e692fd50c53d98792d162a95dbf74afc2a648

commit b48e692fd50c53d98792d162a95dbf74afc2a648
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Thu Aug 17 15:08:43 2017

Add TODO to merge //ios/chrome/chrome/ui:ui_internal{,_arc}.

Bug:  756439 
Change-Id: I2c9d30c0fb668d619846d67c82140ff850fe9c7e
Reviewed-on: https://chromium-review.googlesource.com/619206
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495176}
[modify] https://crrev.com/b48e692fd50c53d98792d162a95dbf74afc2a648/ios/chrome/browser/ui/BUILD.gn

Owner: sdefresne@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac70b2c46630be5614fa06491a71534bdc53b910

commit ac70b2c46630be5614fa06491a71534bdc53b910
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Fri Aug 25 08:37:43 2017

Merge all "foo" and "foo_arc" target when both have ARC enabled.

To simplify the iOS ARC migration, multiple targets where split
in two, with one enabling ARC while the other had ARC disabled.
Merge the two targets when both are using ARC.

Bug:  756439 
Change-Id: Ib103f7404d5e738180c92288fcde471ba177e8ad
Reviewed-on: https://chromium-review.googlesource.com/632956
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497357}
[modify] https://crrev.com/ac70b2c46630be5614fa06491a71534bdc53b910/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ac70b2c46630be5614fa06491a71534bdc53b910/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/ac70b2c46630be5614fa06491a71534bdc53b910/ios/chrome/browser/ui/bookmarks/BUILD.gn
[modify] https://crrev.com/ac70b2c46630be5614fa06491a71534bdc53b910/ios/chrome/browser/ui/history/BUILD.gn
[modify] https://crrev.com/ac70b2c46630be5614fa06491a71534bdc53b910/ios/chrome/browser/ui/ntp/recent_tabs/BUILD.gn
[modify] https://crrev.com/ac70b2c46630be5614fa06491a71534bdc53b910/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/ac70b2c46630be5614fa06491a71534bdc53b910/ios/chrome/browser/ui/tab_switcher/BUILD.gn
[modify] https://crrev.com/ac70b2c46630be5614fa06491a71534bdc53b910/ios/web/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment