[MacViewsBrowser] Delete match shortcut doesn't work
Reported by
dyaros...@yandex-team.ru,
Aug 17 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 YaBrowser/17.9.0.1340 Yowser/2.5 Safari/537.36 Steps to reproduce the problem: 1. Build with mac_views 2. Open URL a few times to get it in history. 3. Open omnibox and type a few letters from the url 4. Select history match in suggest. 5. Press Shift + Fn + Backspace What is the expected behavior? History match is deleted. What went wrong? Nothing happens. Did this work before? N/A Chrome version: 60.0.3112.90 Channel: n/a OS Version: OS X 10.12.6 Flash Version: Shockwave Flash 26.0 r0 This seems to be a problem in BridgedContentView https://cs.chromium.org/chromium/src/ui/views/cocoa/bridged_content_view.mm?l=1238&rcl=a701b1b2c9b63981ad0a56bc793b9175cb33ba1f We just discard all flags. They should be propagated for later processing too. In OmniboxViewMac these flags are processed here: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?l=865&rcl=f759da5199bcdd420f8dfdff506e35f3c0bb5464
,
Aug 17 2017
,
Aug 18 2017
Unable to reproduce this issue on Mac OS 10.12.6 using chrome latest stable #60.0.3112.101 by following steps mentioned in the original comment. By pressing Shift + Fn + Backspace observed the history from the suggestion gets deleted in omnibox. Reporter@ Attaching screen cast for reference, could you please recheck this issue on chrome latest stable #60.0.3112.101 and update this bug with latest behavior. Thanks!
,
Aug 18 2017
@brajkumar - are you testing mac_views?
,
Aug 18 2017
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 18 2017
Please check the screen cast here.
,
Aug 18 2017
@brajkumar - I don't see any indication that this is MacViews, is it? FYI: MacViews - is a project transferring Chromium for Mac on Views based implementation (so that we have as much of common codebase for all platforms). It is currently in development and by default Chromium uses non MacViews implementation.
,
Aug 18 2017
Adding appropriate label for further triage.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5a78f8bc332d130599feb4914132c76b3395d9d commit d5a78f8bc332d130599feb4914132c76b3395d9d Author: Denis Yaroshevskiy <dyaroshev@yandex-team.ru> Date: Tue Aug 22 04:27:58 2017 [MacViewsBrowser] Propagating modifier flags for events. Information about pressed modifiers changes meaning of the action. Example: omnibox - pressing Delete with Shift means a different action. Processing logic: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/omnibox/omnibox_view_views.cc?l=959&rcl=70a5474589c0ede71345672a01777a60891b6036 Equivalent from non-views version: https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm?l=865&rcl=2b9314a86a88fd308662a0aa5346f1b909610876 Bug:756432 Change-Id: I1879a16f7e105fc8221d9e75c7411fdf46979b91 Reviewed-on: https://chromium-review.googlesource.com/619147 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#496213} [modify] https://crrev.com/d5a78f8bc332d130599feb4914132c76b3395d9d/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [modify] https://crrev.com/d5a78f8bc332d130599feb4914132c76b3395d9d/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/d5a78f8bc332d130599feb4914132c76b3395d9d/ui/views/controls/textfield/textfield_unittest.cc
,
Aug 22 2017
[Mac triage] +tapted@ for MacViews
,
Aug 23 2017
,
Aug 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dyaros...@yandex-team.ru
, Aug 17 201710.2 MB
10.2 MB View Download