krajshree@: Thanks for raising this issue. Is assume this is more like a reminder to think about tests rather than you looking for an answer to the question whether or not it is possible to add test coverage?

The short answer is, yes it would be possible to add test coverage, but probably the more interesting question is will it be worth the effort.

The long answer:

Adding test coverage for the Windows-specific camera capture code would require mocking out the Windows capture APIs, which seems like an unreasonably large effort.

Adding test coverage for the change in video_capture_system_impl.cc would require refactoring the logic to be accessible for unit testing. That would be a reasonable effort, but also only a very small gain, since the complexity of the logic barely reaches the level where testing makes sense. In fact the gain is so small that I would expect to get yelled at by other developers for adding the extra lines of code required for making the logic testable.

Marking as won't fix. Please feel free to reopen if you feel that action is required on this.