New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756418 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in CPDF_StreamContentParser::Parse

Project Member Reported by ClusterFuzz, Aug 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6402833556701184

Fuzzer: anil_pdf_fuzzer
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000068
Crash State:
  CPDF_StreamContentParser::Parse
  CPDF_ContentParser::Continue
  CPDF_PageObjectHolder::ContinueParse
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=495051:495074

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6402833556701184

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 17 2017

Labels: OS-Mac
Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong-CLs M-62
Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "cpdf_streamcontentparser.cpp" assigning to the concern owner who might be related or previously who might have worked on same file.

@tsepez -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 3 by tsepez@chromium.org, Aug 21 2017

Cc: tsepez@chromium.org
Owner: dsinclair@chromium.org
Cc: dsinclair@chromium.org
 Issue 756420  has been merged into this issue.
Cc: -dsinclair@chromium.org rbpotter@chromium.org
This was introduced with: https://pdfium-review.googlesource.com/c/pdfium/+/11115 it looks like AddImage can return nullptr which isn't taken into account here.
Status: Started (was: Assigned)
Components: Internals>Plugins>PDF
 Issue 757139  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 23 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/77d8317f2e6bb9c75d96390fdf843b86694ba6d2

commit 77d8317f2e6bb9c75d96390fdf843b86694ba6d2
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Wed Aug 23 12:52:19 2017

Verify image returned from AddImage

The ::AddImage call can return a nullptr if there is no stream provided.
This CL adds the missing null check on the returned object when lookikng
at the image.

Bug:  chromium:756418 ,  chromium:753700 
Change-Id: I48032c0f421c8889827540ae91f404ef0f503bfe
Reviewed-on: https://pdfium-review.googlesource.com/11532
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/77d8317f2e6bb9c75d96390fdf843b86694ba6d2/core/fpdfapi/page/cpdf_streamcontentparser.cpp

Status: Fixed (was: Started)
Project Member

Comment 11 by ClusterFuzz, Aug 24 2017

ClusterFuzz has detected this issue as fixed in range 496693:496743.

Detailed report: https://clusterfuzz.com/testcase?key=6402833556701184

Fuzzer: anil_pdf_fuzzer
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000068
Crash State:
  CPDF_StreamContentParser::Parse
  CPDF_ContentParser::Continue
  CPDF_PageObjectHolder::ContinueParse
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=495051:495074
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=496693:496743

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6402833556701184

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Aug 24 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6402833556701184 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment