New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756400 link

Starred by 4 users
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Sep 2017
Cc:
█ krajshree@chromium.org
ajha@chromium.org
█ irmakk@google.com
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Password Bubble is getting chopped when username is edited with long text

Project Member Reported by keerthan...@techmahindra.com, Aug 17 2017 
Chrome Version: 62.0.3188.0
OS: Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1)Launch chrome and open webstore
(2)Sign-in with some valid credentials
(3)Open the password bubble and edit the username with long text

Expected: Password bubble shouldn't get chopped
Actual:Instead, it's getting chopped

This is a Regression issue broken in M-62

Manual Bisect Info:
===================
Good Build:62.0.3181.0
Bad Build: 62.0.3182.0
PasswordActual.ogv
2.6 MB View Download

Comment 1 by sandeepkumars@chromium.org, Aug 17 2017

Cc: irmakk@google.com
Labels: -Needs-Bisect hasbisect-per-revision
Owner: vasi...@chromium.org
Status: Assigned (was: Unconfirmed)
Tested the issue using #62.0.3188.0 on Mac 10.12.6 and did not observe such behavior.

Note: Considered which is having edit option on the password bubble as bad build and wich is not having edit option is a good  build.

Bisect Information:
-------------------
You are probably looking for a change made after 493393 (known good), but no later than 493394 (first known bad).

CHANGELOG URL:
--------------
https://chromium.googlesource.com/chromium/src/+log/7cf26ccd716afce4b6b11f2360b97b9cf198a599..96d39c792665ec619a4cfb0d05da47420100661f

Unable to add author as owner hence assigned to reviewer.

@vasilii: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.


Thanks!

Comment 2 by vasi...@chromium.org, Aug 17 2017 

irmakk@ would be the real owner. It stays assigned to me because of the bug tracker constraints.

Comment 3 by irmakk@google.com, Aug 22 2017 

Hi! The fix is on the way here; https://chromium-review.googlesource.com/c/chromium/src/+/625622

You can find the screenshots attached. :)
longusername.png
38.4 KB View Download
longpass.png
36.3 KB View Download
longboth.png
38.4 KB View Download

Comment 4 by irmakk@google.com, Aug 23 2017 

More and more screenshots for save/update password bubbles.
fixedlongpassScreenshot from 2017-08-23 14:53:39.png
35.2 KB View Download
fixedlongusername.png
39.6 KB View Download
longerusernameshorterpass.png
38.2 KB View Download
updatepasslongusername.png
39.8 KB View Download
updatepasslongpassword.png
36.3 KB View Download
shorterusernamelongerpassword.png
36.5 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ee7e2b3307a6fc1b67a4365c8b71c4cce914ec1

commit 9ee7e2b3307a6fc1b67a4365c8b71c4cce914ec1
Author: Irmak Kavasoglu <irmakk@google.com>
Date: Thu Aug 24 07:51:36 2017

Fixed pending password bubble for long username and password

As screencap in the bug shows, the pending password bubble was being
stretched to the length of the long username. I changed the column
widths for username and password fields to fixed. Screenshots can be
found attached to the bug.

Bug:  756400 
Change-Id: I0d48b004050e37c6ef0789d8c3647e31c64b6221
Reviewed-on: https://chromium-review.googlesource.com/625622
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Irmak Kavasoğlu <irmakk@google.com>
Cr-Commit-Position: refs/heads/master@{#496976}
[modify] https://crrev.com/9ee7e2b3307a6fc1b67a4365c8b71c4cce914ec1/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Comment 6 by msrchandra@chromium.org, Aug 25 2017

Labels: TE-Verified-62.0.3196.0 TE-Verified-M62
Tested the issue on Latest Canary# 62.0.3196.0 on Windows and Linux and found the issue to be fixed. Attaching a screen shot for reference.
Hence adding TE-Verified Labels.
Thank You.
756400.png
564 KB View Download

Comment 7 by battre@chromium.org, Aug 29 2017 

Issue 760091 has been merged into this issue.

Comment 8 by melandory@chromium.org, Sep 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment