New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756369 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

83.1% regression in v8.runtimestats.browsing_mobile at 492994:493337

Project Member Reported by petermarshall@chromium.org, Aug 17 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 17 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=756369

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=df31b29a212bc0c75e2e34b73cce0250e3ca54dead88e3018fe293044911e041


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 17 2017

Cc: yukiy@google.com
Owner: yukiy@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author yukiy@google.com ===

Hi yukiy@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Yuki Yamada
  Commit : a20ac9c693c445d43b5f9710e901c813bc56c75a
  Date   : Thu Aug 10 08:04:20 2017
  Subject: Set WebContentSettingsClient for service workers.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile
  Metric       : v8-gc-scavenger_max/browse_news/browse_news_washingtonpost
  Change       : 59.34% | 8.37216666667 -> 13.822

Revision             Result                   N
chromium@492993      8.37217 +- 1.91063       6      good
chromium@493165      8.25789 +- 2.51685       9      good
chromium@493251      9.526 +- 5.68742         9      good
chromium@493294      7.05217 +- 1.81553       6      good
chromium@493316      7.7215 +- 2.6032         6      good
chromium@493322      6.8025 +- 0.778613       6      good
chromium@493325      6.666 +- 0.754341        6      good
chromium@493326      6.98367 +- 0.818915      6      good
chromium@493327      12.5233 +- 1.38093       6      bad       <--
chromium@493337      13.822 +- 5.48895        9      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.washingtonpost v8.runtimestats.browsing_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971023388924722560


For feedback, file a bug with component Speed>Bisection

Comment 4 by yukiy@google.com, Aug 18 2017

Status: WontFix (was: Assigned)
Service workers had skipped over checking content settings before I set ContentSettingsClient, so this result means it works correctly.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 18 2017

Issue 756489 has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Aug 25 2017

Issue 759065 has been merged into this issue.

Sign in to add a comment