New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756368 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 759519
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3% regression in system_health.memory_desktop at 494405:494572

Project Member Reported by petermarshall@chromium.org, Aug 17 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 17 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=756368

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9c01c38d987706ccecc76327d6e24e57755ee9120c5bb104ec6e0e009517e9b2


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 17 2017

Cc: ricea@chromium.org
Owner: ricea@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author ricea@chromium.org ===

Hi ricea@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Adam Rice
  Commit : f8a808d3178bd1b03fa002db5f6c0fa86881daa7
  Date   : Tue Aug 15 22:00:50 2017
  Subject: Streams: Throw for undefined values in pipeThrough

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:renderer_processes:reported_by_chrome:v8:heap:allocated_objects_size_avg/load_games/load_games_lazors
  Change       : 1.10% | 3023264.0 -> 3056536.0

Revision             Result              N
chromium@494404      3023264 +- 0.0      6      good
chromium@494488      3023264 +- 0.0      6      good
chromium@494530      3023264 +- 0.0      6      good
chromium@494551      3023264 +- 0.0      6      good
chromium@494562      3023264 +- 0.0      6      good
chromium@494565      3023264 +- 0.0      6      good
chromium@494566      3056536 +- 0.0      6      bad       <--
chromium@494567      3056536 +- 0.0      6      bad
chromium@494572      3056536 +- 0.0      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.lazors system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8971023470378582736


For feedback, file a bug with component Speed>Bisection

Comment 4 by ricea@chromium.org, Aug 17 2017

Components: Blink>Network>StreamsAPI
Same sort of thing as  issue 752172  and  issue 748279 . Minor change to Streams API implementation changes the layout of the V8 heap, resulting in apparent regression in memory usage.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Aug 22 2017

Cc: simonhatch@chromium.org mlippautz@chromium.org
 Issue 757793  has been merged into this issue.

Comment 6 by ricea@chromium.org, Aug 28 2017

Mergedinto: 759519
Status: Duplicate (was: Assigned)

Sign in to add a comment