New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756363 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ExecutionContext::Url

Project Member Reported by ClusterFuzz, Aug 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6080292384407552

Fuzzer: lcamtuf_cross_fuzz
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  blink::ExecutionContext::Url
  blink::NetworkInformation::GetRandomMultiplier
  blink::NetworkInformation::downlink
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=494860:494916

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6080292384407552

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 17 2017

Labels: OS-Mac
Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong-CLs M-62
Owner: yukishiino@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "ExecutionContext.cpp" assigning to concern owner.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/0d68a512e634d31dce7d71a71b4c867bf647ccf1

@yukishiino -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: yukishiino@chromium.org
Owner: tbansal@chromium.org
tbansal@, could you take a look?  If you're not one of the right owners of NetworkInformation, could you reroute this issue to the right owners?

At a glance, it seems like that NetworkInformation is accessing an ExecutionContext without checking if it's still available (non-null) or not.

In general, an ExecutionContext can be discarded at some point, so you should check if it's still available or not before its use.

Cc: tbansal@chromium.org
 Issue 756670  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Aug 18 2017

Labels: OS-Linux
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46e5295e9220f082b0c395b48ded7aea42bb12c7

commit 46e5295e9220f082b0c395b48ded7aea42bb12c7
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Aug 18 16:37:57 2017

Check if GetExecutionContext is null in NetInfo API

Bug:  756363 
Change-Id: Idcbdc4e59a311b5ab7bbfd9b67c1eb78f1a661bc
Reviewed-on: https://chromium-review.googlesource.com/620906
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495578}
[modify] https://crrev.com/46e5295e9220f082b0c395b48ded7aea42bb12c7/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

Status: Fixed (was: Started)
Project Member

Comment 9 by ClusterFuzz, Aug 19 2017

ClusterFuzz has detected this issue as fixed in range 495542:495750.

Detailed report: https://clusterfuzz.com/testcase?key=6080292384407552

Fuzzer: lcamtuf_cross_fuzz
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x00000000
Crash State:
  blink::ExecutionContext::Url
  blink::NetworkInformation::GetRandomMultiplier
  blink::NetworkInformation::downlink
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=494860:494916
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=495542:495750

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6080292384407552

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Aug 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6080292384407552 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by ClusterFuzz, Aug 25 2017

Labels: Needs-Feedback
ClusterFuzz testcase 4698420211351552 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.

Sign in to add a comment