New issue
Advanced search Search tips

Issue 756342 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Sep 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

run_benchmarks can't connect to remote target: Tracing already started

Reported by dave.rod...@gmail.com, Aug 17 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36
Platform: 9764.0.2017_08_10_0926 (Test Build - davrod01)

Steps to reproduce the problem:
1. cd tools/perf
2. ./run_benchmark run smoothness.top_25_smooth --story-filter=plus --browser=cros-chrome --remote=cros-farm-07 --output-dir results --output-format=json
3. Telemetry crashes with a long stack trace with errors relating to starting tracing

What is the expected behavior?
The benchmark should run.

What went wrong?
The benchmark does not run.

Did this work before? Yes It stopped working some time in roughly the last two weeks

Chrome version: 62.0.3187.0  Channel: dev
OS Version: 
Flash Version: 

Output from Telemetry:

[ RUN      ] https://plus.google.com/110031535020051778989/posts
/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_credentials.py:64: UserWarning: Function LoginNeeded is deprecated. It will no longer be supported on May 05, 2017. Please remove it or switch to an alternative before that time. FormBasedCredentialsBackend is deprecated. Use the login helper modules in https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/page_sets/login_helpers/ instead.

  tab, runner, self._credentials[credentials_type])
Traceback (most recent call last):
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 105, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 324, in RunStory
    self._current_page.Run(self)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 107, in Run
    shared_state.page_test.WillNavigateToPage(self, current_tab)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/data/BUILD.2017-07-12/chromium_build/src/tools/perf/measurements/smoothness.py", line 59, in WillNavigateToPage
    self._tbm.WillRunStory(tab.browser.platform)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py", line 280, in WillRunStory
    platform.tracing_controller.StartTracing(self._tbm_options.config)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/core/tracing_controller.py", line 43, in StartTracing
    self._tracing_controller_backend.StartTracing(tracing_config, timeout)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py", line 91, in StartTracing
    started = agent.StartAgentTracing(config, timeout)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py", line 124, in StartAgentTracing
    started_devtools_tracing = self._StartDevToolsTracing(config, timeout)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py", line 101, in _StartDevToolsTracing
    client.StartChromeTracing(config, timeout)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py", line 361, in StartChromeTracing
    trace_config.chrome_trace_config, timeout)
  File "/data/BUILD.2017-07-12/chromium_build/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py", line 142, in StartTracing
    'Tracing.start:\n' + json.dumps(response, indent=2))
TracingUnexpectedResponseException: Inspector returned unexpected response for Tracing.start:
{
  "id": 1, 
  "error": {
    "message": "Tracing is already started", 
    "code": -32000
  }
}
 

Comment 1 by dave.rod...@arm.com, Aug 17 2017

Tested again on a build from today (2017-08-17) with the same result.

Comment 2 Deleted

Comment 3 by dave.rod...@arm.com, Aug 17 2017

This seems to be because Telemetry tries to open two connections for getting trace data. The first appears to be against the login instance of the browser, which I don't think is necessary; the second is against the instance of Chrome which should actually be running the benchmark.

I think disabling the first trace data connection should resolve this - I've submitted a patch to do this here:

https://codereview.chromium.org/3002793002/

Comment 4 by ka...@chromium.org, Sep 25 2017

Status: Verified (was: Unconfirmed)
Looks resolved to me. Closing

Comment 5 by ka...@chromium.org, Sep 25 2017

Components: Speed>Telemetry
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment