New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756317 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Direct-leak in google_breakpad::StackwalkerPPC::GetCallerFrame

Project Member Reported by ClusterFuzz, Aug 17 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5921226391552000

Fuzzer: libFuzzer_minidump_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  google_breakpad::StackwalkerPPC::GetCallerFrame
  google_breakpad::Stackwalker::Walk
  google_breakpad::MinidumpProcessor::Process
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=494860:494945

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5921226391552000

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org
Labels: M-62 Test-Predator-Wrong-CLs
Owner: tobiasjs@chromium.org
Status: Assigned (was: Untriaged)
Predator did not provide any possible suspects.
Assigning to concern owner from CL --
https://chromium.googlesource.com/chromium/src/+log/64851d6549e974416f48bf85a95621076393ae16..9839ce4e4a0db225f4fc728ccae96a7e40757482?pretty=fuller

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/3c8f89b92430895e9c98f8540fb90f308ea47cc3

@tobiasjs -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/breakpad/breakpad/+/b1e7ec065d5d7312fd4534d8231a6164276cb281

commit b1e7ec065d5d7312fd4534d8231a6164276cb281
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Fri Aug 18 10:24:52 2017

Fix memory leak in ppc stackwalker

BUG= 756317 

Change-Id: Id096372e5a0d1e7c70e95304b1f0c181f57d3882
Reviewed-on: https://chromium-review.googlesource.com/619126
Reviewed-by: Leonard Mosescu <mosescu@chromium.org>

[modify] https://crrev.com/b1e7ec065d5d7312fd4534d8231a6164276cb281/src/processor/stackwalker_ppc.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c62c0cb08515ed37f0ff5f6b0391db7915227c

commit b4c62c0cb08515ed37f0ff5f6b0391db7915227c
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Fri Aug 18 16:37:20 2017

Roll src/breakpad/src/ 877d207e7..e6bc67c33 (1 commit)

https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/877d207e755e..e6bc67c33952

$ git log 877d207e7..e6bc67c33 --date=short --no-merges --format='%ad %ae %s'
2017-08-17 tobiasjs Fix memory leak in ppc stackwalker

Created with:
  roll-dep src/breakpad/src

R=bauerb@google.com
BUG= 756317 

Change-Id: I0c8d29c0bbf7a6bdc30a0062c609010a62c6839e
Reviewed-on: https://chromium-review.googlesource.com/620708
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495577}
[modify] https://crrev.com/b4c62c0cb08515ed37f0ff5f6b0391db7915227c/DEPS

Project Member

Comment 4 by ClusterFuzz, Aug 19 2017

ClusterFuzz has detected this issue as fixed in range 495546:495593.

Detailed report: https://clusterfuzz.com/testcase?key=5921226391552000

Fuzzer: libFuzzer_minidump_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  google_breakpad::StackwalkerPPC::GetCallerFrame
  google_breakpad::Stackwalker::Walk
  google_breakpad::MinidumpProcessor::Process
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=494860:494945
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=495546:495593

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5921226391552000

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Aug 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5921226391552000 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment