New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756315 link

Starred by 3 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Aug 2017
Cc:
█ krajshree@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Colour difference is seen for Tick boxes and "Ok" button in manage certificates

Project Member Reported by divya.pa...@techmahindra.com, Aug 17 2017 
Chrome Version: 62.0.3188.0 
OS:Ubuntu 14.04 

What steps will reproduce the problem?
(1)Launch chrome>> Navigate to chrome://settings/certificates>> click on authorities
(2)Expand the list>> Click on 3Dot menu>> Edit

Expected 
The colour of Tick boxes and the "Ok" button should be same

Actual
The colour of Tick boxes and the "Ok" button appears to be different

This is a Regression issue broken in M-62

Note: UI on windows for manage certificates is different, hence the above mentioned scenario is not applicable for win
Actual tickbox color.png
136 KB View Download

Comment 1 by divya.pa...@techmahindra.com, Aug 17 2017

Summary: Regression: Colour difference is seen for Tick boxes and "Ok" button in manage certificates (was: Regression: )

Comment 2 by divya.pa...@techmahindra.com, Aug 17 2017

Description: Show this description

Comment 3 by divya.pa...@techmahindra.com, Aug 17 2017 

Below is the manual bisect info:
===========================
Good Build: 62.0.3186.0
Bad Build: 62.0.3187.0
Expected tick box.png
133 KB View Download

Comment 4 by ajha@chromium.org, Aug 17 2017

Status: Untriaged (was: Unconfirmed)
Issue is reproducible on the Linux Ubuntu 14.04 using chrome version:62.0.3188.0. No chrome://settings/certificates page is seen on Mac OS 10.12.6.

Comment 5 by sandeepkumars@chromium.org, Aug 17 2017

Labels: -Needs-Bisect hasbisect-per-revision
Bisect Information:
-------------------
You are probably looking for a change made after 494284 (known good), but no later than 494285 (first known bad).

CHANGELOG URL:
--------------
https://chromium.googlesource.com/chromium/src/+log/afaf723eba403dc2d0a6745f12726c6e3c310ba8..a9ff15ca6eb57dcc3d895fd89471ed364bb37e3a

@stevenjb: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 6 by sandeepkumars@chromium.org, Aug 17 2017

Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by divya.pa...@techmahindra.com, Aug 17 2017

Description: Show this description

Comment 8 by steve...@chromium.org, Aug 17 2017

Status: Started (was: Assigned)
Confirmed, this is probably related to the code move, will fix.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/811dc91fe13ab1939aaab067e429c32d98e65faf

commit 811dc91fe13ab1939aaab067e429c32d98e65faf
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Aug 22 18:10:00 2017

WeUI: Move checkbox style to separate file

Bug:  756315 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idfd414e5318a84005a7d2cf2203fec082da12cf3
Reviewed-on: https://chromium-review.googlesource.com/619318
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496369}
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/chrome/browser/resources/settings/date_time_page/date_time_page.html
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/chrome/browser/resources/settings/device_page/keyboard.html
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/chrome/browser/resources/settings/settings_vars_css.html
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/ui/webui/resources/cr_components/certificate_manager/ca_trust_edit_dialog.html
[add] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/ui/webui/resources/cr_elements/paper_checkbox_style_css.html
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/ui/webui/resources/cr_elements/shared_vars_css.html
[modify] https://crrev.com/811dc91fe13ab1939aaab067e429c32d98e65faf/ui/webui/resources/cr_elements_resources.grdp

Comment 10 by steve...@chromium.org, Aug 22 2017

Status: Fixed (was: Started)

Comment 11 by divya.pa...@techmahindra.com, Aug 23 2017

Labels: TE-Verified-62.0.3194.0 TE-Verified-M62
 Above issue is fixed on latest Dev version 62.0.3194.0 Linux OS with the mentioned steps..

Thank you!
►

Sign in to add a comment