New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756313 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

shelf is still visible with fullscreen window.

Project Member Reported by osh...@chromium.org, Aug 17 2017

Issue description

chrome: 60.0.3112.80 on samus

Repro:
play youtube video and go fullscreen.

shelf should be hidden but it's still visible.

This is pretty bad. I didn't notice this in recent build, so it could have been already fixed (if we're lucky). I'll look into it tomorrow.
 

Comment 1 by osh...@chromium.org, Aug 17 2017

Labels: -Pri-1 -M-60 Pri-2
Restarting chrome fixed it. I guess I did something that caused this state.

This is probably not a regression so lowering priority.
Components: UI>Shell>Shelf
Owner: minch@chromium.org
Status: Assigned (was: Untriaged)
Min, can you please take a look? Thanks!
Cc: msw@chromium.org
msw, ideas?

oshima, any other clues about this? I presume this was on an internal display, not external? Do you use multiprofile? Any chance the mouse position was over the shelf? Does your samus suffer from occasional false touch events? (I have one with a flaky touch sensor that causes touch events near the bezel sometimes.)

Code for shelf fullscreen is at https://cs.chromium.org/chromium/src/ash/shelf/shelf_layout_manager.cc?q=shelf_layout_manager.cc&sq=package:chromium&l=1097

(Also just FYI for Min, there is a different between HTML fullscreen that YouTube uses and the regular immersive fullscreen you get when hitting the fullscreen keyboard key.)

Comment 5 by minch@chromium.org, Aug 17 2017

oshima@, can you still repro it? What I tried in 62.0.3188.0 on caroline
1. open the youtube
2. click fullscreen keyboard key

Or make the video in youtube page fullscreen

Shelf will be hidden. 

Comment 6 by osh...@chromium.org, Aug 17 2017

It happened with non immersive fullscreen (html5 fullscreen) where you can't show the shelf, so I believe this has nothing to do with events.

I guess the code that detect fullscreen mode for shelf was somehow not working correctly.

https://cs.chromium.org/chromium/src/ash/wm/workspace_controller.cc?rcl=3e8cc0d744079b603ce80a4201f3f0e768392ddf&l=56

Comment 7 by osh...@chromium.org, Aug 18 2017

It just happened again.

Looks like the window's ignored_by_shelf is set to true. Maybe someone sets it temporarily but didn't set it back to false.

Comment 8 by osh...@chromium.org, Aug 18 2017

Labels: M-60 M-61
Owner: osh...@chromium.org
Status: Started (was: Assigned)
Found the bug. Will send CL shortly.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea65a745e112a8585a75b15e18c4f7dbc72fa13e

commit ea65a745e112a8585a75b15e18c4f7dbc72fa13e
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Aug 18 19:01:14 2017

Restore minimized window's ignored_by_shelf state correctly

when exiting overview mode

BUG= 756313 
TEST=covered by unit test (reused old disabled test)

Change-Id: I93bffc61b12b03a25dba36a18d0ea4596dd24297
Reviewed-on: https://chromium-review.googlesource.com/620151
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495637}
[modify] https://crrev.com/ea65a745e112a8585a75b15e18c4f7dbc72fa13e/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/ea65a745e112a8585a75b15e18c4f7dbc72fa13e/ash/wm/overview/window_selector_unittest.cc

Cc: keta...@chromium.org josa...@chromium.org
Labels: Merge-Request-61 Merge-Request-60
It's probably too late to merge to 60, but trying anyway :)
Labels: -Merge-Request-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 18 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc7e55d2f5c9a42ef7fdf253b9e0eca77e602d2e

commit bc7e55d2f5c9a42ef7fdf253b9e0eca77e602d2e
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Aug 18 20:54:18 2017

Restore minimized window's ignored_by_shelf state correctly

when exiting overview mode

BUG= 756313 
TEST=covered by unit test (reused old disabled test)

(cherry picked from commit ea65a745e112a8585a75b15e18c4f7dbc72fa13e)

Change-Id: I93bffc61b12b03a25dba36a18d0ea4596dd24297
Reviewed-on: https://chromium-review.googlesource.com/620151
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495637}
Reviewed-on: https://chromium-review.googlesource.com/621968
Cr-Commit-Position: refs/branch-heads/3163@{#683}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/bc7e55d2f5c9a42ef7fdf253b9e0eca77e602d2e/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/bc7e55d2f5c9a42ef7fdf253b9e0eca77e602d2e/ash/wm/overview/window_selector_unittest.cc

Labels: -M-60 -Merge-Request-60 Merge-Rejected-60
We are only accepting critical/security fixes for M60 at this point.
Based on the description, it does not seem to warrant cherry picking to M60 this late.

Let deliver this fix with M-61

Status: Fixed (was: Started)
Project Member

Comment 15 by sheriffbot@chromium.org, Aug 22 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Aug 28 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Labels: -Merge-Approved-61 -Merge-Rejected-60

Sign in to add a comment