New issue
Advanced search Search tips

Issue 756286 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 557406
issue 681072



Sign in to add a comment

mash: QuickLaunch shelf item doesn't respond to selection.

Project Member Reported by msw@chromium.org, Aug 17 2017

Issue description

mash: QuickLaunch shelf item doesn't respond to selection.
(1) Run "chrome --mash" on ToT (should see a chrome window in front)
(2) Click the "QuickLaunch" shelf item with the default/page icon [repeatedly].
Expected: The QuickLaunch window is brought to the front, [minimized, restored, repeat].
Actual: Nothing happens, debugging shows the shelf item delegate isn't notified...

I'm not sure why the QuickLaunch shelf item delegate is no longer notified.
Other ShelfWindowWatcherItemDelegate instances (task manager, cros settings) work fine.

Found while working on my context menu CL; QuickLaunch's context menu will also break:
  https://chromium-review.googlesource.com/c/571517
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d39a94e24de4b753c3cea3136d03d6fe33ecb53

commit 2d39a94e24de4b753c3cea3136d03d6fe33ecb53
Author: Mike Wasserman <msw@chromium.org>
Date: Fri Aug 18 23:21:53 2017

mash: Fix QuickLaunch shelf item delegate.

Notify chrome of the delegate before the item itself.
(otherwise chrome makes a conflicting default delegate)

Bug:  756286 
Test: Clicking the QuickLaunch shelf item in chrome --mash works.
Change-Id: I114fe04b236ff03dd304b15d5bb040113836952c
Reviewed-on: https://chromium-review.googlesource.com/622153
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495738}
[modify] https://crrev.com/2d39a94e24de4b753c3cea3136d03d6fe33ecb53/ash/shelf/shelf_controller.cc

Comment 2 by msw@chromium.org, Aug 18 2017

Status: Fixed (was: Assigned)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment