Cannot connect to It2me host registered using an LCS address. |
||
Issue descriptionWhat steps will reproduce the problem? (1) Register an It2me host using an LCS address. (2) Connect to it from the Chrome App. What is the expected result? I can connect. What happens instead? The connection failed with Host is Offline.
,
Aug 17 2017
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0136a231d96aa63bc3921248dab99245b80ce856 commit 0136a231d96aa63bc3921248dab99245b80ce856 Author: kelvinp@chromium.org <kelvinp@chromium.org> Date: Wed Aug 23 20:05:25 2017 Fix connection error to IT2ME host registered in the LCS channel. Root cause: The Chrome App doesn't know how to encode an LCS address properly in an IQ message. Fix: Modifies SignalingAddress constructor to infer the channel type from on the contents of the JID string. Modifies SignalingAddress:SetInMessage() to use id() when setting the |from| field in non-jingle messages. In the case of register-support-host request, the |from| field is stored along with the access code for support host lookup. This change requires the SignalingAddress to obtain the default bot JID from ServiceUrls. ServiceUrls currently read the override URLs from the command line, which is uninitialized when running under NaCl and causes the plugin to crash. Therefore, we need to modify service URLs to provide alternate way of overriding the bot jid. Bug: 756277 Change-Id: Icb8c093b27b097fb78acb7487f421124d5595db3 Reviewed-on: https://chromium-review.googlesource.com/617846 Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#496779} [modify] https://crrev.com/0136a231d96aa63bc3921248dab99245b80ce856/remoting/base/BUILD.gn [modify] https://crrev.com/0136a231d96aa63bc3921248dab99245b80ce856/remoting/base/service_urls.cc [modify] https://crrev.com/0136a231d96aa63bc3921248dab99245b80ce856/remoting/base/service_urls.h [modify] https://crrev.com/0136a231d96aa63bc3921248dab99245b80ce856/remoting/client/plugin/chromoting_instance.cc [modify] https://crrev.com/0136a231d96aa63bc3921248dab99245b80ce856/remoting/host/register_support_host_request.cc [modify] https://crrev.com/0136a231d96aa63bc3921248dab99245b80ce856/remoting/signaling/signaling_address.cc [modify] https://crrev.com/0136a231d96aa63bc3921248dab99245b80ce856/remoting/signaling/signaling_address.h [modify] https://crrev.com/0136a231d96aa63bc3921248dab99245b80ce856/remoting/signaling/signaling_address_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by kelv...@chromium.org
, Aug 17 2017