New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756276 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 760777

Blocking:
issue 537875
issue 760195



Sign in to add a comment

Expose private memory footprint in Chrome task manager.

Project Member Reported by erikc...@chromium.org, Aug 17 2017

Issue description

It's a more meaningful and reliable metric than any of the existing numbers shown in the task manager.
 
Blocking: 760195
Put together a mini design doc, started a thread on chromium-dev, as per brettw@'s suggestion. 
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/ELSYMXnvbBc
Blockedon: 760777
Blocking: 537875
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f

commit 4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f
Author: Erik Chen <erikchen@chromium.org>
Date: Tue Oct 03 22:59:57 2017

Switch task manager to use the memory_instrumentation interface.

The memory_instrumentation interface on the content_browser service exposes
cross-platform, consistent memory metrics that should also be used by the task
manager.

This CL adds a new column to the task manager: Memory Footprint. See
https://docs.google.com/document/d/1PZyRzChnvkUNUB85Op46aqkFXuAGUJi751DJuB6O40g/edit#
for more details.

Bug:  756276 
Change-Id: I68fdd6868a231840a1a8401dcd7ec50ffb0af068
Reviewed-on: https://chromium-review.googlesource.com/646047
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506220}
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/app/generated_resources.grd
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/sampling/shared_sampler_win.cc
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/sampling/task_group.cc
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/sampling/task_manager_impl.h
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/task_manager_browsertest_util.cc
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/task_manager_browsertest_util.h
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/task_manager_interface.h
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/task_manager_observer.h
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/task_manager_tester.cc
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/test_task_manager.cc
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/task_manager/test_task_manager.h
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f/chrome/browser/ui/task_manager/task_manager_table_model.cc

I was looking at extensions today and noticed that private bytes was significantly larger than WS private for both of them.

Beyond Corp: 17 MB versus 34 MB
Password Alsert: 13.5 versus 28.5 MB

Is there a separate bug for investigating and reducing this discrepancy to avoid memory-shock?

Cc: ajwong@chromium.org
The difference is mostly caused by partition alloc. Albert is investigating. https://bugs.chromium.org/p/chromium/issues/detail?id=765406
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ca32dcf84a64a0f6522a09bd4d19af270eb079e

commit 0ca32dcf84a64a0f6522a09bd4d19af270eb079e
Author: Kentaro Hara <haraken@chromium.org>
Date: Wed Oct 04 06:10:59 2017

Revert "Switch task manager to use the memory_instrumentation interface."

This reverts commit 4925a99f1f1c95509e319a4a86bd0ff63d0a0a6f.

Reason for revert: Let me speculatively revert this CL for the failure of SitePerProcess/TaskManagerOOPIFBrowserTest.SubframeHistoryNavigation/0

https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/34724

Original change's description:
> Switch task manager to use the memory_instrumentation interface.
> 
> The memory_instrumentation interface on the content_browser service exposes
> cross-platform, consistent memory metrics that should also be used by the task
> manager.
> 
> This CL adds a new column to the task manager: Memory Footprint. See
> https://docs.google.com/document/d/1PZyRzChnvkUNUB85Op46aqkFXuAGUJi751DJuB6O40g/edit#
> for more details.
> 
> Bug:  756276 
> Change-Id: I68fdd6868a231840a1a8401dcd7ec50ffb0af068
> Reviewed-on: https://chromium-review.googlesource.com/646047
> Reviewed-by: Nick Carter <nick@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506220}

TBR=nick@chromium.org,primiano@chromium.org,erikchen@chromium.org

Change-Id: I3c89415c3c3ceeb84f9bf4640b4613f67e1fdbbe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  756276 
Reviewed-on: https://chromium-review.googlesource.com/700177
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506319}
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/app/generated_resources.grd
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/sampling/shared_sampler_win.cc
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/sampling/task_group.cc
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/sampling/task_manager_impl.h
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/task_manager_browsertest_util.cc
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/task_manager_browsertest_util.h
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/task_manager_interface.h
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/task_manager_observer.h
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/task_manager_tester.cc
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/test_task_manager.cc
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/task_manager/test_task_manager.h
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/0ca32dcf84a64a0f6522a09bd4d19af270eb079e/chrome/browser/ui/task_manager/task_manager_table_model.cc

The test failure is caused by my patch, but the root cause is unrelated. See https://bugs.chromium.org/p/chromium/issues/detail?id=771805 for more details.

A slight change I want to make, regardless:
1) Only queue memory-infra dumps if there isn't an outstanding request.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e579d22660b2dcac51fd537ff080ccc10889c993

commit e579d22660b2dcac51fd537ff080ccc10889c993
Author: Erik Chen <erikchen@chromium.org>
Date: Fri Oct 06 22:51:29 2017

Fix a bug in visibility computation for cocoa TaskManager.

The swapped memory column is only ever shown for ChromeOS. Due to a logic bug,
its visibility is always "true" for macOS, causing the task manager to
inappropriately perform background refreshes.

Bug:  756276 
Change-Id: I9572bcc6f84a8177a8c24db709a453d247891d99
Reviewed-on: https://chromium-review.googlesource.com/706197
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507208}
[modify] https://crrev.com/e579d22660b2dcac51fd537ff080ccc10889c993/chrome/browser/ui/cocoa/task_manager_mac.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0

commit cbde21cc10818a0d9a2d4bf4c56900a37a3249d0
Author: erikchen <erikchen@chromium.org>
Date: Mon Oct 09 21:00:06 2017

[Reland #1] Switch task manager to use the memory_instrumentation interface.

The original CL caused a renderer hang for a macOS ASAN browser test. For an
in-depth investigation, see
https://bugs.chromium.org/p/chromium/issues/detail?id=771805. The root cause was two fold:
  * A logic error in the original CL incorrectly caused memory details to be
  refreshed when only the memory footprint needed to be refreshed. Fixed in this
  reland.
  * A logic error in the cocoa TaskManager caused memory details to always be
  refreshed. Fixed in
  https://chromium-review.googlesource.com/c/chromium/src/+/706197.

This CL also contains a minor optimization - the task manager will only ever
queue a single memory dump at a time.

> The memory_instrumentation interface on the content_browser service exposes
> cross-platform, consistent memory metrics that should also be used by the task
> manager.
>
> This CL adds a new column to the task manager: Memory Footprint. See
> https://docs.google.com/document/d/1PZyRzChnvkUNUB85Op46aqkFXuAGUJi751DJuB6O40g/edit#
> for more details.
>
> Bug:  756276 
> Reviewed-on: https://chromium-review.googlesource.com/646047
> Reviewed-by: Nick Carter <nick@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506220}

Change-Id: I6fc43d064206bc614c52f84515f73dd98832f122
Bug: 
Reviewed-on: https://chromium-review.googlesource.com/706336
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507483}
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/app/generated_resources.grd
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/sampling/shared_sampler_win.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/sampling/task_group.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/sampling/task_group_sampler.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/sampling/task_manager_impl.h
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/task_manager_browsertest_util.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/task_manager_browsertest_util.h
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/task_manager_interface.h
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/task_manager_observer.h
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/task_manager_tester.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/test_task_manager.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/task_manager/test_task_manager.h
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/cbde21cc10818a0d9a2d4bf4c56900a37a3249d0/chrome/browser/ui/task_manager/task_manager_table_model.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22caa0f5861d1584fa3b9428f4e5bdefe9725bae

commit 22caa0f5861d1584fa3b9428f4e5bdefe9725bae
Author: Erik Chen <erikchen@chromium.org>
Date: Mon Oct 09 22:54:27 2017

Revert "[Reland #1] Switch task manager to use the memory_instrumentation interface."

This reverts commit cbde21cc10818a0d9a2d4bf4c56900a37a3249d0.

Reason for revert: Causes ASAN test timeouts.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FMac_ASan_64_Tests__1_%2F34934%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FSitePerProcess__x2f_TaskManagerOOPIFBrowserTest.SubframeHistoryNavigation__x2f_0%2F0

Original change's description:
> [Reland #1] Switch task manager to use the memory_instrumentation interface.
> 
> The original CL caused a renderer hang for a macOS ASAN browser test. For an
> in-depth investigation, see
> https://bugs.chromium.org/p/chromium/issues/detail?id=771805. The root cause was two fold:
>   * A logic error in the original CL incorrectly caused memory details to be
>   refreshed when only the memory footprint needed to be refreshed. Fixed in this
>   reland.
>   * A logic error in the cocoa TaskManager caused memory details to always be
>   refreshed. Fixed in
>   https://chromium-review.googlesource.com/c/chromium/src/+/706197.
> 
> This CL also contains a minor optimization - the task manager will only ever
> queue a single memory dump at a time.
> 
> > The memory_instrumentation interface on the content_browser service exposes
> > cross-platform, consistent memory metrics that should also be used by the task
> > manager.
> >
> > This CL adds a new column to the task manager: Memory Footprint. See
> > https://docs.google.com/document/d/1PZyRzChnvkUNUB85Op46aqkFXuAGUJi751DJuB6O40g/edit#
> > for more details.
> >
> > Bug:  756276 
> > Reviewed-on: https://chromium-review.googlesource.com/646047
> > Reviewed-by: Nick Carter <nick@chromium.org>
> > Reviewed-by: Primiano Tucci <primiano@chromium.org>
> > Commit-Queue: Erik Chen <erikchen@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#506220}
> 
> Change-Id: I6fc43d064206bc614c52f84515f73dd98832f122
> Bug: 
> Reviewed-on: https://chromium-review.googlesource.com/706336
> Reviewed-by: Nick Carter <nick@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507483}

TBR=nick@chromium.org,erikchen@chromium.org

Change-Id: Ie811aff981e996d7f339845edc02c4bb1c4c8cd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/707782
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507519}
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/app/generated_resources.grd
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/sampling/shared_sampler_win.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/sampling/task_group.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/sampling/task_group_sampler.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/sampling/task_manager_impl.h
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/task_manager_browsertest_util.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/task_manager_browsertest_util.h
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/task_manager_interface.h
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/task_manager_observer.h
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/task_manager_tester.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/test_task_manager.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/task_manager/test_task_manager.h
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/22caa0f5861d1584fa3b9428f4e5bdefe9725bae/chrome/browser/ui/task_manager/task_manager_table_model.cc

"""
../../chrome/browser/task_manager/task_manager_browsertest_util.cc:136: Failure
Failed
Timed out.
Waiting for exactly 1 matches of wildcard pattern "Subframe: http://d.com/" && [Memory Footprint >= 1000]
Currently there are 0 matches.
Current Task Manager Model is:
  > Browser                                  [Memory Footprint == 208584704]
  > GPU Process                              [Memory Footprint == 52879360]
  > Tab: Cross-site iframe factory           [Memory Footprint == 87560192]
  > Tab: Cross-site iframe factory           [Memory Footprint == 87560192]
  > Subframe: http://b.com/                  [Memory Footprint == 82747392]
  > Subframe: http://b.com/                  [Memory Footprint == 82747392]
  > Subframe: http://c.com/                  [Memory Footprint == -1]
  > Subframe: http://d.com/                  [Memory Footprint == -1]
  > Subframe: http://e.com/                  [Memory Footprint == -1]
"""

The error *looks* comparable. But I cannot reproduce it locally anymore. Investigating further to see what's happening. It's possible we're seeing a timeout caused by other (?) reasons. The test does take 12s to run on my local, fast machine.
Cc: shrike@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5b5df6a535bd73a34cb2149ea090579e744493c

commit d5b5df6a535bd73a34cb2149ea090579e744493c
Author: erikchen <erikchen@chromium.org>
Date: Wed Oct 18 23:37:14 2017

[Reland #2] Switch task manager to use the memory_instrumentation interface.

Reland #1 ran into two problems.
  * Timeouts on mac ASAN tests were caused by a mojo bug. See  Issue 771805  for
  more details.
  * An incorrectly appearing views scrollbar was caused by a logic bug in
  ScrollView. See  Issue 771502  for more details.

CL description from original CL:
> The memory_instrumentation interface on the content_browser service exposes
> cross-platform, consistent memory metrics that should also be used by the task
> manager.
>
> This CL adds a new column to the task manager: Memory Footprint. See
> https://docs.google.com/document/d/1PZyRzChnvkUNUB85Op46aqkFXuAGUJi751DJuB6O40g/edit#
> for more details.
>
> Bug:  756276 
> Reviewed-on: https://chromium-review.googlesource.com/646047
> Reviewed-by: Nick Carter <nick@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#506220}

Bug:  756276 
TBR: nick@chromium.org
Change-Id: Iffae21fed72410de818180351b66003940f53a3e
Reviewed-on: https://chromium-review.googlesource.com/710172
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509929}
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/app/generated_resources.grd
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/sampling/shared_sampler_win.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/sampling/task_group.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/sampling/task_group_sampler.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/sampling/task_manager_impl.h
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/task_manager_browsertest_util.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/task_manager_browsertest_util.h
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/task_manager_interface.h
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/task_manager_observer.h
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/task_manager_tester.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/test_task_manager.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/task_manager/test_task_manager.h
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/d5b5df6a535bd73a34cb2149ea090579e744493c/chrome/browser/ui/task_manager/task_manager_table_model.cc

Status: Fixed (was: Assigned)

Sign in to add a comment