New issue
Advanced search Search tips

Issue 756269 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

Add support for GTest death tests on Fuchsia.

Project Member Reported by kmarshall@chromium.org, Aug 17 2017

Issue description

Add support for GTest death tests on Fuchsia and the EXPECT_DEATH macro. 
See TestBrowserThreadBundleTest::MessageLoopTypeMismatch() for example usage.
 
Components: Internals>PlatformIntegration
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec

commit e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Aug 22 23:20:06 2017

Fuchsia: miscellaneous fixes to make content_unittests buildable.

* Disable POSIX signalling from BrowserTestBase for Fuchsia
  (not compatible).
* Switch EXPECT_DEATH tests to EXPECT_DEATH_IF_SUPPORTED for
  TestBrowserThreadBundleTest.
* Add fuchsia to the list of supported platforms in
  fieldtrial_to_struct.py.
* Move webrtc deps into "enable_webrtc" conditional block.


Bug:  754861 ,  756269 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2cce36ca3cebfeb0acf86ad0c2cf0cd0f8645f51
Reviewed-on: https://chromium-review.googlesource.com/619727
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496498}
[modify] https://crrev.com/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec/content/public/test/browser_test_base.cc
[modify] https://crrev.com/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec/content/public/test/test_browser_thread_bundle_unittest.cc
[modify] https://crrev.com/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec/content/test/BUILD.gn
[modify] https://crrev.com/e9ff0fe3d2ccba8bc7a8b4414e87c89122f189ec/tools/variations/fieldtrial_to_struct.py

Comment 3 by w...@chromium.org, Apr 2 2018

Owner: fdegans@chromium.org
Status: Assigned (was: Untriaged)
fdegans: PTAL - basically we'll want to follow the same implementation style as Windows, which has a mechanism to spawn a new process and re-run the individual test, up to the particular EXPECT_DEATH() expectation, and monitors that process to verify that it crashes.  Under Fuchsia we can trap the crash with https://fuchsia.googlesource.com/zircon/+/master/docs/syscalls/task_bind_exception_port.md and hopefully we can re-use most of the Windows logic for choosing which expectation(s) to run.
Project Member

Comment 4 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44e1ef6e562801affedceea96ca7a20008bdad48

commit 44e1ef6e562801affedceea96ca7a20008bdad48
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Mon May 07 21:20:41 2018

Roll src/third_party/googletest/src/ a6f06bf2f..045e7f9ee (9 commits)

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/a6f06bf2fd3b..045e7f9ee4f9

$ git log a6f06bf2f..045e7f9ee --date=short --no-merges --format='%ad %ae %s'
2018-05-03 steelskin Remove magic number
2018-05-03 steelskin Style fix
2018-05-03 steelskin Fix comments
2018-05-03 fdegans Fix more stuff and get tests to pass
2018-05-02 fdegans Get all the things to work.
2018-05-01 fdegans Fix stuff
2018-05-01 fdegans Add Fuchsia support for death test.
2018-04-27 scottmg Add no-exception and no-rtti to build matrix
2018-04-25 misterg merging,

Created with:
  roll-dep src/third_party/googletest/src

Bug:  756269 
Change-Id: I0b614850226ce63f2e2f9985e91802df6b92fbfe
Reviewed-on: https://chromium-review.googlesource.com/1048110
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556570}
[modify] https://crrev.com/44e1ef6e562801affedceea96ca7a20008bdad48/DEPS

Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0137029457b860c8560bbd9f05c9db08fba4d3f

commit f0137029457b860c8560bbd9f05c9db08fba4d3f
Author: Wez <wez@chromium.org>
Date: Wed May 09 10:26:16 2018

Fuchsia: Add missing googletest dependency to fix the component build.

This adds the necessary SDK library dependency for the Fuchsia build
to compile in component mode.

Bug:  756269 
TBR: dpranke
Change-Id: I110a4599273967aa99709ed20f187f2e2713b05a
Reviewed-on: https://chromium-review.googlesource.com/1048633
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557136}
[modify] https://crrev.com/f0137029457b860c8560bbd9f05c9db08fba4d3f/third_party/googletest/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19263bdd1bf74d915bce7acaf4dfb58b26f27ad3

commit 19263bdd1bf74d915bce7acaf4dfb58b26f27ad3
Author: Fabrice de Gans-Riberi <fdegans@chromium.org>
Date: Tue May 22 19:28:51 2018

Roll src/third_party/googletest/src/ 08d5b1f33..145d05750 (7 commits)

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/08d5b1f33af8..145d05750b15

$ git log 08d5b1f33..145d05750 --date=short --no-merges --format='%ad %ae %s'
2018-05-21 jdennett Downgrade to C++98.
2018-05-21 jdennett Downgrade to C++98 code.
2018-05-11 steelskin Remove unused variable in Fuchsia.
2018-05-10 jdennett Add support for versioned standard libraries.
2018-05-10 jdennett Update generated code.
2018-05-10 jdennett Add unit test for CanonicalizeForStdLibVersioning.
2018-05-02 scottmg Fix gmock not building when -fno-rtti

Created with:
  roll-dep src/third_party/googletest/src

Bug:  756269 
Change-Id: I785635e4cab1b511aed5715dd8b949d813dcf20e
Reviewed-on: https://chromium-review.googlesource.com/1069293
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560730}
[modify] https://crrev.com/19263bdd1bf74d915bce7acaf4dfb58b26f27ad3/DEPS

Status: Fixed (was: Assigned)
gtest rolled into chromium, all the bots seem happy, including cast and FYI. Hopefully that's the end of it :)

Sign in to add a comment