Issue metadata
Sign in to add a comment
|
Tab title text sometimes goes blurry after dragging a tab (non-retina) |
||||||||||||||||||||
Issue descriptionChrome Version : 62.0.3187.0 OS Version: OS X 10.12.6 What steps will reproduce the problem? 1. Drag a few tabs around, notice the text goes blurry What is the expected result? No blurry What happens instead of that? Blurry. Attaching some screenshots. You probably need to look at them on a non-retina screen for the blurriness to manifest. In the first screenshot, just the second tab is blurry. In the second screenshot, the second and third tabs are blurry. Resizing the window makes the blurriness go away. I'm suspecting some SDK 10.12 issue.
,
Aug 17 2017
Tested the issue on Mac OS 10.12.6 using chrome M62 #62.0.3187.0 and observed that tab title text blur while dragging the tab . Attached screencast for reference. @tapted-- Could you please check attached screencast and confirm us if this is the issue which you are talking about in screencast from 0.35 secs to 0.45 secs. And also please help us with more steps to repro the issue. Note : Unable to find the blur after dragging a tab. Thanks!
,
Aug 18 2017
Blur while dragging a tab is expected. The problem is when the blurriness sticks around after releasing the tab and having it animate to its final position. That still happens for me about 1-in-5 times on 62.0.3188.0 but not on 62.0.3178.0 dev. Maybe this is related to format:commit ec48b797b4081fac96bc33a4f0bfd281bfb3c682 Author: Sidney San Martín <sdy@chromium.org> CommitDate: Tue Aug 15 10:57:05 2017 Insert the content view above other views when tearing down an overlay window. This fixes an issue where the content ended up under the tab strip background view after dragging a tab out into a new window. Bug: 755188 Change-Id: I24f0da5a10b558ce426e1e080722887c44a37632 Reviewed-on: https://chromium-review.googlesource.com/614087 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#494277} I'll run a bisect if I get a chance today.
,
Aug 18 2017
Thank you for providing more feedback. Adding requester "hdodda@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 18 2017
Tested the issue on Mac os 10.12.6 using chrome M62 #62.0.3188.0 and unable to see the blur after dragging a tab. Thanks!
,
Aug 18 2017
Could this be related/dupe of issue 754140 ?
,
Aug 19 2017
Yeah - might be related. I'd seen that in dev channel (62.0.3178.0). But couldn't repro in canary. I can also see this on retina screens (tested: Version 62.0.3187.0), but the pixels are tiny so it's hard to notice. In the photos below, you can see the stem of the blurry T spans (retina) 5 pixels, but the crisp T only spans 4. (haven't tried a bisect yet).
,
Aug 20 2017
Hi, I see a difference of the tab title font between Chrome 60 Stable and latest Chrome 62 Canary when I drag and move the tab. In Canary the tab title font is blurry during the dragging and in Stable it is crisp. Please find attached two screencast comparing the two builds. I am using a MacBook Air 11" Non-Retina.
,
Aug 21 2017
I bisected to You are probably looking for a change made after 492971 (known good), but no later than 492972 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/d5ea6ad9b7b5af521c634c6461227c619b6728a1..1f71c6ec3d33ac53f8e2474fbfd9e6396f731008 1f71c6e Use a custom frame view class for browser windows. by Sidney San Martín · 11 days ago r492972 -> https://chromium-review.googlesource.com/562603 Although I noticed on the "good" revisions tabs sometimes got stuck in other ways (see attached). They just didn't go blurry :/
,
Aug 21 2017
,
Aug 21 2017
> Although I noticed on the "good" revisions tabs sometimes got stuck in other ways. This has been already reported in issue 754140 . But it is not easy to reproduce.
,
Nov 30 2017
I've found a consistent repro case in issue 764923 - The key is that you have to mouse-up on the tab to drop it while it's moving quickly. A video is attached in that bug
,
Nov 30 2017
Issue 764923 has been merged into this issue.
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe9306b1223c8a20bf83096aa940e02678109c08 commit fe9306b1223c8a20bf83096aa940e02678109c08 Author: Sidney San Martín <sdy@chromium.org> Date: Mon Dec 18 17:53:31 2017 Fix tabs getting stuck between pixels after a drag. The placeholder frame is based on `-[NSEvent mouseLocation]`, which isn't aligned to device pixels. Use `-centerScanRect:` to align it before storing it. Bug: 756262 Change-Id: I54dd54866a3fe0433c986b368d563d51d4f2256f Reviewed-on: https://chromium-review.googlesource.com/832826 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524739} [modify] https://crrev.com/fe9306b1223c8a20bf83096aa940e02678109c08/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm
,
Dec 18 2017
This should be fixed in tomorrow's canary.
,
Dec 18 2017
(FWIW, I believe that the bisect pointed to my frame CL because it made the tab strip layer backed.)
,
Dec 19 2017
Tested this issue on Mac 10.12.6 (non retina) as per the C#0 & C#3 using latest canary- 65.0.3299.0.Observed no blurry text while dragging tabs & also once dragging is done.As per C#9, tabs are not getting stuck. tapted@ Please find the attached screencast for reference & confirm the fix and the expected behavior are same? Thanks in advance..!
,
Dec 20 2017
looks good - thanks for the fix Sidney!
,
Dec 20 2017
🙌
,
Dec 21 2017
As it is working as intended on mac using chrome#65.0.3299.0.Hence adding TE Verified labels. Thanks.! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Aug 17 2017