New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756256 link

Starred by 1 user
Status: Fixed
Owner:
█ phulce@chromium.org
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

DevTools: Audits get re-encoded response size

Project Member Reported by phulce@chromium.org, Aug 17 2017 
Audits panel cannot currently estimate the amount of savings from cross-origin images and takes a significant amount of time for data URIs to serialize across the wire numerous times. 

A method that allowed us to compute the size of a particular network request if it were re-encoded with specific settings would solve each of these issues with minimal protocol traffic required.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af59d7c586b5d4333e95371a5bc8227024640cc8

commit af59d7c586b5d4333e95371a5bc8227024640cc8
Author: Patrick Hulce <phulce@chromium.org>
Date: Sat Aug 19 21:21:27 2017

DevTools: Add new Audits domain and getEncodedResponse

* Adds a new Audits domain with InspectorAuditsAgent.
* Adds an Audits.getEncodedResponse method that returns the
  request body and size with the specified encoding.
* Refactors NetworkAgent to support FetchResourceContent
  using a requestId.
* Adds a basic explicit test for Network.getResponseBody

BUG= 756256 

Change-Id: I263f38e5422ed2af695a5a3ee502d6e5044ee1e0
Reviewed-on: https://chromium-review.googlesource.com/617991
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495826}
[modify] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/content/browser/devtools/protocol/schema_handler.cc
[add] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/audits/get-encoded-response-expected.txt
[add] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/audits/get-encoded-response.js
[add] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/get-response-body-expected.txt
[add] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/get-response-body.js
[modify] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/Source/core/inspector/BUILD.gn
[add] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/Source/core/inspector/InspectorAuditsAgent.cpp
[add] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/Source/core/inspector/InspectorAuditsAgent.h
[modify] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
[modify] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/af59d7c586b5d4333e95371a5bc8227024640cc8/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json

Comment 2 by phulce@chromium.org, Aug 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment