cros-workon ebuilds are not automatically uprev'd when only files are deleted |
|||
Issue descriptionhttps://chromium-review.googlesource.com/c/600772 deleted some files from the files directory of an ebuild and that's all it did. This did not trigger an uprev of the ebuild and as a result the CL made it through the CQ and caused a bunch of failures in a later run when the package did get rebuilt. Is this working as intended? I feel like this is an easy way for someone to accidentally shoot themselves in the foot without realizing.
,
Aug 17 2017
This is ChromiumOS issue. Please use Infra>Client>ChromeOS for such issues.
,
Aug 17 2017
This is KI / WAI.
OTOH, there is a pre-submit hook to save you from this situation:
* Changelist probably needs a revbump of an ebuild, or a -r1.ebuild symlink if this is a new ebuild:
/work/chromiumos/src/third_party/chromiumos-overlay/sys-boot/libpayload
--------------------------------
pprabhu@pprabhu:libpayload$ ru
Errors in PROJECT *chromiumos/overlays/chromiumos-overlay*!
COMMIT 7a40e0a4:
Description:
>DO NOT REVIEW
>
>Change-Id: I89bd8a4346d7a76453882c4289ad188b703f462c
>
>
Errors:
* Changelist description needs BUG field (after first line):
BUG=brillo:9999 (for Brillo tracker)
BUG= chromium:9999 (for public tracker)
BUG=chrome-os-partner:9999 (for partner tracker)
BUG=b:9999 (for buganizer)
BUG=None
* Changelist description needs TEST field (after first line)
* Changelist probably needs a revbump of an ebuild, or a -r1.ebuild symlink if this is a new ebuild:
/work/chromiumos/src/third_party/chromiumos-overlay/sys-boot/libpayload
Preupload failed due to errors in project(s). HINTS:
- To disable some source style checks, and for other hints, see <checkout_dir>/src/repohooks/README
- To upload only current project, run 'repo upload .'
pprabhu@pprabhu:libpayload$ git logstat
commit 7a40e0a41b822c81ba353d9a6a266c800eb2ade1 (HEAD -> iterate_XXXYYY)
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Aug 17 11:32:09 2017 -0700
DO NOT REVIEW
Change-Id: I89bd8a4346d7a76453882c4289ad188b703f462c
sys-boot/libpayload/files/configs/config.jecht | 2 --
1 file changed, 2 deletions(-)
-------------------------------------
You somehow sidestepped the presubmit.
|
|||
►
Sign in to add a comment |
|||
Comment 1 by furquan@chromium.org
, Aug 17 2017