New issue
Advanced search Search tips

Issue 756246 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Disable HideIncorrectlySizedFullscreenFrames feature by default

Project Member Reported by steimel@chromium.org, Aug 16 2017

Issue description

We want to disable HideIncorrectlySizedFullscreenFrames feature by default, and only enable via Finch.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a695726923900fad855c969fcc3e49d5f8fd4a47

commit a695726923900fad855c969fcc3e49d5f8fd4a47
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Aug 21 22:11:17 2017

Disable HideIncorrectlySizedFullscreenFrames feature by default

Bug:  756246 
Change-Id: I5e8a1084f41f4cdc83a9ff7e434439e83e1b8a94
Reviewed-on: https://chromium-review.googlesource.com/618181
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496081}
[modify] https://crrev.com/a695726923900fad855c969fcc3e49d5f8fd4a47/content/public/common/content_features.cc

Labels: Merge-Request-61
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 22 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Merge approved for M61 branch 3163.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd1ecf218d60e0ead8cc2cdfd472c7a478b62c8

commit 6bd1ecf218d60e0ead8cc2cdfd472c7a478b62c8
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Aug 22 16:18:36 2017

Disable HideIncorrectlySizedFullscreenFrames feature by default

TBR=steimel@chromium.org

(cherry picked from commit a695726923900fad855c969fcc3e49d5f8fd4a47)

Bug:  756246 
Change-Id: I5e8a1084f41f4cdc83a9ff7e434439e83e1b8a94
Reviewed-on: https://chromium-review.googlesource.com/618181
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496081}
Reviewed-on: https://chromium-review.googlesource.com/626067
Cr-Commit-Position: refs/branch-heads/3163@{#754}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/6bd1ecf218d60e0ead8cc2cdfd472c7a478b62c8/content/public/common/content_features.cc

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2930122081b7bc8d34bfd7fa8020a33857dc9ca

commit a2930122081b7bc8d34bfd7fa8020a33857dc9ca
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Aug 24 15:19:09 2017

Revert "Disable HideIncorrectlySizedFullscreenFrames feature by default"

This reverts commit a695726923900fad855c969fcc3e49d5f8fd4a47.

Reason for revert: We want to enable this flag on canary now

Original change's description:
> Disable HideIncorrectlySizedFullscreenFrames feature by default
> 
> Bug:  756246 
> Change-Id: I5e8a1084f41f4cdc83a9ff7e434439e83e1b8a94
> Reviewed-on: https://chromium-review.googlesource.com/618181
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Tommy Steimel <steimel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496081}

TBR=jam@chromium.org,mlamouri@chromium.org,steimel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  756246 
Change-Id: I18c82278fcb4a96f0bd89b521bd3619612024bbe
Reviewed-on: https://chromium-review.googlesource.com/628478
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497052}
[modify] https://crrev.com/a2930122081b7bc8d34bfd7fa8020a33857dc9ca/content/public/common/content_features.cc

Sign in to add a comment