New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756243 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Disable media router in Guest Mode

Project Member Reported by mfo...@chromium.org, Aug 16 2017

Issue description

The component extension isn't loaded, so there's no reason to expose the UI.
Should be a simple fix to media_router_feature.cc.

 

Comment 1 by mfo...@chromium.org, Aug 16 2017

Labels: Hotlist-Fixit-PE2017 Hotlist-Polish

Comment 2 by mfo...@chromium.org, Aug 16 2017

Status: Assigned (was: Untriaged)

Comment 3 by sko...@chromium.org, Aug 21 2017

Cc: rdevlin....@chromium.org
Before we just disable it, I'd like to understand why it doesn't work in the first place.  Devlin, is there a reason why our component extension isn't loaded by default in Guest mode?

Comment 4 by mfo...@chromium.org, Aug 21 2017

Well let's try and fix the usability issue in M62 and then re-enable it later if we can resolve the underlying problem.

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/548773c650f4e9fd8ddb70d05c657af76b283c34

commit 548773c650f4e9fd8ddb70d05c657af76b283c34
Author: mark a. foltz <mfoltz@chromium.org>
Date: Tue Aug 22 18:41:58 2017

[Media Router] Disable Media Router in guest sessions.

In guest sessions/profiles, the Media Router component extension is not
loaded.  Disable the entire feature in these sessions until the loading
problem is resolved.

Bug:  756243 
Change-Id: I300c79d95a10acb75ff4d80245a0effc15f10b0e
Reviewed-on: https://chromium-review.googlesource.com/624756
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496383}
[modify] https://crrev.com/548773c650f4e9fd8ddb70d05c657af76b283c34/chrome/browser/media/router/media_router_feature.cc

Comment 6 by mfo...@chromium.org, Aug 22 2017

Status: Fixed (was: Assigned)

Comment 7 by ajha@chromium.org, Aug 23 2017

Labels: TE-Verified-M62 TE-Verified-62.0.3194.0
There doesn't seem to be any Cast option present in the latest canary(62.0.3194.0) on Windows-10, Mac OS 10.12.5 and Linux Ubuntu 14.04.  Issue 758080  seems to be WAI.

Adding the verified label for this.

Comment 8 by mfo...@chromium.org, Aug 23 2017

Cc: krajshree@chromium.org mfo...@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 758080  has been merged into this issue.

Comment 9 by mfo...@chromium.org, Mar 31 2018

Labels: -Hotlist-Fixit-PE2017

Sign in to add a comment