New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756215 link

Starred by 1 user
Status: Fixed
Owner:
nedngu...@google.com
Closed: Aug 2017
Cc:
█ xunji...@chromium.org
█ nednguyen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 755490



Sign in to add a comment

convert_legacy_wpr_archive: wpr not found

Project Member Reported by laszio@chromium.org, Aug 16 2017 
./convert_legacy_wpr_archive page_sets/data/intl_es_fr_pt-BR.json

Traceback (most recent call last):
  <module> at /ssd2/chromium/src/tools/perf/convert_legacy_wpr_archive:203
    sys.exit(main())
  main at /ssd2/chromium/src/tools/perf/convert_legacy_wpr_archive:161
    raise Exception("No .wpr files found in ", page_sets_json_file)
Exception: ('No .wpr files found in ', 'page_sets/data/intl_es_fr_pt-BR.json')



laszio@laszio0:~/chromium/src/tools/perf$ ls page_sets/data/intl_es_fr_pt-BR*
page_sets/data/intl_es_fr_pt-BR_000.wpr  page_sets/data/intl_es_fr_pt-BR_000.wpr.sha1  page_sets/data/intl_es_fr_pt-BR.json

laszio@laszio0:~/chromium/src/tools/perf$ cat page_sets/data/intl_es_fr_pt-BR.json | grep "\.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"
            "DEFAULT": "intl_es_fr_pt-BR_000.wpr"

Comment 1 by nedngu...@google.com, Aug 16 2017

Status: WontFix (was: Untriaged)
You need to fetch the wpr files to your local file system first.

./tools/perf/fetch_benchmark_deps.py page_cycler_v2.intl_es_fr_pt-BR

Let me know if this works & feel free to reopen the bug

p/s: running just ./tools/perf/fetch_benchmark_deps.py doesn't fetch this benchmarks' dependencies by default because this is a contrib benchmark.

Comment 2 by laszio@chromium.org, Aug 17 2017

Status: Untriaged (was: WontFix)
I did make sure that the wpr file exists:

laszio@laszio0:~/chromium/src/tools/perf$ ls page_sets/data/intl_es_fr_pt-BR*
page_sets/data/intl_es_fr_pt-BR_000.wpr  page_sets/data/intl_es_fr_pt-BR_000.wpr.sha1  page_sets/data/intl_es_fr_pt-BR.json

Comment 3 by nedngu...@google.com, Aug 17 2017

Owner: nedngu...@google.com
Status: Started (was: Untriaged)
Oh nvm, it's because of the regex. I have a fix
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/035971ee2ec0418a6d856ce127ede310b874a183

commit 035971ee2ec0418a6d856ce127ede310b874a183
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Aug 17 01:52:36 2017

Extend the regex that find .wpr files in convert_legacy_wpr_archive script

TBR=xunjieli@chromium.org

Bug:  756215 
Change-Id: Ic773ce031e02470099ae2b101d53b090ed08353a
Reviewed-on: https://chromium-review.googlesource.com/617397
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#495045}
[modify] https://crrev.com/035971ee2ec0418a6d856ce127ede310b874a183/tools/perf/convert_legacy_wpr_archive

Comment 5 by nedngu...@google.com, Aug 17 2017

Status: Fixed (was: Started)
►

Sign in to add a comment