New issue
Advanced search Search tips

Issue 756184 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 470662



Sign in to add a comment

Main-thread gesture fling curves don't work for OOPIFS.

Project Member Reported by wjmaclean@chromium.org, Aug 16 2017

Issue description

This is because the main-thread fling mechanisms all live in WebViewImpl, and not in WebFrameWidget.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5846e58a91e67f878b9cfb4732a062142ad8bd2

commit b5846e58a91e67f878b9cfb4732a062142ad8bd2
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Thu Aug 31 20:39:50 2017

Refactor main-thread fling code into WebFrameWidgetImpl.

This CL refactors the main-thread fling-scrolling code to live in
WebFrameWidgetImpl instead of WebViewImpl, so that it can be made to
also work with cross-process iframes.

Bug:  756184 
Change-Id: I7b5f552342d2db5ff99f71c69d93d7426f879325
Reviewed-on: https://chromium-review.googlesource.com/617741
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498986}
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/content/renderer/render_view_impl.cc
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/content/renderer/render_view_impl.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/content/renderer/render_widget.cc
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/content/renderer/render_widget.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/content/shell/test_runner/event_sender.cc
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/content/shell/test_runner/event_sender.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/frame/WebViewFrameWidget.cpp
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/frame/WebViewFrameWidget.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/Source/core/page/PageWidgetDelegate.cpp
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/public/web/WebFrameWidget.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/public/web/WebView.h
[modify] https://crrev.com/b5846e58a91e67f878b9cfb4732a062142ad8bd2/third_party/WebKit/public/web/WebWidget.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/351726fa468cb7d73ee5866f1fdaaa6aa4576543

commit 351726fa468cb7d73ee5866f1fdaaa6aa4576543
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Sep 01 21:03:43 2017

Add DidStopFlinging support for TouchSelection Editing in OOPIFs.

This CL adds handlers to notify RenderWidgetHostViewChildFrame and its
TouchSelectionControllerClientChildFrame when main-thread flings complete
in an oopif renderer.

This is necessary for correct operation of the touch selection editing
handles during touch scroll.

Bug:  756184 
Change-Id: Ibb4cff0e09119c5c95cd36d6f3ab6737a59be7b3
Reviewed-on: https://chromium-review.googlesource.com/647827
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499294}
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/browser/renderer_host/input/touch_selection_controller_client_aura.h
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.h
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/browser/renderer_host/input/touch_selection_controller_client_manager_android.cc
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/browser/renderer_host/input/touch_selection_controller_client_manager_android.h
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/351726fa468cb7d73ee5866f1fdaaa6aa4576543/content/public/browser/touch_selection_controller_client_manager.h

Status: Fixed (was: Started)
Labels: Merge-Request-62
Requesting merge for patch in Comment 3 (the patch in Comment 2 made it into M62).
Has this been verified and tested in Canary?
I've tested it on Linux tip-of-tree ... if I get a chance I'll grab a CrOS canary tomorrow and test there as well.
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 6 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 6 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3

commit c8c8f08e48d3f524cd18834d5257e3cb43cb71d3
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Wed Sep 06 12:44:05 2017

Add DidStopFlinging support for TouchSelection Editing in OOPIFs.

This CL adds handlers to notify RenderWidgetHostViewChildFrame and its
TouchSelectionControllerClientChildFrame when main-thread flings complete
in an oopif renderer.

This is necessary for correct operation of the touch selection editing
handles during touch scroll.

TBR=wjmaclean@chromium.org

(cherry picked from commit 351726fa468cb7d73ee5866f1fdaaa6aa4576543)

Bug:  756184 
Change-Id: Ibb4cff0e09119c5c95cd36d6f3ab6737a59be7b3
Reviewed-on: https://chromium-review.googlesource.com/647827
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499294}
Reviewed-on: https://chromium-review.googlesource.com/652588
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#43}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/browser/renderer_host/input/touch_selection_controller_client_aura.h
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.cc
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/browser/renderer_host/input/touch_selection_controller_client_child_frame.h
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/browser/renderer_host/input/touch_selection_controller_client_manager_android.cc
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/browser/renderer_host/input/touch_selection_controller_client_manager_android.h
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/c8c8f08e48d3f524cd18834d5257e3cb43cb71d3/content/public/browser/touch_selection_controller_client_manager.h

Sign in to add a comment