binutils: repo checkout and ebuild are not kept in sync |
||||
Issue descriptionthe CrOS manifest is pointing to the aosp master branch: https://android.googlesource.com/toolchain/binutils/+/master but that is *not* what our ebuild is building. it is instead manually pinned to git sha1's taken from the binutils-2_27-branch: CROS_WORKON_COMMIT="85fafaf039799ebc8053bf36ce1c6e6df7adbbec" https://android.googlesource.com/toolchain/binutils/+/binutils-2_27-branch so when you do `repo sync` and look at src/aosp/toolchain/binutils/, it looks nothing like what the ebuild is actually building. so if you switch to binutils-9999, everything falls apart. the manifest repos need to be kept in sync with the ebuilds. seems like we should unblacklist the binutils ebuild and point the manifest to the 2.27 branch so it's guaranteed to stay in sync.
,
Sep 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/44f47ec05df2786aecef18a625bc957563c11201 commit 44f47ec05df2786aecef18a625bc957563c11201 Author: Rahul Chaudhry <rahulchaudhry@chromium.org> Date: Tue Sep 12 05:47:09 2017
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/manifest/+/b9321867bad53fe900311cc7b83af5f039a8c8b6 commit b9321867bad53fe900311cc7b83af5f039a8c8b6 Author: Rahul Chaudhry <rahulchaudhry@chromium.org> Date: Tue Sep 12 05:47:10 2017 manifest: pin binutils version. BUG= chromium:756177 TEST='repo sync' checks out the pinned revision for binutils. CQ-DEPEND=CL:*452212 Change-Id: I3e38ffe78b0e79408f70b6565f9f6e2938423f86 Reviewed-on: https://chromium-review.googlesource.com/660809 Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org> Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/b9321867bad53fe900311cc7b83af5f039a8c8b6/full.xml
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ff5cb92b6a88b8c817f33bb0ec11fb0a56955e33 commit ff5cb92b6a88b8c817f33bb0ec11fb0a56955e33 Author: Rahul Chaudhry <rahulchaudhry@chromium.org> Date: Wed Sep 13 04:37:11 2017 sys-devel/binutils: un-blacklist the ebuild. The manifest now points to the 85fafaf commit, same as the binutils-2.27.ebuild. Going forward, the binutils sources will be updated using the manifest, instead of manually updating the commit hash in the ebuild. BUG= chromium:756177 TEST='cros_mark_as_stable -o ~/trunk/src/third_party/chromiumos-overlay -p sys-devel/binutils commit' worked and uprevved binutils to binutils-2.27.0-r2.ebuild. TEST='sudo emerge sys-devel/binutils' works and builds from the same commit hash as before (85fafaf). Change-Id: I0fd9d504f5157660eb78f4fb14b009c0cc589ae1 Reviewed-on: https://chromium-review.googlesource.com/663209 Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org> Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [rename] https://crrev.com/ff5cb92b6a88b8c817f33bb0ec11fb0a56955e33/sys-devel/binutils/binutils-2.27-r1.ebuild [modify] https://crrev.com/ff5cb92b6a88b8c817f33bb0ec11fb0a56955e33/sys-devel/binutils/binutils-9999.ebuild
,
Sep 15 2017
,
Jan 22 2018
,
Jan 23 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by llozano@chromium.org
, Aug 17 2017