New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756176 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----

Blocking:
issue 728443
issue 730711



Sign in to add a comment

Clean up build config to add full interface classpath

Project Member Reported by zpeng@chromium.org, Aug 16 2017

Issue description

We want to
1) Add extra classpath jar to full classpath
2) Omit form interface classpath by using deps[extra_classpath_jars]
3) Introduce full interface classpath
4) Clean up unused dependency_jars
 

Comment 1 by zpeng@chromium.org, Aug 16 2017

Blocking: 730711

Comment 2 by zpeng@chromium.org, Aug 16 2017

Blocking: 728443

Comment 3 by zpeng@chromium.org, Aug 18 2017

Cc: agrieve@chromium.org
Because proguard takes java_full_classpath as input_paths, maybe we should reconsider adding extra classpath jar to full classpath
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c96c282264cc9cd6cf16ed60895d8b148ef011f0

commit c96c282264cc9cd6cf16ed60895d8b148ef011f0
Author: Felix <zpeng@chromium.org>
Date: Mon Aug 21 17:20:54 2017

Fix javac:interface_classpath in build_config

This CL fixes javac:interface_classpath so that it does not create
non-existent entries for jar files in deps_info:extra_classpath_jars.

This change also enables Desugar to use javac:interface_classpath
instead of deps_info:java:full_classpath

Bug:  728443 ,  756176 
Change-Id: I579c09ef846f914cbcff3dcaf392e418983dc562
Reviewed-on: https://chromium-review.googlesource.com/621808
Commit-Queue: Felix <zpeng@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495970}
[modify] https://crrev.com/c96c282264cc9cd6cf16ed60895d8b148ef011f0/build/android/gyp/write_build_config.py
[modify] https://crrev.com/c96c282264cc9cd6cf16ed60895d8b148ef011f0/build/config/android/internal_rules.gni

Comment 5 by zpeng@chromium.org, Aug 25 2017

Status: Fixed (was: Assigned)

Sign in to add a comment