New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756171 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Searchbox moves if swiping up on fullscreen apps state

Project Member Reported by warx@chromium.org, Aug 16 2017

Issue description

Please see the attached video, should be a simple fix.

 
swiping_up_on_fullscreen_apps.webm
3.2 MB View Download
This should be fixed when minch@ lands her fix for the Peeking -> Fullscreen animation.

Comment 2 by minch@chromium.org, Aug 16 2017

newcomer@, haven't landed the the cl for peeking -> fullscreen animation yet. Working on that currently. 

Comment 3 by minch@chromium.org, Aug 17 2017

should because of my change. Will fix it in next cl.
Owner: minch@chromium.org

Comment 5 by minch@chromium.org, Aug 21 2017

Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b1e054f4aee91a8ddc7b4328be07974628f8775

commit 2b1e054f4aee91a8ddc7b4328be07974628f8775
Author: MinChen <minch@chromium.org>
Date: Tue Aug 22 00:14:01 2017

Cap searchbox top padding during drag.

Searchbox top padding during dragging should not be larger
than its final top padding.

Bug:  756171 
Change-Id: I75b69777dc0602f9fe6b5bd2bd42aa42b532e78f
Reviewed-on: https://chromium-review.googlesource.com/624938
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496136}
[modify] https://crrev.com/2b1e054f4aee91a8ddc7b4328be07974628f8775/ui/app_list/views/apps_container_view.cc

Comment 7 by minch@chromium.org, Aug 22 2017

Status: Fixed (was: Started)

Comment 8 by minch@chromium.org, Aug 22 2017

Labels: Merge-Request-61
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 22 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-61 Merge-Approved-61
Approving merge to M61 Chrome OS.
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 23 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/debd952b4718f776c9ad2451e1a2d38776c601c5

commit debd952b4718f776c9ad2451e1a2d38776c601c5
Author: Vadim Tryshev <vadimt@google.com>
Date: Wed Aug 23 23:40:42 2017

Cap searchbox top padding during drag.

Searchbox top padding during dragging should not be larger
than its final top padding.

TBR=minch@chromium.org

(cherry picked from commit 2b1e054f4aee91a8ddc7b4328be07974628f8775)

Bug:  756171 
Change-Id: I75b69777dc0602f9fe6b5bd2bd42aa42b532e78f
Reviewed-on: https://chromium-review.googlesource.com/624938
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496136}
Reviewed-on: https://chromium-review.googlesource.com/630177
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#842}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/debd952b4718f776c9ad2451e1a2d38776c601c5/ui/app_list/views/apps_container_view.cc

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment