mash: Shelf "Launcher" button tooltip shown on login |
||||||
Issue descriptionmash: Shelf "Launcher" button tooltip shown on login (1) On ToT run "chrome --mash --login-manager" (2) Login, set a left-side shelf alignment, and shutdown. (3) Run chrome again and login, be careful not to hover the mouse over the window at all. Expected: The shelf "Launcher" button tooltip is not shown on login Actual: The shelf "Launcher" button tooltip *is* shown on login This is likely an issue around cursor position init... Perhaps ShelfTooltipManager should work around this issue...
,
Sep 20 2017
There are *many* mash and cash callstacks that lead to posting SynthesizeMouseMoveEvent tasks on login when GetLastMouseLocationInRoot().IsOrigin() is true. Luckily, I noticed that two are from ash::ShelfLayoutManager::SetChildBounds, and those aren't called in cash... #0 0x7fa0177bceec base::debug::StackTrace::StackTrace() #1 0x7fa013581a6b aura::WindowEventDispatcher::PostSynthesizeMouseMove() #2 0x7fa013584856 aura::WindowEventDispatcher::OnWindowBoundsChanged() #3 0x7fa01358081a aura::Window::OnLayerBoundsChanged() #4 0x7fa0134ef2f0 ui::Layer::SetBoundsFromAnimation() #5 0x7fa01357db15 aura::Window::SetBoundsInternal() #6 0x7fa01234eaee ash::wm::WmSnapToPixelLayoutManager::SetChildBounds() #7 0x7fa01226def2 ash::ShelfLayoutManager::SetChildBounds() #8 0x7fa01234b6bf ash::wm::SetBoundsInScreen() #9 0x7fa01293329f views::NativeWidgetAura::SetBounds() #10 0x7fa01226c544 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #11 0x7fa01226c23c ash::ShelfLayoutManager::LayoutShelfAndUpdateBounds() #12 0x7fa0122d7252 ash::StatusAreaLayoutManager::SetChildBounds() #13 0x7fa01293335b views::NativeWidgetAura::SetSize() #14 0x7fa0122d8b8d ash::StatusAreaWidgetDelegate::ChildPreferredSizeChanged() #15 0x7fa0122eb612 ash::TrayContainer::UpdateLayout() #16 0x7fa0122ea5de ash::TrayBackgroundView::UpdateAfterShelfAlignmentChange() #17 0x7fa0122e3572 ash::SystemTray::UpdateAfterShelfAlignmentChange() #18 0x7fa0122d7b2e ash::StatusAreaWidget::UpdateAfterShelfAlignmentChange() #19 0x7fa0122796dd ash::ShelfWidget::OnShelfAlignmentChanged() #20 0x7fa01225fb42 ash::Shelf::SetAlignment() #21 0x7fa01226a52c ash::(anonymous namespace)::SetShelfAlignmentFromPrefs() #22 0x7fa01226a181 ash::ShelfController::OnActiveUserPrefServiceChanged() #23 0x7fa012256d34 ash::SessionController::OnProfilePrefServiceInitialized() #24 0x7fa0122583c9 _ZN4base8internal7InvokerINS0_9BindStateIMN3ash17SessionControllerEFvRK9AccountIdNSt3__110unique_ptrI11PrefServiceNS8_14default_deleteISA_EEEEEJNS_7WeakPtrIS4_EES5_EEEFvSD_EE7RunImplIRKSF_RKNS8_5tupleIJSH_S5_EEEJLm0ELm1EEEEvOT_OT0_NS8_16integer_sequenceImJXspT1_EEEEOSD_ #25 0x7fa012362fb0 prefs::(anonymous namespace)::OnConnect() #26 0x7fa012363cb7 _ZN4base8internal7InvokerINS0_9BindStateIPFv13scoped_refptrIN5prefs12_GLOBAL__N_122RefCountedInterfacePtrINS4_5mojom18PrefStoreConnectorEEEES3_I12PrefRegistryENS_17RepeatingCallbackIFvNSt3__110unique_ptrI11PrefServiceNSE_14default_deleteISG_EEEEEEEN4mojo9StructPtrINS7_29PersistentPrefStoreConnectionEEENSN_INS7_38IncognitoPersistentPrefStoreConnectionEEENSE_6vectorINSN_INS7_16PrefRegistrationEEENSE_9allocatorISU_EEEENSE_13unordered_mapIN14PrefValueStore13PrefStoreTypeENSN_INS7_19PrefStoreConnectionEEENSE_4hashIS10_EENSE_8equal_toIS10_EENSV_INSE_4pairIKS10_S12_EEEEEEEJSA_SC_SL_EEEFvSP_SR_SX_S1B_EE7RunOnceEPNS0_13BindStateBaseEOSP_OSR_OSX_OS1B_ #27 0x7fa012368dc4 prefs::mojom::PrefStoreConnector_Connect_ForwardToCallback::Accept() #28 0x7fa0169ec048 mojo::InterfaceEndpointClient::HandleValidatedMessage() #29 0x7fa0169eb846 mojo::FilterChain::Accept() #30 0x7fa0169ed235 mojo::InterfaceEndpointClient::HandleIncomingMessage() #31 0x7fa0169f73b4 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #32 0x7fa0169f6904 mojo::internal::MultiplexRouter::Accept() #33 0x7fa0169eb846 mojo::FilterChain::Accept() #34 0x7fa0169e6a45 mojo::Connector::ReadSingleMessage() #35 0x7fa0169e7531 mojo::Connector::ReadAllAvailableMessages() #36 0x7fa0169e73d9 mojo::Connector::OnHandleReadyInternal() #37 0x7fa0169e7b85 mojo::SimpleWatcher::DiscardReadyState() #38 0x7fa0169b0e74 mojo::SimpleWatcher::OnHandleReady() #39 0x7fa0169b13b1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #40 0x7fa0177bd77f base::debug::TaskAnnotator::RunTask() #41 0x7fa0177ed0f9 base::internal::IncomingTaskQueue::RunTask() #42 0x7fa0177ef3a3 base::MessageLoop::RunTask() #43 0x7fa0177eface base::MessageLoop::DoWork() #44 0x7fa0177f2369 base::MessagePumpLibevent::Run() #45 0x7fa0177eeeb2 base::MessageLoop::Run() #46 0x7fa01782317f base::RunLoop::Run() #47 0x7fa017d07a5f _ZN4base8internal7InvokerINS0_9BindStateIZN15service_manager12_GLOBAL__N_110RunServiceEPNS3_12MainDelegateEE3$_0JS6_PiEEEFvN4mojo16InterfaceRequestINS3_5mojom7ServiceEEEEE3RunEPNS0_13BindStateBaseEOSE_ #48 0x7fa017d09836 service_manager::RunStandaloneService() #49 0x7fa017d07417 service_manager::Main() #50 0x7fa0154d4024 content::ContentMain() #51 0x555a5f3661c8 ChromeMain #52 0x7fa00b87ff45 __libc_start_main #53 0x555a5f366004 <unknown> #0 0x7fa0177bceec base::debug::StackTrace::StackTrace() #1 0x7fa013581a6b aura::WindowEventDispatcher::PostSynthesizeMouseMove() #2 0x7fa013584856 aura::WindowEventDispatcher::OnWindowBoundsChanged() #3 0x7fa01358081a aura::Window::OnLayerBoundsChanged() #4 0x7fa0134ef2f0 ui::Layer::SetBoundsFromAnimation() #5 0x7fa01357db15 aura::Window::SetBoundsInternal() #6 0x7fa01234dad8 ash::wm::WindowState::SetBoundsDirect() #7 0x7fa0123159e7 ash::wm::DefaultState::SetMaximizedOrFullscreenBounds() #8 0x7fa012314cb4 ash::wm::DefaultState::ProcessWorkspaceEvents() #9 0x7fa012314898 ash::wm::DefaultState::OnWMEvent() #10 0x7fa012356184 ash::WorkspaceLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange() #11 0x7fa0123564a6 ash::WorkspaceLayoutManager::OnDisplayMetricsChanged() #12 0x7fa012611c67 display::DisplayManager::NotifyMetricsChanged() #13 0x7fa012611f89 display::DisplayManager::UpdateWorkAreaOfDisplay() #14 0x7fa012212713 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() #15 0x7fa01226c614 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #16 0x7fa01226c23c ash::ShelfLayoutManager::LayoutShelfAndUpdateBounds() #17 0x7fa0122d7252 ash::StatusAreaLayoutManager::SetChildBounds() #18 0x7fa01293335b views::NativeWidgetAura::SetSize() #19 0x7fa0122d8b8d ash::StatusAreaWidgetDelegate::ChildPreferredSizeChanged() #20 0x7fa0122eb612 ash::TrayContainer::UpdateLayout() #21 0x7fa0122ea5de ash::TrayBackgroundView::UpdateAfterShelfAlignmentChange() #22 0x7fa0122e3572 ash::SystemTray::UpdateAfterShelfAlignmentChange() #23 0x7fa0122d7b2e ash::StatusAreaWidget::UpdateAfterShelfAlignmentChange() #24 0x7fa0122796dd ash::ShelfWidget::OnShelfAlignmentChanged() #25 0x7fa01225fb42 ash::Shelf::SetAlignment() #26 0x7fa01226a52c ash::(anonymous namespace)::SetShelfAlignmentFromPrefs() #27 0x7fa01226a181 ash::ShelfController::OnActiveUserPrefServiceChanged() #28 0x7fa012256d34 ash::SessionController::OnProfilePrefServiceInitialized() #29 0x7fa0122583c9 _ZN4base8internal7InvokerINS0_9BindStateIMN3ash17SessionControllerEFvRK9AccountIdNSt3__110unique_ptrI11PrefServiceNS8_14default_deleteISA_EEEEEJNS_7WeakPtrIS4_EES5_EEEFvSD_EE7RunImplIRKSF_RKNS8_5tupleIJSH_S5_EEEJLm0ELm1EEEEvOT_OT0_NS8_16integer_sequenceImJXspT1_EEEEOSD_ #30 0x7fa012362fb0 prefs::(anonymous namespace)::OnConnect() #31 0x7fa012363cb7 _ZN4base8internal7InvokerINS0_9BindStateIPFv13scoped_refptrIN5prefs12_GLOBAL__N_122RefCountedInterfacePtrINS4_5mojom18PrefStoreConnectorEEEES3_I12PrefRegistryENS_17RepeatingCallbackIFvNSt3__110unique_ptrI11PrefServiceNSE_14default_deleteISG_EEEEEEEN4mojo9StructPtrINS7_29PersistentPrefStoreConnectionEEENSN_INS7_38IncognitoPersistentPrefStoreConnectionEEENSE_6vectorINSN_INS7_16PrefRegistrationEEENSE_9allocatorISU_EEEENSE_13unordered_mapIN14PrefValueStore13PrefStoreTypeENSN_INS7_19PrefStoreConnectionEEENSE_4hashIS10_EENSE_8equal_toIS10_EENSV_INSE_4pairIKS10_S12_EEEEEEEJSA_SC_SL_EEEFvSP_SR_SX_S1B_EE7RunOnceEPNS0_13BindStateBaseEOSP_OSR_OSX_OS1B_ #32 0x7fa012368dc4 prefs::mojom::PrefStoreConnector_Connect_ForwardToCallback::Accept() #33 0x7fa0169ec048 mojo::InterfaceEndpointClient::HandleValidatedMessage() #34 0x7fa0169eb846 mojo::FilterChain::Accept() #35 0x7fa0169ed235 mojo::InterfaceEndpointClient::HandleIncomingMessage() #36 0x7fa0169f73b4 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #37 0x7fa0169f6904 mojo::internal::MultiplexRouter::Accept() #38 0x7fa0169eb846 mojo::FilterChain::Accept() #39 0x7fa0169e6a45 mojo::Connector::ReadSingleMessage() #40 0x7fa0169e7531 mojo::Connector::ReadAllAvailableMessages() #41 0x7fa0169e73d9 mojo::Connector::OnHandleReadyInternal() #42 0x7fa0169e7b85 mojo::SimpleWatcher::DiscardReadyState() #43 0x7fa0169b0e74 mojo::SimpleWatcher::OnHandleReady() #44 0x7fa0169b13b1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #45 0x7fa0177bd77f base::debug::TaskAnnotator::RunTask() #46 0x7fa0177ed0f9 base::internal::IncomingTaskQueue::RunTask() #47 0x7fa0177ef3a3 base::MessageLoop::RunTask() #48 0x7fa0177eface base::MessageLoop::DoWork() #49 0x7fa0177f2369 base::MessagePumpLibevent::Run() #50 0x7fa0177eeeb2 base::MessageLoop::Run() #51 0x7fa01782317f base::RunLoop::Run() #52 0x7fa017d07a5f _ZN4base8internal7InvokerINS0_9BindStateIZN15service_manager12_GLOBAL__N_110RunServiceEPNS3_12MainDelegateEE3$_0JS6_PiEEEFvN4mojo16InterfaceRequestINS3_5mojom7ServiceEEEEE3RunEPNS0_13BindStateBaseEOSE_ #53 0x7fa017d09836 service_manager::RunStandaloneService() #54 0x7fa017d07417 service_manager::Main() #55 0x7fa0154d4024 content::ContentMain() #56 0x555a5f3661c8 ChromeMain #57 0x7fa00b87ff45 __libc_start_main #58 0x555a5f366004 <unknown>
,
Sep 20 2017
Hmm, I was wrong... those same callstacks are in my classic ash logs... And WindowEventDispatcher::GetLastMouseLocationInRoot does return 0,0... Now I'm stumped why this doesn't trigger ShelfTooltipManager in cash. #0 0x7fa1a069feec base::debug::StackTrace::StackTrace() #1 0x7fa19c464a04 aura::WindowEventDispatcher::PostSynthesizeMouseMove() #2 0x7fa19c467826 aura::WindowEventDispatcher::OnWindowBoundsChanged() #3 0x7fa19c4637fa aura::Window::OnLayerBoundsChanged() #4 0x7fa19c3d22f0 ui::Layer::SetBoundsFromAnimation() #5 0x7fa19c460af5 aura::Window::SetBoundsInternal() #6 0x7fa19b231aee ash::wm::WmSnapToPixelLayoutManager::SetChildBounds() #7 0x7fa19b150ef2 ash::ShelfLayoutManager::SetChildBounds() #8 0x7fa19b22e6bf ash::wm::SetBoundsInScreen() #9 0x7fa19b81629f views::NativeWidgetAura::SetBounds() #10 0x7fa19b14f544 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #11 0x7fa19b14f23c ash::ShelfLayoutManager::LayoutShelfAndUpdateBounds() #12 0x7fa19b1ba252 ash::StatusAreaLayoutManager::SetChildBounds() #13 0x7fa19b81635b views::NativeWidgetAura::SetSize() #14 0x7fa19b1bbb8d ash::StatusAreaWidgetDelegate::ChildPreferredSizeChanged() #15 0x7fa19b1ce612 ash::TrayContainer::UpdateLayout() #16 0x7fa19b1cd5de ash::TrayBackgroundView::UpdateAfterShelfAlignmentChange() #17 0x7fa19b1c6572 ash::SystemTray::UpdateAfterShelfAlignmentChange() #18 0x7fa19b1bab2e ash::StatusAreaWidget::UpdateAfterShelfAlignmentChange() #19 0x7fa19b15c6dd ash::ShelfWidget::OnShelfAlignmentChanged() #20 0x7fa19b142b42 ash::Shelf::SetAlignment() #21 0x7fa19b14d52c ash::(anonymous namespace)::SetShelfAlignmentFromPrefs() #22 0x7fa19b14d181 ash::ShelfController::OnActiveUserPrefServiceChanged() #23 0x7fa19b139d34 ash::SessionController::OnProfilePrefServiceInitialized() #24 0x7fa19b13b3c9 _ZN4base8internal7InvokerINS0_9BindStateIMN3ash17SessionControllerEFvRK9AccountIdNSt3__110unique_ptrI11PrefServiceNS8_14default_deleteISA_EEEEEJNS_7WeakPtrIS4_EES5_EEEFvSD_EE7RunImplIRKSF_RKNS8_5tupleIJSH_S5_EEEJLm0ELm1EEEEvOT_OT0_NS8_16integer_sequenceImJXspT1_EEEEOSD_ #25 0x7fa19b245fb0 prefs::(anonymous namespace)::OnConnect() #26 0x7fa19b246cb7 _ZN4base8internal7InvokerINS0_9BindStateIPFv13scoped_refptrIN5prefs12_GLOBAL__N_122RefCountedInterfacePtrINS4_5mojom18PrefStoreConnectorEEEES3_I12PrefRegistryENS_17RepeatingCallbackIFvNSt3__110unique_ptrI11PrefServiceNSE_14default_deleteISG_EEEEEEEN4mojo9StructPtrINS7_29PersistentPrefStoreConnectionEEENSN_INS7_38IncognitoPersistentPrefStoreConnectionEEENSE_6vectorINSN_INS7_16PrefRegistrationEEENSE_9allocatorISU_EEEENSE_13unordered_mapIN14PrefValueStore13PrefStoreTypeENSN_INS7_19PrefStoreConnectionEEENSE_4hashIS10_EENSE_8equal_toIS10_EENSV_INSE_4pairIKS10_S12_EEEEEEEJSA_SC_SL_EEEFvSP_SR_SX_S1B_EE7RunOnceEPNS0_13BindStateBaseEOSP_OSR_OSX_OS1B_ #27 0x7fa19b24bdc4 prefs::mojom::PrefStoreConnector_Connect_ForwardToCallback::Accept() #28 0x7fa19f8cf048 mojo::InterfaceEndpointClient::HandleValidatedMessage() #29 0x7fa19f8ce846 mojo::FilterChain::Accept() #30 0x7fa19f8d0235 mojo::InterfaceEndpointClient::HandleIncomingMessage() #31 0x7fa19f8da3b4 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #32 0x7fa19f8d9904 mojo::internal::MultiplexRouter::Accept() #33 0x7fa19f8ce846 mojo::FilterChain::Accept() #34 0x7fa19f8c9a45 mojo::Connector::ReadSingleMessage() #35 0x7fa19f8ca531 mojo::Connector::ReadAllAvailableMessages() #36 0x7fa19f8ca3d9 mojo::Connector::OnHandleReadyInternal() #37 0x7fa19f8cab85 mojo::SimpleWatcher::DiscardReadyState() #38 0x7fa19f893e74 mojo::SimpleWatcher::OnHandleReady() #39 0x7fa19f8943b1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #40 0x7fa1a06a077f base::debug::TaskAnnotator::RunTask() #41 0x7fa1a06d00f9 base::internal::IncomingTaskQueue::RunTask() #42 0x7fa1a06d23a3 base::MessageLoop::RunTask() #43 0x7fa1a06d2ace base::MessageLoop::DoWork() #44 0x7fa1a06d5369 base::MessagePumpLibevent::Run() #45 0x7fa1a06d1eb2 base::MessageLoop::Run() #46 0x7fa1a070617f base::RunLoop::Run() #47 0x559f108e07da ChromeBrowserMainParts::MainMessageLoopRun() #48 0x7fa19db44567 content::BrowserMainLoop::RunMainMessageLoopParts() #49 0x7fa19db46f46 content::BrowserMainRunnerImpl::Run() #50 0x7fa19db3fdbf content::BrowserMain() #51 0x7fa19e3b864c content::ContentMainRunnerImpl::Run() #52 0x7fa1a0bea09e service_manager::Main() #53 0x7fa19e3b7024 content::ContentMain() #54 0x559f0fec11c8 ChromeMain #55 0x7fa194762f45 __libc_start_main #56 0x559f0fec1004 <unknown> #0 0x7fa1a069feec base::debug::StackTrace::StackTrace() #1 0x7fa19c464a04 aura::WindowEventDispatcher::PostSynthesizeMouseMove() #2 0x7fa19c467826 aura::WindowEventDispatcher::OnWindowBoundsChanged() #3 0x7fa19c4637fa aura::Window::OnLayerBoundsChanged() #4 0x7fa19c3d22f0 ui::Layer::SetBoundsFromAnimation() #5 0x7fa19c460af5 aura::Window::SetBoundsInternal() #6 0x7fa19b230ad8 ash::wm::WindowState::SetBoundsDirect() #7 0x7fa19b1f89e7 ash::wm::DefaultState::SetMaximizedOrFullscreenBounds() #8 0x7fa19b1f7cb4 ash::wm::DefaultState::ProcessWorkspaceEvents() #9 0x7fa19b1f7898 ash::wm::DefaultState::OnWMEvent() #10 0x7fa19b239184 ash::WorkspaceLayoutManager::AdjustAllWindowsBoundsForWorkAreaChange() #11 0x7fa19b2394a6 ash::WorkspaceLayoutManager::OnDisplayMetricsChanged() #12 0x7fa19b4f4c67 display::DisplayManager::NotifyMetricsChanged() #13 0x7fa19b4f4f89 display::DisplayManager::UpdateWorkAreaOfDisplay() #14 0x7fa19b0f5713 ash::WindowTreeHostManager::UpdateWorkAreaOfDisplayNearestWindow() #15 0x7fa19b14f614 ash::ShelfLayoutManager::UpdateBoundsAndOpacity() #16 0x7fa19b14f23c ash::ShelfLayoutManager::LayoutShelfAndUpdateBounds() #17 0x7fa19b1ba252 ash::StatusAreaLayoutManager::SetChildBounds() #18 0x7fa19b81635b views::NativeWidgetAura::SetSize() #19 0x7fa19b1bbb8d ash::StatusAreaWidgetDelegate::ChildPreferredSizeChanged() #20 0x7fa19b1ce612 ash::TrayContainer::UpdateLayout() #21 0x7fa19b1cd5de ash::TrayBackgroundView::UpdateAfterShelfAlignmentChange() #22 0x7fa19b1c6572 ash::SystemTray::UpdateAfterShelfAlignmentChange() #23 0x7fa19b1bab2e ash::StatusAreaWidget::UpdateAfterShelfAlignmentChange() #24 0x7fa19b15c6dd ash::ShelfWidget::OnShelfAlignmentChanged() #25 0x7fa19b142b42 ash::Shelf::SetAlignment() #26 0x7fa19b14d52c ash::(anonymous namespace)::SetShelfAlignmentFromPrefs() #27 0x7fa19b14d181 ash::ShelfController::OnActiveUserPrefServiceChanged() #28 0x7fa19b139d34 ash::SessionController::OnProfilePrefServiceInitialized() #29 0x7fa19b13b3c9 _ZN4base8internal7InvokerINS0_9BindStateIMN3ash17SessionControllerEFvRK9AccountIdNSt3__110unique_ptrI11PrefServiceNS8_14default_deleteISA_EEEEEJNS_7WeakPtrIS4_EES5_EEEFvSD_EE7RunImplIRKSF_RKNS8_5tupleIJSH_S5_EEEJLm0ELm1EEEEvOT_OT0_NS8_16integer_sequenceImJXspT1_EEEEOSD_ #30 0x7fa19b245fb0 prefs::(anonymous namespace)::OnConnect() #31 0x7fa19b246cb7 _ZN4base8internal7InvokerINS0_9BindStateIPFv13scoped_refptrIN5prefs12_GLOBAL__N_122RefCountedInterfacePtrINS4_5mojom18PrefStoreConnectorEEEES3_I12PrefRegistryENS_17RepeatingCallbackIFvNSt3__110unique_ptrI11PrefServiceNSE_14default_deleteISG_EEEEEEEN4mojo9StructPtrINS7_29PersistentPrefStoreConnectionEEENSN_INS7_38IncognitoPersistentPrefStoreConnectionEEENSE_6vectorINSN_INS7_16PrefRegistrationEEENSE_9allocatorISU_EEEENSE_13unordered_mapIN14PrefValueStore13PrefStoreTypeENSN_INS7_19PrefStoreConnectionEEENSE_4hashIS10_EENSE_8equal_toIS10_EENSV_INSE_4pairIKS10_S12_EEEEEEEJSA_SC_SL_EEEFvSP_SR_SX_S1B_EE7RunOnceEPNS0_13BindStateBaseEOSP_OSR_OSX_OS1B_ #32 0x7fa19b24bdc4 prefs::mojom::PrefStoreConnector_Connect_ForwardToCallback::Accept() #33 0x7fa19f8cf048 mojo::InterfaceEndpointClient::HandleValidatedMessage() #34 0x7fa19f8ce846 mojo::FilterChain::Accept() #35 0x7fa19f8d0235 mojo::InterfaceEndpointClient::HandleIncomingMessage() #36 0x7fa19f8da3b4 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #37 0x7fa19f8d9904 mojo::internal::MultiplexRouter::Accept() #38 0x7fa19f8ce846 mojo::FilterChain::Accept() #39 0x7fa19f8c9a45 mojo::Connector::ReadSingleMessage() #40 0x7fa19f8ca531 mojo::Connector::ReadAllAvailableMessages() #41 0x7fa19f8ca3d9 mojo::Connector::OnHandleReadyInternal() #42 0x7fa19f8cab85 mojo::SimpleWatcher::DiscardReadyState() #43 0x7fa19f893e74 mojo::SimpleWatcher::OnHandleReady() #44 0x7fa19f8943b1 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #45 0x7fa1a06a077f base::debug::TaskAnnotator::RunTask() #46 0x7fa1a06d00f9 base::internal::IncomingTaskQueue::RunTask() #47 0x7fa1a06d23a3 base::MessageLoop::RunTask() #48 0x7fa1a06d2ace base::MessageLoop::DoWork() #49 0x7fa1a06d5369 base::MessagePumpLibevent::Run() #50 0x7fa1a06d1eb2 base::MessageLoop::Run() #51 0x7fa1a070617f base::RunLoop::Run() #52 0x559f108e07da ChromeBrowserMainParts::MainMessageLoopRun() #53 0x7fa19db44567 content::BrowserMainLoop::RunMainMessageLoopParts() #54 0x7fa19db46f46 content::BrowserMainRunnerImpl::Run() #55 0x7fa19db3fdbf content::BrowserMain() #56 0x7fa19e3b864c content::ContentMainRunnerImpl::Run() #57 0x7fa1a0bea09e service_manager::Main() #58 0x7fa19e3b7024 content::ContentMain() #59 0x559f0fec11c8 ChromeMain #60 0x7fa194762f45 __libc_start_main #61 0x559f0fec1004 <unknown>
,
Sep 21 2017
+erg just FYI, I wonder if there is some difference in initial cursor position on mash. Anyhow, this is a P3, and it sounds like you've spent enough time on it. :-)
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52d2d3df843b3960ba1c0e96f4228c1fefd1ee20 commit 52d2d3df843b3960ba1c0e96f4228c1fefd1ee20 Author: Mike Wasserman <msw@chromium.org> Date: Thu Sep 21 02:39:36 2017 mash: Workaround shelf tooltip on startup. Skip showing tooltips for mouse moves at the origin. (skipping the first move works for --mash, but not --mus) Add a comment that the workaround ought to be temporary. Bug: 756163 Change-Id: Idce979684ac75e0ab91e2e6720b78020db0bddec Reviewed-on: https://chromium-review.googlesource.com/673550 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#503333} [modify] https://crrev.com/52d2d3df843b3960ba1c0e96f4228c1fefd1ee20/ash/shelf/shelf_tooltip_manager.cc
,
Sep 21 2017
My workaround seems sufficient for now; I filed a related Issue 767497.
,
Jan 22 2018
,
Jan 23 2018
,
Feb 26 2018
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2920dfe1c88deaf619a76c3189da7b331ca5957 commit f2920dfe1c88deaf619a76c3189da7b331ca5957 Author: James Cook <jamescook@chromium.org> Date: Tue Sep 04 19:55:01 2018 chromeos: Eliminate ash::Config::MASH_DEPRECATED We haven't run ash in this mode for months, since the switch to ws2 / window-service-as-a-library. * CursorManager exists in ws2, so always use it * Docked magnifier works in SingleProcessMash, and will need to be fixed separately for multi-process * Eliminate unused DragWindowResizerMash. Window dragging across displays works for both single-process and multi-process mash * Always use EventTargetingPolicy::TARGET_AND_DESCENDENTS in exo. Manually verified that clicks go to the right place in both single-process and multi-process mash. * Remove many unused includes I had to disable one ash_unittest for NonClientFrameController. TBR=lhchavez@chromium.org Bug: 631103 , 637853 , 646565 , 705592 , 756163 , 839521 Test: ash_unittests Change-Id: Iab64339029a33921274089ca4cb57a8f037f6f88 Reviewed-on: https://chromium-review.googlesource.com/1200483 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#588626} [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/BUILD.gn [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accelerators/accelerator_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/accessibility/accessibility_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/dbus/ash_dbus_services.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/display_prefs.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/mirror_window_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/mirror_window_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/frame/header_view.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/highlighter/highlighter_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/ime/ime_focus_handler_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/keyboard/virtual_keyboard_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/keyboard/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/laser/laser_pointer_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/login_password_view_test.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/login/ui/login_test_base.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/metrics/login_metrics_recorder_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/public/cpp/BUILD.gn [delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/public/cpp/config.h [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/root_window_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/app_list_button_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_context_menu_model_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_tooltip_manager_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell.h [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/shell_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/sticky_keys/sticky_keys_overlay_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/flag_warning/flag_warning_tray.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/message_center/notification_tray_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/network/tray_network_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/network/wifi_toggle_notification_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/night_light/night_light_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/night_light/tray_night_light_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/palette_tray.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/palette_tray_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/palette/tools/screenshot_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/power/peripheral_battery_notifier_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/power/power_button_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/session/logout_button_tray_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/status_area_widget.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/tray/system_tray.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/tray_caps_lock.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/system/unified/unified_system_tray_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/test/ash_test_base.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/test/ash_test_base.h [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/tooltips/tooltip_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/touch/touch_observer_hud_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wallpaper/wallpaper_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wayland/wayland_server_controller.cc [delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/wm/drag_window_resizer_mash.cc [delete] https://crrev.com/62ebf0a512c16992819b555014cdd9ce6ade383e/ash/wm/drag_window_resizer_mash.h [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/non_client_frame_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/system_modal_container_layout_manager.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/window_util.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/chrome/browser/ui/ash/ash_util.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/arc/rotation_lock/arc_rotation_lock_bridge.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/exo/shell_surface_base.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/components/exo/wayland/clients/test/wayland_client_test.cc [modify] https://crrev.com/f2920dfe1c88deaf619a76c3189da7b331ca5957/testing/buildbot/filters/chromeos.single_process_mash.fyi.ash_unittests.filter |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msw@chromium.org
, Sep 20 2017