New issue
Advanced search Search tips

Issue 756134 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Playstore notification is immediately dismissed by First-run UI.

Project Member Reported by sdantul...@chromium.org, Aug 16 2017

Issue description

Google Chrome	61.0.3163.51 (Official Build) dev (64-bit)
Revision	0
Platform	9765.30.0 (Official Build) dev-channel caroline

What steps will reproduce the problem?
1. From the login screen, click on Add person button
2. Click on the link to Create new account.
3. Fill in details on each screen and click 'Next'. Account creation succeeds and will be signed in successfully.
4. Check for First Run UI 

What is the expected behavior ?
Playstore notification should be displayed after user goes through First-run UI.

What happens instead?
Playstore notification pops-up for a moment and is immediately dismissed by First-run UI.
 

Comment 2 by uekawa@chromium.org, Aug 18 2017

Cc: khmel@chromium.org
+yury, is this your jurisdiction?

Comment 3 by khmel@chromium.org, Aug 18 2017

Status: Started (was: Untriaged)
Yes, I can handle this. 

Comment 4 by khmel@chromium.org, Aug 18 2017

Owner: khmel@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f9baef79cb20e059612ec63f315a56b85e7d96b

commit 4f9baef79cb20e059612ec63f315a56b85e7d96b
Author: khmel <khmel@google.com>
Date: Mon Aug 21 17:07:02 2017

arc: Make sure ARC auth notification is shown reliable.

Shelf uses session observer to determine when it switches to Active
state. On this event shelf hides existing pop up notification. As a 
result ARC notification may appear on short period of time only. To
prevent this race, this CL shows ARC notification on this event too
as post-processing.

      login screen.

Test: Manually, simulate the case when profile is synced during the
Bug:  756134 
Change-Id: I54c498e8b402a895eb83aea663316d33554abf94
Reviewed-on: https://chromium-review.googlesource.com/621964
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#495967}
[modify] https://crrev.com/4f9baef79cb20e059612ec63f315a56b85e7d96b/chrome/browser/chromeos/arc/arc_auth_notification.cc
[modify] https://crrev.com/4f9baef79cb20e059612ec63f315a56b85e7d96b/chrome/browser/chromeos/arc/arc_auth_notification.h
[modify] https://crrev.com/4f9baef79cb20e059612ec63f315a56b85e7d96b/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler.cc
[modify] https://crrev.com/4f9baef79cb20e059612ec63f315a56b85e7d96b/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 2017

Labels: merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc51f491901fddbefe1640f751c8a886547c99a1

commit dc51f491901fddbefe1640f751c8a886547c99a1
Author: khmel <khmel@google.com>
Date: Wed Aug 23 00:33:26 2017

[Merge M61] arc: Make sure ARC auth notification is shown reliable.

Shelf uses session observer to determine when it switches to Active
state. On this event shelf hides existing pop up notification. As a
result ARC notification may appear on short period of time only. To
prevent this race, this CL shows ARC notification on this event too
as post-processing.

Test: Manually, simulate the case when profile is synced during the
      login screen.
Bug:  756134 

TBR=khmel@google.com, xiyuan@chromium.org

(cherry picked from commit 4f9baef79cb20e059612ec63f315a56b85e7d96b)

Change-Id: I54c498e8b402a895eb83aea663316d33554abf94
Reviewed-on: https://chromium-review.googlesource.com/621964
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#495967}
Reviewed-on: https://chromium-review.googlesource.com/627587
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#794}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/dc51f491901fddbefe1640f751c8a886547c99a1/chrome/browser/chromeos/arc/arc_auth_notification.cc
[modify] https://crrev.com/dc51f491901fddbefe1640f751c8a886547c99a1/chrome/browser/chromeos/arc/arc_auth_notification.h
[modify] https://crrev.com/dc51f491901fddbefe1640f751c8a886547c99a1/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler.cc
[modify] https://crrev.com/dc51f491901fddbefe1640f751c8a886547c99a1/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler.h

Comment 7 by khmel@chromium.org, Aug 23 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment