Converting wpr->wprgo produces failure in key_mobile_sites' digg.com page |
||||
Issue description
I'm trying to convert the key_mobile_sites_smooth set to wprgo following the instructions in:
https://docs.google.com/document/d/1FoUwF5aFva5E0j7nyBDkFO8L1ihH114XpQusGsAmrjE/edit#
convert_legacy_wpr_archive writes all the necessary wprgo files and modifies the json file correctly. When I run a benchmark, e.g.
./tools/perf/run_benchmark --browser=android-system-chrome --story-filter=digg smoothness.sync_scroll.key_mobile_sites_smooth
The http://digg.com case fails - the device browser remains at about:blank.
I've attached the log from both the convert_legacy_wpr_archive and from running the above run_benchmark command.
,
Aug 16 2017
,
Aug 16 2017
The log in #1 is red herring, it's basically about Telemetry trying to symbolize the Android crash stack. The real bug here is we fail to load digg.com. Python stack: File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 174, in Navigate timeout_in_seconds=timeout_in_seconds)) File "/home/bokan/chrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 56, in _RunAction action.RunAction(self._tab) File "/home/bokan/chrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/actions/navigate.py", line 23, in RunAction self._timeout_in_seconds) File "/home/bokan/chrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 233, in Navigate self._inspector_backend.Navigate(url, script_to_evaluate_on_commit, timeout) File "/home/bokan/chrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 39, in inner inspector_backend._ConvertExceptionFromInspectorWebsocket(e) File "/home/bokan/chrome/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function return func(*args, **kwargs) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 36, in inner return func(inspector_backend, *args, **kwargs) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 170, in Navigate self._page.Navigate(url, script_to_evaluate_on_commit, timeout) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py", line 125, in Navigate self.WaitForNavigate(timeout) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_page.py", line 94, in WaitForNavigate self._inspector_websocket.DispatchNotifications(remaining_time) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 134, in DispatchNotifications self._Receive(timeout) File "/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 149, in _Receive data = self._socket.recv() File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 293, in recv opcode, data = self.recv_data() File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 310, in recv_data opcode, frame = self.recv_data_frame(control_frame) File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 323, in recv_data_frame frame = self.recv_frame() File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 357, in recv_frame return self.frame_buffer.recv_frame() File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 336, in recv_frame self.recv_header() File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 286, in recv_header header = self.recv_strict(2) File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 371, in recv_strict bytes_ = self.recv(min(16384, shortage)) File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 427, in _recv return recv(self.sock, bufsize) File "/home/bokan/chrome/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_socket.py", line 83, in recv raise WebSocketTimeoutException(message) TimeoutException: ******************************************************************************** (/home/bokan/chrome/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py:470 _ConvertExceptionFromInspectorWebsocket) The app is probably crashed: ... I think basically the wprgo recording of digg.com is probably corrupted :-/ bokan@ is digg.com the only failing page? If so, can you just disable digg.com page to unblock your conversion, then we can try to rerecord digg.com archive later.
,
Aug 16 2017
Yup, that's the only one. Ok, I'll disable it for now. Thanks.
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42ffb94ebb0f357025f72dc03b450c6af754a1d5 commit 42ffb94ebb0f357025f72dc03b450c6af754a1d5 Author: David Bokan <bokan@chromium.org> Date: Tue Aug 22 18:54:00 2017 Removed key_mobile_sites and dead code key_mobile_sites is redundant with key_mobile_sites_smooth. The Page.archive_data_file member is unused so I've removed it, for both key_mobile_sites and all other page sets. Bug: 756119 , 730036 Change-Id: I7d25d50d50bc8e6eaec9069d644052ec9f58adc5 Reviewed-on: https://chromium-review.googlesource.com/626336 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#496390} [delete] https://crrev.com/0bd200d2258900ca1e7f6e506be321eb59a5394f/tools/perf/page_sets/data/key_mobile_sites.json [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/intl_ar_fa_he.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/intl_es_fr_pt-BR.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/intl_hi_ru.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/key_desktop_move_cases.py [delete] https://crrev.com/0bd200d2258900ca1e7f6e506be321eb59a5394f/tools/perf/page_sets/key_mobile_sites.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/key_mobile_sites_pages.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/key_mobile_sites_smooth.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/key_silk_cases.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/maps.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/oortonline.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/startup_pages.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/top_pages.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/tough_animation_cases.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/tough_canvas_cases.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/tough_compositor_cases.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/tough_image_decode_cases.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/tough_webgl_cases.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/typical_10_mobile.py [modify] https://crrev.com/42ffb94ebb0f357025f72dc03b450c6af754a1d5/tools/perf/page_sets/v8_top_25.py
,
Aug 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/400ea682810ebe6ea2b11ea3917870c3f084669a commit 400ea682810ebe6ea2b11ea3917870c3f084669a Author: David Bokan <bokan@chromium.org> Date: Wed Aug 23 01:17:00 2017 Convert key_mobile_sites_smooth to WPRGO The new WPRGO files have been uploaded to cloud storage. This CL commits the new sha1 hashes and updated json for the page set. The digg.com story failed the conversion and has been disabled in this CL for all benchmarks from which its used. See bug 756119 for details. Bug: 756119 , 730036 Change-Id: I28f87a4c5855b1b4af3de233e016d74b0a112fd9 Reviewed-on: https://chromium-review.googlesource.com/621948 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#496541} [modify] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/benchmarks/smoothness.py [modify] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/contrib/oilpan/oilpan_benchmarks.py [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_000.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_000.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_001.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_001.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_002.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_002.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_003.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_003.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_004.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_004.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_005.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_005.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_006.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_006.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_007.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_007.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_008.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_008.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_009.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_009.wprgo.sha1 [delete] https://crrev.com/8f4d7cbc5e7abb22e6cbc1961a4514a74b018dfc/tools/perf/page_sets/data/key_mobile_sites_010.wpr.sha1 [add] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_010.wprgo.sha1 [modify] https://crrev.com/400ea682810ebe6ea2b11ea3917870c3f084669a/tools/perf/page_sets/data/key_mobile_sites_smooth.json
,
Aug 2
,
Aug 14
rendering.mobile/digg_mobile and rendering.mobile/digg_mobile_sync_scroll have now been re-recorded and are re-enabled. |
||||
►
Sign in to add a comment |
||||
Comment 1 by xunji...@chromium.org
, Aug 16 2017