New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 756113 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Sep 2017
Cc:
danakj@chromium.org
█ staraz@chromium.org
samans@chromium.org
█ fsam...@chromium.org
rjkroege@chromium.org
█ gklassen@chromium.org
kylec...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 722935



Sign in to add a comment

Break the inclusion cycle in cc overlay

Project Member Reported by staraz@chromium.org, Aug 16 2017 
OutputSurface includes OverlayCandidateValidator includes OverlayProcessor includes OutputSurface. 

Refactor the code somehow to break the cycle so we don't have to all these classes to viz in one CL.

Comment 1 by kylec...@chromium.org, Aug 16 2017 

OverlayCandidateValidator doesn't need to include anything since it's an abstract class. You could switch to using a forward definition of OverlayProcessor::StrategyList and OverlayCandidateList.

Although it doesn't seem like a huge CL to just move the three classes together?

Comment 2 by staraz@chromium.org, Aug 16 2017 

OverlayCandidateValidator::GetStrategies takes a OverlayProcessor::StrategyList* as parameter. C++ doesn't allow forward declaring nested class.

Comment 4 by danakj@chromium.org, Sep 15 2017

Status: WontFix (was: Available)
►

Sign in to add a comment