Move BrowsingHistoryService to components/history/core/browser/ and the refactor iOS logic to use it instead of their own forked HistoryServiceFacade which has nearly an identical job (sending queries to local/web history services).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e174f5f6d4f170e2b9014698988480cef99be240 commit e174f5f6d4f170e2b9014698988480cef99be240 Author: Sky Malice <skym@chromium.org> Date: Mon Aug 21 23:53:49 2017 Componentize BrowsingHistoryService. This change moves BrowsingHistoryService from chrome/browser/history/ to components/history/core/browser/. The hope is that this will allow iOS to eventually call into BrowsingHistoryService. To do this we needed abstract away a few dependencies, which was done by increasing the responsibility of the BrowsingHistoryServiceHandler. A base class of ProfileBasedHistoryHandler was created to hold logic that used to live in BrowsingHistoryService, and both desktop and Android still want, but iOS cannot use. Bug: 756097 Change-Id: I9907fb1abf645d3b767df59ba385da970f80a045 Reviewed-on: https://chromium-review.googlesource.com/583951 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#496128} [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/BUILD.gn [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/android/history/browsing_history_bridge.cc [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/android/history/browsing_history_bridge.h [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/engagement/site_engagement_service.h [delete] https://crrev.com/f03bf8e4b1141991303b445875f92b41e95ec8a5/chrome/browser/history/browsing_history_service_handler.h [add] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/history/profile_based_browsing_history_driver.cc [add] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/history/profile_based_browsing_history_driver.h [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/chrome/test/BUILD.gn [modify] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/components/history/core/browser/BUILD.gn [add] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/components/history/core/browser/browsing_history_driver.h [rename] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/components/history/core/browser/browsing_history_service.cc [rename] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/components/history/core/browser/browsing_history_service.h [rename] https://crrev.com/e174f5f6d4f170e2b9014698988480cef99be240/components/history/core/browser/browsing_history_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57257f9af910ee8d2063e3c59b6a706154cbd21e commit 57257f9af910ee8d2063e3c59b6a706154cbd21e Author: Sky Malice <skym@chromium.org> Date: Tue Aug 22 15:49:11 2017 Revert "Componentize BrowsingHistoryService." This reverts commit e174f5f6d4f170e2b9014698988480cef99be240. Reason for revert: crbug.com/757723 Original change's description: > Componentize BrowsingHistoryService. > > This change moves BrowsingHistoryService from chrome/browser/history/ > to components/history/core/browser/. The hope is that this will allow > iOS to eventually call into BrowsingHistoryService. To do this we > needed abstract away a few dependencies, which was done by increasing > the responsibility of the BrowsingHistoryServiceHandler. > > A base class of ProfileBasedHistoryHandler was created to hold logic > that used to live in BrowsingHistoryService, and both desktop and > Android still want, but iOS cannot use. > > Bug: 756097 > Change-Id: I9907fb1abf645d3b767df59ba385da970f80a045 > Reviewed-on: https://chromium-review.googlesource.com/583951 > Commit-Queue: Sky Malice <skym@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496128} TBR=tommycli@chromium.org,sdefresne@chromium.org,twellington@chromium.org,skym@chromium.org,dominickn@chromium.org Change-Id: I061741b8862a1c45a57104f7bc722d4d7f9596fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756097 Reviewed-on: https://chromium-review.googlesource.com/626416 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#496316} [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/BUILD.gn [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/android/history/browsing_history_bridge.cc [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/android/history/browsing_history_bridge.h [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/engagement/site_engagement_service.h [rename] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/history/browsing_history_service.cc [rename] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/history/browsing_history_service.h [add] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/history/browsing_history_service_handler.h [rename] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/history/browsing_history_service_unittest.cc [delete] https://crrev.com/f644065628d4fc088f5deac6ab9464d350f7b361/chrome/browser/history/profile_based_browsing_history_driver.cc [delete] https://crrev.com/f644065628d4fc088f5deac6ab9464d350f7b361/chrome/browser/history/profile_based_browsing_history_driver.h [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/chrome/test/BUILD.gn [modify] https://crrev.com/57257f9af910ee8d2063e3c59b6a706154cbd21e/components/history/core/browser/BUILD.gn [delete] https://crrev.com/f644065628d4fc088f5deac6ab9464d350f7b361/components/history/core/browser/browsing_history_driver.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d327755c396acd3e027602f9b4ba431a5a6e853b commit d327755c396acd3e027602f9b4ba431a5a6e853b Author: Sky Malice <skym@chromium.org> Date: Tue Aug 22 16:05:25 2017 Revert "Componentize BrowsingHistoryService." This reverts commit e174f5f6d4f170e2b9014698988480cef99be240. Reason for revert: crbug.com/757723 Reverting to last night's daily branch to ship dev. Original change's description: > Componentize BrowsingHistoryService. > > This change moves BrowsingHistoryService from chrome/browser/history/ > to components/history/core/browser/. The hope is that this will allow > iOS to eventually call into BrowsingHistoryService. To do this we > needed abstract away a few dependencies, which was done by increasing > the responsibility of the BrowsingHistoryServiceHandler. > > A base class of ProfileBasedHistoryHandler was created to hold logic > that used to live in BrowsingHistoryService, and both desktop and > Android still want, but iOS cannot use. > > Bug: 756097 > Change-Id: I9907fb1abf645d3b767df59ba385da970f80a045 > Reviewed-on: https://chromium-review.googlesource.com/583951 > Commit-Queue: Sky Malice <skym@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496128} TBR=tommycli@chromium.org,sdefresne@chromium.org,twellington@chromium.org,skym@chromium.org,dominickn@chromium.org Change-Id: I061741b8862a1c45a57104f7bc722d4d7f9596fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756097 Reviewed-on: https://chromium-review.googlesource.com/626416 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#496316}(cherry picked from commit 57257f9af910ee8d2063e3c59b6a706154cbd21e) Reviewed-on: https://chromium-review.googlesource.com/626319 Reviewed-by: Alex Mineer <amineer@chromium.org> Cr-Commit-Position: refs/branch-heads/3193@{#3} Cr-Branched-From: 9bd5aef927219e3e72b7a076f14bb7efb01dca83-refs/heads/master@{#496151} [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/BUILD.gn [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/android/history/browsing_history_bridge.cc [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/android/history/browsing_history_bridge.h [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/engagement/site_engagement_service.h [rename] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/history/browsing_history_service.cc [rename] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/history/browsing_history_service.h [add] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/history/browsing_history_service_handler.h [rename] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/history/browsing_history_service_unittest.cc [delete] https://crrev.com/e957d694c4828272259e57f485d18d3aeb7f57d9/chrome/browser/history/profile_based_browsing_history_driver.cc [delete] https://crrev.com/e957d694c4828272259e57f485d18d3aeb7f57d9/chrome/browser/history/profile_based_browsing_history_driver.h [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/chrome/test/BUILD.gn [modify] https://crrev.com/d327755c396acd3e027602f9b4ba431a5a6e853b/components/history/core/browser/BUILD.gn [delete] https://crrev.com/e957d694c4828272259e57f485d18d3aeb7f57d9/components/history/core/browser/browsing_history_driver.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6abaf514b183c8853b14059f365d9c1b617cf246 commit 6abaf514b183c8853b14059f365d9c1b617cf246 Author: Sky Malice <skym@chromium.org> Date: Wed Aug 23 19:43:43 2017 Reland "Componentize BrowsingHistoryService." This change moves BrowsingHistoryService from chrome/browser/history/ to components/history/core/browser/. The hope is that this will allow iOS to eventually call into BrowsingHistoryService. To do this we needed abstract away a few dependencies, which was done by increasing the responsibility of the BrowsingHistoryServiceHandler. A base class of ProfileBasedHistoryHandler was created to hold logic that used to live in BrowsingHistoryService, and both desktop and Android still want, but iOS cannot use. Restored a null check that caused crashes in the original version of this CL and added unit tests to catch similar regressions. TBR=tommycli@chromium.org,twellington@chromium.org,dominickn@chromium.org Bug: 756097 Change-Id: I23ebb740f1969b57e4e18be7fcf7745a11ef31eb Reviewed-on: https://chromium-review.googlesource.com/626776 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#496772} [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/BUILD.gn [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/android/history/browsing_history_bridge.cc [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/android/history/browsing_history_bridge.h [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/engagement/site_engagement_service.h [delete] https://crrev.com/17acdf093f43f6ed0262437a0da7ec0bb2576a6b/chrome/browser/history/browsing_history_service_handler.h [delete] https://crrev.com/17acdf093f43f6ed0262437a0da7ec0bb2576a6b/chrome/browser/history/browsing_history_service_unittest.cc [add] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/history/profile_based_browsing_history_driver.cc [add] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/history/profile_based_browsing_history_driver.h [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/ui/webui/browsing_history_handler.h [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/browser/ui/webui/browsing_history_handler_unittest.cc [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/chrome/test/BUILD.gn [modify] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/components/history/core/browser/BUILD.gn [add] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/components/history/core/browser/browsing_history_driver.h [rename] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/components/history/core/browser/browsing_history_service.cc [rename] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/components/history/core/browser/browsing_history_service.h [add] https://crrev.com/6abaf514b183c8853b14059f365d9c1b617cf246/components/history/core/browser/browsing_history_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5293265ee74bfd47cebeade02d264121839b494 commit c5293265ee74bfd47cebeade02d264121839b494 Author: Sky Malice <skym@chromium.org> Date: Thu Aug 24 14:50:09 2017 Remove clock field from HistoryEntry. Instead of having a clock pointer on every single HistoryEntry, use the clock that's already present in the HistoryBrowsingService and/or HistoryBrowsingHandler. While HistoryEntry objects aren't really held onto in steady states, we do make quite a few of them, one for every entry on the history page, at least temporarily. While making related changes, also removed all Time::Now() and TimeDelta::Now() calls from HistoryBrowsingService with calls to the clock that was already present. This seemed more correct, even though we don't currently have any tests that check values. Bug: 756097 Change-Id: I86ed0dc3236b47ff8538da6d51c77c4dead3a4b2 Reviewed-on: https://chromium-review.googlesource.com/619806 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#497042} [modify] https://crrev.com/c5293265ee74bfd47cebeade02d264121839b494/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/c5293265ee74bfd47cebeade02d264121839b494/components/history/core/browser/browsing_history_service.cc [modify] https://crrev.com/c5293265ee74bfd47cebeade02d264121839b494/components/history/core/browser/browsing_history_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81c26e5776e43ca658da74a0a6f0f5a464c978ec commit 81c26e5776e43ca658da74a0a6f0f5a464c978ec Author: Sky Malice <skym@chromium.org> Date: Fri Aug 25 15:16:21 2017 Added more tests to BrowsingHistoryService. The main change is BrowsingHistoryService unittests now tests remote history, and verify the returned type is correct. This required an improvement to FakeWebHistoryService, mainly to actually return the json string that is parsed out into HistoryEntry objects by BrowsingHistoryService. Also added tests that verify various QueryOptions fields as passed through to underlying sources. Bug: 756097 Change-Id: I9d0905085d64b1bef615717b0bbd6bd3dd681150 Reviewed-on: https://chromium-review.googlesource.com/634023 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#497411} [modify] https://crrev.com/81c26e5776e43ca658da74a0a6f0f5a464c978ec/components/history/core/browser/browsing_history_service_unittest.cc [modify] https://crrev.com/81c26e5776e43ca658da74a0a6f0f5a464c978ec/components/history/core/test/fake_web_history_service.cc [modify] https://crrev.com/81c26e5776e43ca658da74a0a6f0f5a464c978ec/components/history/core/test/fake_web_history_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a commit cb5bc17a02814ba6e81f0414b38ec5dd72bad87a Author: Sky Malice <skym@chromium.org> Date: Mon Aug 28 21:13:46 2017 Update iOS code to use BrowsingHistoryService. The BrowsingHistoryService and the HistoryServiceFacade were essentially performing the same job. Now that BrowsingHistoryService is componentized, we can use it instead of a forked logic. However, I was not fully able to delete the facade (now renamed to IOSBrowsingHistoryDriver), as the controller was an objective c class and could not directly implement the interface of BrowsingHistoryDriver, which was a C++ class. iOS had a few extra features that other platforms did not, and this has caused a few more fields to be added to BrowsingHistoryService::QueryResultsInfo to facilitate the extra logic. The two main things I'd like to call out: 1. Retry upon sync timeout. If we're going to long term keep this retry, we should figure out how to fold it into BrowsingHistoryService and have all platform share it. However, I'm concerned there are some downsides to the current approach, created crbug.com/756662 2. When have we reached the "end" of history data. iOS currents ands together local and remote, while other platforms simply use local. Both approaches are fundamentally flawed, and will soon be fixed as part of crbug.com/728727. For the time being, I tried to leave each platform acting as it did previously. Bug: 756097 Change-Id: I51165cd7e2ea2011ce72359fd97c4aa425a95ad1 Reviewed-on: https://chromium-review.googlesource.com/616942 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Ramya Sharma <ramyasharma@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#497875} [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/chrome/browser/android/history/browsing_history_bridge.cc [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/components/history/core/browser/browsing_history_service.cc [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/components/history/core/browser/browsing_history_service.h [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/components/history/core/browser/browsing_history_service_unittest.cc [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/BUILD.gn [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/history_collection_view_controller.mm [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/history_collection_view_controller_unittest.mm [delete] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/ios/chrome/browser/ui/history/history_entry.cc [delete] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/ios/chrome/browser/ui/history/history_entry.h [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/history_entry_inserter_unittest.mm [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/history_entry_item.h [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/history_entry_item.mm [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/history_entry_item_unittest.mm [delete] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/ios/chrome/browser/ui/history/history_service_facade.h [delete] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/ios/chrome/browser/ui/history/history_service_facade.mm [delete] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/ios/chrome/browser/ui/history/history_service_facade_delegate.h [delete] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/ios/chrome/browser/ui/history/history_service_facade_unittest.mm [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/history_util.h [modify] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/history_util.mm [delete] https://crrev.com/dbeca24ce89efd518399831952a6255871d0d05c/ios/chrome/browser/ui/history/history_util_unittest.mm [add] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/ios_browsing_history_driver.h [add] https://crrev.com/cb5bc17a02814ba6e81f0414b38ec5dd72bad87a/ios/chrome/browser/ui/history/ios_browsing_history_driver.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9075dc4650bea132a930cdd106c54a4ae739555 commit c9075dc4650bea132a930cdd106c54a4ae739555 Author: Sky Malice <skym@chromium.org> Date: Wed Aug 30 12:59:28 2017 Remove start_time/end_time from QueryResultsInfo. These values are not currently used, and there was non-trivial logic computing end_time and the string versions of both. Bug: 756097 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic5b466f926c5769d85fd9114d565c29f9d595b6c Reviewed-on: https://chromium-review.googlesource.com/636123 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#498438} [modify] https://crrev.com/c9075dc4650bea132a930cdd106c54a4ae739555/chrome/browser/resources/md_history/externs.js [modify] https://crrev.com/c9075dc4650bea132a930cdd106c54a4ae739555/chrome/browser/ui/webui/browsing_history_handler.cc [modify] https://crrev.com/c9075dc4650bea132a930cdd106c54a4ae739555/components/history/core/browser/browsing_history_service.cc [modify] https://crrev.com/c9075dc4650bea132a930cdd106c54a4ae739555/components/history/core/browser/browsing_history_service.h
Comment 1 by bugdroid1@chromium.org
, Aug 21 2017