New issue
Advanced search Search tips

Issue 756094 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 678705
issue 770866



Sign in to add a comment

mash: Remove ash access from chrome/browser/ui/webui/chromeos

Project Member Reported by jamescook@chromium.org, Aug 16 2017

Issue description

Replace with mojo apis. See ash/README.md and go/mustash.

 
Blocking: 678705
Blocking: 770866
Components: -Internals>MUS Internals>Services>WindowService
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Labels: -Pri-3 Pri-2
Owner: steve...@chromium.org
Status: Started (was: Untriaged)
Cc: jamescook@chromium.org
This is down to:
* device_emulator_message_handler.cc
* keyboard_overlay_ui.cc

keyboard_overlay_ui.cc is marked as deprecated for KSV, but the dependency is pretty minor and can be replaced with an existing cros_display_config mojo API call. jamescook@ - Do you think that is worth fixing?

There are also some c/b/ui/webui/chromeos/login dependencies but those are tracked separately (issue 856375,  issue 678990 )

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b

commit cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jul 27 21:08:45 2018

BluetoothDialog cleanup: Pass non cannonical address

In the two (soon to be three) places where we call
BluetoothPairingDialog::ShowDialog, we first call
device::BluetoothDevice::CanonicalizeAddress(address).

We should do this in the ShowDialog call instead to simplify the
calling code.

Bug:  756094 
Change-Id: Ie4b6ee4935bd9a632e231f5c07b4830fc590a832
Reviewed-on: https://chromium-review.googlesource.com/1153573
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578793}
[modify] https://crrev.com/cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc

I wouldn't bother fixing keyboard_overlay_ui.cc. I think we'll be deleting it either late this milestone or early next.

Status: Fixed (was: Started)
The only remaining task here is  https://crbug.com/678990 , closing this issue.

Sign in to add a comment