mash: Remove ash access from chrome/browser/ui/webui/chromeos |
|||||||
Issue descriptionReplace with mojo apis. See ash/README.md and go/mustash.
,
Oct 2 2017
,
Feb 26 2018
,
Apr 19 2018
,
Jul 27
,
Jul 27
This is down to: * device_emulator_message_handler.cc * keyboard_overlay_ui.cc keyboard_overlay_ui.cc is marked as deprecated for KSV, but the dependency is pretty minor and can be replaced with an existing cros_display_config mojo API call. jamescook@ - Do you think that is worth fixing? There are also some c/b/ui/webui/chromeos/login dependencies but those are tracked separately (issue 856375, issue 678990 )
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b commit cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Jul 27 21:08:45 2018 BluetoothDialog cleanup: Pass non cannonical address In the two (soon to be three) places where we call BluetoothPairingDialog::ShowDialog, we first call device::BluetoothDevice::CanonicalizeAddress(address). We should do this in the ShowDialog call instead to simplify the calling code. Bug: 756094 Change-Id: Ie4b6ee4935bd9a632e231f5c07b4830fc590a832 Reviewed-on: https://chromium-review.googlesource.com/1153573 Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#578793} [modify] https://crrev.com/cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc [modify] https://crrev.com/cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b/chrome/browser/ui/ash/system_tray_client.cc [modify] https://crrev.com/cbcb900ab0d31c8894d9dff81cbfcd28338d5b7b/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d93806abedf4ff5855dda6ddb6587eedd373ae68 commit d93806abedf4ff5855dda6ddb6587eedd373ae68 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Jul 27 21:42:50 2018 Device Emulator: Call BluetoothDialog directly Bug: 756094 Change-Id: Ic492595a0b79202157d6b7ad9c588c518f417f92 Reviewed-on: https://chromium-review.googlesource.com/1116183 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578815} [delete] https://crrev.com/54086c2188f344c1ac126577a88c1c767f7f9230/chrome/browser/ui/webui/chromeos/emulator/DEPS [modify] https://crrev.com/d93806abedf4ff5855dda6ddb6587eedd373ae68/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc [modify] https://crrev.com/d93806abedf4ff5855dda6ddb6587eedd373ae68/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.h
,
Jul 27
I wouldn't bother fixing keyboard_overlay_ui.cc. I think we'll be deleting it either late this milestone or early next.
,
Dec 3
The only remaining task here is https://crbug.com/678990 , closing this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jamescook@chromium.org
, Aug 16 2017