Add | operator to NetworkTypePattern |
||||
Issue descriptionIn its current state, there's no efficient way to compose two NetworkTypePatterns. It would be nice to be able to do something like: NetworkTypePattern::WiFi() | NetworkTypePattern::Tether()
,
Aug 29 2017
,
Oct 3 2017
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8aa8a055ffc7f257c360cbfabaec5c9754af5966 commit 8aa8a055ffc7f257c360cbfabaec5c9754af5966 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Dec 15 01:19:30 2017 NetworkTypePattern: Introduce operator| and Physical() This CL: * Introduces NetworkTypePattern::operator| which makes some code a bit more intuitive (and reduces overhead). * Add Physical() for enabling/disabling physical networks during OOBE. This reduces log spam on linux and potentially avoids unexpected behavior on devices (but the current behavior is probably harmless). Bug: 756092 Change-Id: Ie27d02fd03875c1bb44e61510acd5179b672bd14 Reviewed-on: https://chromium-review.googlesource.com/828264 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#524279} [modify] https://crrev.com/8aa8a055ffc7f257c360cbfabaec5c9754af5966/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/8aa8a055ffc7f257c360cbfabaec5c9754af5966/chrome/browser/chromeos/app_mode/app_session.cc [modify] https://crrev.com/8aa8a055ffc7f257c360cbfabaec5c9754af5966/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc [modify] https://crrev.com/8aa8a055ffc7f257c360cbfabaec5c9754af5966/chrome/browser/chromeos/tether/tether_service.cc [modify] https://crrev.com/8aa8a055ffc7f257c360cbfabaec5c9754af5966/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/8aa8a055ffc7f257c360cbfabaec5c9754af5966/chromeos/network/network_type_pattern.cc [modify] https://crrev.com/8aa8a055ffc7f257c360cbfabaec5c9754af5966/chromeos/network/network_type_pattern.h [modify] https://crrev.com/8aa8a055ffc7f257c360cbfabaec5c9754af5966/chromeos/network/network_type_pattern_unittest.cc
,
Dec 19 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Aug 16 2017