New issue
Advanced search Search tips

Issue 756091 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 678705



Sign in to add a comment

mash: Remove ash access from chrome/browser/ui/views/tabs

Project Member Reported by jamescook@chromium.org, Aug 16 2017

Issue description

Replace with mojo apis. See ash/README.md and go/mustash.

 
Blocking: 678705
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f064ab1528d4de68ba720a46a90dc26c82af345

commit 9f064ab1528d4de68ba720a46a90dc26c82af345
Author: Elliot Glaysher <erg@chromium.org>
Date: Tue Sep 19 21:34:30 2017

[ash] Don't depend on ash to go fullscreen.

When the user releases the mouse on a drag in ash, the new window must
go fullscreen if the source window was previously fullscreen. Instead of
directly fiddling with ash state for this, set the fullscreen bit on the
window, which will be synced.

Bug: 756091
Change-Id: I26df2c1932ec2e185d9cb527e573438cc26bafa0
Reviewed-on: https://chromium-review.googlesource.com/671656
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502958}
[modify] https://crrev.com/9f064ab1528d4de68ba720a46a90dc26c82af345/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/9f064ab1528d4de68ba720a46a90dc26c82af345/chrome/browser/ui/views/tabs/window_finder_ash.cc

Comment 3 by e...@chromium.org, Sep 20 2017

Owner: e...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/417499ce8439075da56451801896f2fa72277ce2

commit 417499ce8439075da56451801896f2fa72277ce2
Author: Elliot Glaysher <erg@chromium.org>
Date: Fri Sep 22 20:00:48 2017

Expose ash::mojom::WindowStateType and use it in tab dragging.

This moves WindowStateType from being a private enum in //ash/ to being
an mojom enum in //ash/public/, along with adding the machinery to sync
this property.

This exposed window property is then used to detect whether a window was
snapped to the left or the right side of the screen during tab drags.

Bug: 756091
Change-Id: I46954b416804bca73cdb0fcaadb0ccd4c3e8d4b5
Reviewed-on: https://chromium-review.googlesource.com/676097
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503831}
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/BUILD.gn
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/accelerators/accelerator_controller_delegate_classic.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/mus/window_manager.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/cpp/window_properties.h
[add] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/cpp/window_state_type.cc
[add] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/cpp/window_state_type.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/interfaces/window_pin_type.mojom
[add] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/public/interfaces/window_state_type.mojom
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/default_state.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/default_state.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/drag_details.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/lock_layout_manager.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/lock_window_state.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/lock_window_state.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/overview/window_grid.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/resize_handle_window_targeter.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/tablet_mode/tablet_mode_window_manager.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/tablet_mode/tablet_mode_window_state.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/tablet_mode/tablet_mode_window_state.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/toplevel_window_event_handler.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/window_state.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/window_state.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/window_state_observer.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/wm_event.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/wm_toplevel_window_event_handler.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/wm_toplevel_window_event_handler.h
[delete] https://crrev.com/5e5347b75035dacaf16f082920d6282fe77ce1ea/ash/wm/wm_types.cc
[delete] https://crrev.com/5e5347b75035dacaf16f082920d6282fe77ce1ea/ash/wm/wm_types.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/workspace_window_resizer.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/chrome/browser/ui/ash/launcher/arc_app_window.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/components/exo/shell_surface.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/components/exo/shell_surface.h
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/417499ce8439075da56451801896f2fa72277ce2/components/exo/wayland/server.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/377e71a05bd7d53c33948f0aedfbff859ef11b0f

commit 377e71a05bd7d53c33948f0aedfbff859ef11b0f
Author: Brian Anderson <brianderson@chromium.org>
Date: Fri Sep 22 22:03:09 2017

Revert "Expose ash::mojom::WindowStateType and use it in tab dragging."

This reverts commit 417499ce8439075da56451801896f2fa72277ce2.

Reason for revert:
Causing compile to fail on one of the GPU fyi bots.

Original change's description:
> Expose ash::mojom::WindowStateType and use it in tab dragging.
> 
> This moves WindowStateType from being a private enum in //ash/ to being
> an mojom enum in //ash/public/, along with adding the machinery to sync
> this property.
> 
> This exposed window property is then used to detect whether a window was
> snapped to the left or the right side of the screen during tab drags.
> 
> Bug: 756091
> Change-Id: I46954b416804bca73cdb0fcaadb0ccd4c3e8d4b5
> Reviewed-on: https://chromium-review.googlesource.com/676097
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Elliot Glaysher <erg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503831}

TBR=sky@chromium.org,erg@chromium.org,tsepez@chromium.org

Change-Id: Ieb1765977a18983e0812b65701619f09d36d1bf5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 756091
Reviewed-on: https://chromium-review.googlesource.com/679479
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503871}
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/BUILD.gn
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/accelerators/accelerator_controller_delegate_classic.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/mus/window_manager.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/public/cpp/window_properties.h
[delete] https://crrev.com/560130c75fac030f2b4ba2684b5c5da28490b9d9/ash/public/cpp/window_state_type.cc
[delete] https://crrev.com/560130c75fac030f2b4ba2684b5c5da28490b9d9/ash/public/cpp/window_state_type.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/public/interfaces/window_pin_type.mojom
[delete] https://crrev.com/560130c75fac030f2b4ba2684b5c5da28490b9d9/ash/public/interfaces/window_state_type.mojom
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/default_state.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/default_state.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/drag_details.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/lock_layout_manager.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/lock_window_state.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/lock_window_state.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/overview/window_grid.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/resize_handle_window_targeter.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/tablet_mode/tablet_mode_window_manager.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/tablet_mode/tablet_mode_window_state.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/tablet_mode/tablet_mode_window_state.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/toplevel_window_event_handler.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/window_state.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/window_state.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/window_state_observer.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/wm_event.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/wm_toplevel_window_event_handler.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/wm_toplevel_window_event_handler.h
[add] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/wm_types.cc
[add] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/wm_types.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/workspace_window_resizer.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/chrome/browser/ui/ash/launcher/arc_app_window.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/components/exo/shell_surface.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/components/exo/shell_surface.h
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/377e71a05bd7d53c33948f0aedfbff859ef11b0f/components/exo/wayland/server.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90

commit 47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90
Author: Elliot Glaysher <erg@chromium.org>
Date: Sat Sep 23 02:08:04 2017

Reland "Expose ash::mojom::WindowStateType and use it in tab dragging."

This is a reland of 417499ce8439075da56451801896f2fa72277ce2
Original change's description:
> Expose ash::mojom::WindowStateType and use it in tab dragging.
> 
> This moves WindowStateType from being a private enum in //ash/ to being
> an mojom enum in //ash/public/, along with adding the machinery to sync
> this property.
> 
> This exposed window property is then used to detect whether a window was
> snapped to the left or the right side of the screen during tab drags.
> 
> Bug: 756091
> Change-Id: I46954b416804bca73cdb0fcaadb0ccd4c3e8d4b5
> Reviewed-on: https://chromium-review.googlesource.com/676097
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Elliot Glaysher <erg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503831}

TBR=sky@chromium.org,tsepez@chromium.org

Bug: 756091
Change-Id: Ief7df0cbffc348e5cb238eef2ff55e2b706ddd58
Reviewed-on: https://chromium-review.googlesource.com/679575
Commit-Queue: Elliot Glaysher <erg@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503931}
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/BUILD.gn
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/accelerators/accelerator_controller_delegate_classic.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/mus/window_manager.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/cpp/mus_property_mirror_ash.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/cpp/window_properties.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/cpp/window_properties.h
[add] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/cpp/window_state_type.cc
[add] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/cpp/window_state_type.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/interfaces/BUILD.gn
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/interfaces/window_pin_type.mojom
[add] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/public/interfaces/window_state_type.mojom
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/default_state.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/default_state.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/drag_details.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/lock_layout_manager.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/lock_window_state.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/lock_window_state.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/overview/window_grid.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/resize_handle_window_targeter.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/splitview/split_view_controller.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/splitview/split_view_controller.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/tablet_mode/tablet_mode_window_manager.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/tablet_mode/tablet_mode_window_state.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/tablet_mode/tablet_mode_window_state.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/toplevel_window_event_handler.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/window_state.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/window_state.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/window_state_observer.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/wm_event.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/wm_toplevel_window_event_handler.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/wm_toplevel_window_event_handler.h
[delete] https://crrev.com/f20f29e66404594ace24fe64bd9c7c7dc1d3cc56/ash/wm/wm_types.cc
[delete] https://crrev.com/f20f29e66404594ace24fe64bd9c7c7dc1d3cc56/ash/wm/wm_types.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/backdrop_controller.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/workspace_window_resizer.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/chrome/browser/ui/ash/launcher/arc_app_window.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/chrome/browser/ui/views/frame/immersive_mode_controller_ash.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/components/exo/shell_surface.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/components/exo/shell_surface.h
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/47f02ca7a0f9bbeeacbf9c5448505bd202a2ad90/components/exo/wayland/server.cc

Components: -Internals>MUS Internals>Services>WindowService

Comment 8 by e...@chromium.org, Mar 6 2018

Owner: ----
Status: Available (was: Assigned)
Mass unassigning bugs
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Sign in to add a comment