See the abusive ads definition: https://support.google.com/webtools/answer/7347327?hl=en&ref_topic=7071812 The stronger popup blocker will do its best to discount user gesture to block in more cases.
See the abusive experience definition: https://support.google.com/webtools/answer/7347327?hl=en&ref_topic=7071812 The stronger popup blocker will do its best to discount user gesture to block in more cases.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b9314a86a88fd308662a0aa5346f1b909610876 commit 2b9314a86a88fd308662a0aa5346f1b909610876 Author: Charles Harrison <csharrison@chromium.org> Date: Thu Aug 17 14:33:53 2017 [subresource_filter] Do not call FirstDisallowLoad for popups We used to need this, in case the page with activation did not have any resources disallowed. However, it isn't very necessary and there are cases when we only want the popup blocking UI. Bug: 756089 Change-Id: Ief4fbda8599f880e689412c031603dd8151ca581 Reviewed-on: https://chromium-review.googlesource.com/617762 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#495169} [modify] https://crrev.com/2b9314a86a88fd308662a0aa5346f1b909610876/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc [modify] https://crrev.com/2b9314a86a88fd308662a0aa5346f1b909610876/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/2b9314a86a88fd308662a0aa5346f1b909610876/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae740146731f704e803ac9cff668b926e5a0a113 commit ae740146731f704e803ac9cff668b926e5a0a113 Author: Charles Harrison <csharrison@chromium.org> Date: Thu Aug 17 20:28:07 2017 [subresource_filter] Devtools message for popups This CL also lightly refactors the popup browsertests to avoid code duplication. Bug: 756089 Change-Id: If47cb9c26d811fe1718f06698a3b6556f5275dc3 Reviewed-on: https://chromium-review.googlesource.com/617766 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#495302} [modify] https://crrev.com/ae740146731f704e803ac9cff668b926e5a0a113/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc [modify] https://crrev.com/ae740146731f704e803ac9cff668b926e5a0a113/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/ae740146731f704e803ac9cff668b926e5a0a113/components/subresource_filter/core/browser/subresource_filter_constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af2acd01afd2dfc0701107b9d556cbc7fb50bf1b commit af2acd01afd2dfc0701107b9d556cbc7fb50bf1b Author: Charles Harrison <csharrison@chromium.org> Date: Fri Aug 18 22:46:02 2017 Refactor: consolidate popup blocking code Popup blocking code used to live on both the IO thread and the UI thread. Now that window creation happens on the UI thread, the code can be consolidated in one place. This CL moves all popup blocking into a single static method on the popup blocker tab helper. The only behavior changes are that we will increase counts for the prerender end reason because we check it before the popup blocker. The CL has some other re-ordering of checks which should not affect behavior, but would aid readability. Bug: 756089 Change-Id: Ic767ed6bd95dace82cea8247d8b2168febd6955d Reviewed-on: https://chromium-review.googlesource.com/619546 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#495720} [modify] https://crrev.com/af2acd01afd2dfc0701107b9d556cbc7fb50bf1b/chrome/browser/android/tab_web_contents_delegate_android.cc [modify] https://crrev.com/af2acd01afd2dfc0701107b9d556cbc7fb50bf1b/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/af2acd01afd2dfc0701107b9d556cbc7fb50bf1b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/af2acd01afd2dfc0701107b9d556cbc7fb50bf1b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h [modify] https://crrev.com/af2acd01afd2dfc0701107b9d556cbc7fb50bf1b/chrome/browser/ui/browser.cc [modify] https://crrev.com/af2acd01afd2dfc0701107b9d556cbc7fb50bf1b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6cab6640c2c29655d55846472b2e4b126086913 commit b6cab6640c2c29655d55846472b2e4b126086913 Author: Charles Harrison <csharrison@chromium.org> Date: Thu Aug 24 18:40:17 2017 [subresource_filter] Add browser test for whitelisted popup Sites where popups are whitelisted should NOT get a devtools message. Bug: 756089 Change-Id: Ibc84846f95517902c23ea3c0a02faaf2c49559df Reviewed-on: https://chromium-review.googlesource.com/623888 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#497137} [modify] https://crrev.com/b6cab6640c2c29655d55846472b2e4b126086913/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c68a053af3f736194c573cfe2d34853ba0ac6b2 commit 1c68a053af3f736194c573cfe2d34853ba0ac6b2 Author: Charles Harrison <csharrison@chromium.org> Date: Fri Aug 25 13:34:50 2017 [subresource_filter] More robust disable_ruleset_rules impl The subresource_filter has a configuration option to disable ruleset rules. Previously this was implemented as a check in ReadyToCommitNavigation to avoid sending an IPC to the renderer notifying it of activation. This is non-ideal for a couple of reasons: a. We still have a lot of ceremony with throttle insertion, etc, and persisting throttle / activation state in the manager. b. We still access the ruleset in the browser process, which involves a verification pass, and holding it resident in memory. c. Throttles still delay the navigations. So, this CL uses a different tack. We now: 1. Don't create any subframe throttles if the current page has disabled ruleset 2. Don't notify the main frame throttle of page activation if the page has a disabled ruleset. These combined mean that: - We stop regressing memory for pages that activate with that configuration. Saves ~2.3 MB total memory. - We stop delaying navigations with this configuration. One of the consequences of this CL is that popup blocking logic moved into the driver factory, rather than the throttle manager (which should really just manage throttles). Bug: 756089 Change-Id: I6a452e4689bae849ad8750bd3c8d1465cbfb1d76 Reviewed-on: https://chromium-review.googlesource.com/620988 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#497391} [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.h [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h [modify] https://crrev.com/1c68a053af3f736194c573cfe2d34853ba0ac6b2/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2fb64defbefa601e369357efbb8f33ec3cf6a7c commit b2fb64defbefa601e369357efbb8f33ec3cf6a7c Author: Charles Harrison <csharrison@chromium.org> Date: Fri Aug 25 15:35:19 2017 [subresource_filter] Log histogram bucket for stronger popup blocker This histogram is logged once every time the stronger popup blocker blocks a popup. A followup could aggregate this per page load if we're worried about skew. Bug: 756089 Change-Id: I1c2406a47fb48aeb91993ba24be485c3baf0f198 Reviewed-on: https://chromium-review.googlesource.com/633787 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#497416} [modify] https://crrev.com/b2fb64defbefa601e369357efbb8f33ec3cf6a7c/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/b2fb64defbefa601e369357efbb8f33ec3cf6a7c/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc [modify] https://crrev.com/b2fb64defbefa601e369357efbb8f33ec3cf6a7c/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/b2fb64defbefa601e369357efbb8f33ec3cf6a7c/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32bad385194f5acd8b2ff16904413f1366b758d7 commit 32bad385194f5acd8b2ff16904413f1366b758d7 Author: Charles Harrison <csharrison@chromium.org> Date: Sat Aug 26 05:14:11 2017 [subresource_filter] Log total # of popups blocked per page load This histogram is logged at the end of a page load that has activation. Bug: 756089 Change-Id: I041b992d0721ec7fdb4db719d89331d5fbaf6280 Reviewed-on: https://chromium-review.googlesource.com/635614 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#497654} [modify] https://crrev.com/32bad385194f5acd8b2ff16904413f1366b758d7/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc [modify] https://crrev.com/32bad385194f5acd8b2ff16904413f1366b758d7/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc [modify] https://crrev.com/32bad385194f5acd8b2ff16904413f1366b758d7/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h [modify] https://crrev.com/32bad385194f5acd8b2ff16904413f1366b758d7/components/subresource_filter/content/browser/page_load_statistics.cc [modify] https://crrev.com/32bad385194f5acd8b2ff16904413f1366b758d7/components/subresource_filter/content/browser/page_load_statistics.h [modify] https://crrev.com/32bad385194f5acd8b2ff16904413f1366b758d7/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3847adb4ab31d7d8b3abd482dc9a71784411b63c commit 3847adb4ab31d7d8b3abd482dc9a71784411b63c Author: Charles Harrison <csharrison@chromium.org> Date: Tue Aug 29 02:24:49 2017 [subresource_filter] Add Better Ads / Abusive ads Activation lists This patch hooks up the safe browsing metadata added in [1] to the subresource_filter component to form 3 new ActivationLists. This CL does not address the "experimental" metadata. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/616120 Bug: 756089 , 737201 Change-Id: I4ecb5af9e1660cb73290641e1d857cb0e747bef7 Reviewed-on: https://chromium-review.googlesource.com/624314 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#497989} [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/content/browser/content_activation_list_utils.cc [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/common/activation_list.cc [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/components/subresource_filter/core/common/activation_list.h [modify] https://crrev.com/3847adb4ab31d7d8b3abd482dc9a71784411b63c/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1 commit f20c6a019aa6609f08569ebd27a74fc39a7f7ce1 Author: Charles Harrison <csharrison@chromium.org> Date: Wed Aug 30 15:10:55 2017 [subresource_filter] Add experimental finch param This CL adds a finch param to subresource_filter. This bool aligns with the new safe browsing metadata experimental bit. If the safe browsing check shows that the list entry has the experimental bit set to true, then we abort activation matching unless this finch param is set. Bug: 737201 , 756089 Change-Id: I6df7c0d3f48ca261445d40e77b3ec7387ef24b84 Reviewed-on: https://chromium-review.googlesource.com/629256 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#498464} [modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.cc [modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h [modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h [modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/f20c6a019aa6609f08569ebd27a74fc39a7f7ce1/components/subresource_filter/core/browser/subresource_filter_features.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa6a5d87adff761bc16afc5498c3f5944c1daa68 commit fa6a5d87adff761bc16afc5498c3f5944c1daa68 Author: Charles Harrison <csharrison@chromium.org> Date: Fri Sep 01 01:14:13 2017 [subresource_filter] Don't populate metadata if we're suppressing UI For abusive enforcement we don't want to show up in settings or Page Info, so make sure we don't populate the metadata in cases where we'd ship with suppress_notifications. Bug: 756089 Change-Id: I31967339737005e432ded66f69e583b7b60635ab Reviewed-on: https://chromium-review.googlesource.com/646792 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#499098} [modify] https://crrev.com/fa6a5d87adff761bc16afc5498c3f5944c1daa68/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/fa6a5d87adff761bc16afc5498c3f5944c1daa68/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/fa6a5d87adff761bc16afc5498c3f5944c1daa68/chrome/browser/subresource_filter/subresource_filter_unittest.cc [modify] https://crrev.com/fa6a5d87adff761bc16afc5498c3f5944c1daa68/components/subresource_filter/content/browser/subresource_filter_client.h [modify] https://crrev.com/fa6a5d87adff761bc16afc5498c3f5944c1daa68/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/fa6a5d87adff761bc16afc5498c3f5944c1daa68/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25bdcd914adf4558a5acb4b265ba15496673d575 commit 25bdcd914adf4558a5acb4b265ba15496673d575 Author: Charles Harrison <csharrison@chromium.org> Date: Tue Oct 03 12:51:34 2017 [subresource_filter] Presets for Better Ads and Abusive Ads Bug: 756089 , 737201 Change-Id: If5a0805dbf5b48f4be69642fd6db685d2943e5b9 Reviewed-on: https://chromium-review.googlesource.com/646602 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#506012} [modify] https://crrev.com/25bdcd914adf4558a5acb4b265ba15496673d575/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/25bdcd914adf4558a5acb4b265ba15496673d575/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/25bdcd914adf4558a5acb4b265ba15496673d575/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/748bfae4f13ff43e637a354ecb1da2d66a6f66a3 commit 748bfae4f13ff43e637a354ecb1da2d66a6f66a3 Author: Charles Harrison <csharrison@chromium.org> Date: Tue Oct 10 17:41:11 2017 Better safe browsing metadata for subresource_filter subtypes This CL updates the metadata expected from safe browsing in the following ways: 1. We don't expect any "warning" key anymore. 2. We now expect two more keys related to SUBRESOURCE_FILTER threat type, "sf_absv" (abusive sites) and "sf_bas" (better ads standard sites). If the value of one of the keys is "warn", that particular enforcement will operate in warning mode. This allows us to have e.g. a site that is abusive in warn mode but is BAS violating in enforce mode. Note: After this CL lands there is no more notion of a "global" warning parameter, so if you want to implement a warning for just the raw SUBRESOURCE_FILTER threat type, you are out of luck. Bug: 756089 Change-Id: Ib8bf2b9141fec55cdcff49314cdbb5031e957b74 Reviewed-on: https://chromium-review.googlesource.com/698946 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#507704} [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/chrome/browser/subresource_filter/subresource_filter_unittest.cc [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/safe_browsing/db/safe_browsing_api_handler_unittest.cc [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/safe_browsing/db/safe_browsing_api_handler_util.cc [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/safe_browsing/db/util.cc [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/safe_browsing/db/util.h [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/safe_browsing/db/v4_get_hash_protocol_manager.cc [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/safe_browsing/db/v4_get_hash_protocol_manager_unittest.cc [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/safe_browsing/db/v4_test_util.cc [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/subresource_filter/content/browser/content_activation_list_utils.cc [modify] https://crrev.com/748bfae4f13ff43e637a354ecb1da2d66a6f66a3/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/890f8aa05f9b11c35237cc5d8e084a7c6eec7575 commit 890f8aa05f9b11c35237cc5d8e084a7c6eec7575 Author: Charles Harrison <csharrison@chromium.org> Date: Tue Oct 31 00:26:14 2017 AbusiveExperienceEnforce: add end to end safe browsing test This CL adds a new harness to the safe browsing triggered popup blocker browser test which mocks HTTP responses from the safe browsing server. It also tweaks the ScopedLoggingObserver to stop listening (globally) on messages when it is destroyed, and it only considers messages that have come in since it is instantiated. Bug: 756009 , 756089 Change-Id: I2ad8bcebbdaf09252fa323e9de49c0de943e372b Reviewed-on: https://chromium-review.googlesource.com/731406 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#512689} [modify] https://crrev.com/890f8aa05f9b11c35237cc5d8e084a7c6eec7575/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5734f6cffa1a71c25043ee82ec7e67c0f3e06756 commit 5734f6cffa1a71c25043ee82ec7e67c0f3e06756 Author: Matt Menke <mmenke@chromium.org> Date: Tue Oct 31 09:41:55 2017 Disable failing tests when the network service is enabled. SafeBrowsingTriggeredInterceptingBrowserTest.AbusiveMetadata: new test. SSLUITestCommittedInterstitials.ErrorPageType: new test. virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html: old test, flaking a lot (And did my last shift, too). TBR=mmenke@chromium.org Bug: 729849 , 756009 , 756089 , 778857 Change-Id: I08ef0853db0d709e57ce2eb4ca1d3ac3960b6bcc Reviewed-on: https://chromium-review.googlesource.com/746363 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#512791} [modify] https://crrev.com/5734f6cffa1a71c25043ee82ec7e67c0f3e06756/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/5734f6cffa1a71c25043ee82ec7e67c0f3e06756/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2946f44cd62e524a297697354058ae7788871b4 commit e2946f44cd62e524a297697354058ae7788871b4 Author: Charles Harrison <csharrison@chromium.org> Date: Thu Jan 11 22:04:42 2018 AbusiveExperienceEnforce: add fieldtrial testing config Bug: 756089 Change-Id: Ib574ef2f6bc3c0f9806bf9386f6e785c488ed29e Reviewed-on: https://chromium-review.googlesource.com/862343 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#528768} [modify] https://crrev.com/e2946f44cd62e524a297697354058ae7788871b4/testing/variations/fieldtrial_testing_config.json
Comment 1 by bugdroid1@chromium.org
, Aug 17 2017