Replace with mojo apis. See ash/README.md and go/mustash.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5163dd7b1c9832e636f4730ea533316eee666dac commit 5163dd7b1c9832e636f4730ea533316eee666dac Author: James Cook <jamescook@chromium.org> Date: Tue Sep 12 21:16:17 2017 cros: Elimate usage of ash/wm/window_util.h in chrome/browser/ui/ash For go/mustash chrome browser code cannot call directly into ash. ash/wm/window_util.h is one of the most common ash headers used in chrome, so eliminate some usage. Replace ash::wm::Foo() calls with their core wm::Foo() equivalents where the windows are clearly browser windows or browser-owned windows (like platform apps). Convert GetActiveWindow() usage to IsActiveWindow() where the activation client is not known. Fix DEPS to ban this header. Bug: 678705, 756085 Test: browser_tests, unit_tests, manually switch multiprofile users with multiple browser windows open Change-Id: Ifde5f1119b4818a7bde58dcdd3eafaef187ace71 Reviewed-on: https://chromium-review.googlesource.com/661793 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#501398} [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/ash/wm/window_util.h [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/chromeos/login/ui/login_feedback_browsertest.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/DEPS [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/app_list/app_list_interactive_uitest.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/chrome_shell_delegate.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/browser_status_monitor.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/5163dd7b1c9832e636f4730ea533316eee666dac/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f616752f913c06366e2eb47c3ed2a85331d4146 commit 1f616752f913c06366e2eb47c3ed2a85331d4146 Author: Evan Stade <estade@chromium.org> Date: Tue Sep 19 17:48:47 2017 Move teleport warning dialog to ash Bug: 756085 Change-Id: I65d9171a836480df69484fba1fae7d1d1c6283d8 Reviewed-on: https://chromium-review.googlesource.com/669678 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#502885} [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/ash/BUILD.gn [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/ash/ash_strings.grd [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/ash/public/interfaces/session_controller.mojom [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/ash/session/session_controller.cc [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/ash/session/session_controller.h [add] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/ash/session/teleport_warning_dialog.cc [add] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/ash/session/teleport_warning_dialog.h [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/chrome/app/generated_resources.grd [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc [delete] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.cc [delete] https://crrev.com/91ff353372f72e2cab97316591c36cf398f39a9e/chrome/browser/ui/ash/multi_user/multi_user_warning_dialog.h [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/chrome/browser/ui/ash/session_controller_client.cc [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/chrome/browser/ui/ash/session_controller_client.h [modify] https://crrev.com/1f616752f913c06366e2eb47c3ed2a85331d4146/chrome/browser/ui/ash/session_controller_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/436f25b8af20219ba50373b69a456bf308619033 commit 436f25b8af20219ba50373b69a456bf308619033 Author: Evan Stade <estade@chromium.org> Date: Tue Sep 19 23:01:17 2017 Move session abort dialog from chrome/ to ash/. Bug: 756085 Change-Id: I749251c80206467a37b40bb99c2a55f0825fc6be Reviewed-on: https://chromium-review.googlesource.com/671924 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#502978} [modify] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/ash/BUILD.gn [modify] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/ash/ash_strings.grd [modify] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/ash/public/interfaces/session_controller.mojom [add] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/ash/session/session_aborted_dialog.cc [add] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/ash/session/session_aborted_dialog.h [modify] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/ash/session/session_controller.cc [modify] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/ash/session/session_controller.h [modify] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc [delete] https://crrev.com/82d8bf6944563c44ca7c3aa8adf8345d2c2f9685/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.cc [delete] https://crrev.com/82d8bf6944563c44ca7c3aa8adf8345d2c2f9685/chrome/browser/chromeos/profiles/multiprofiles_session_aborted_dialog.h [modify] https://crrev.com/436f25b8af20219ba50373b69a456bf308619033/chrome/browser/ui/ash/session_controller_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a46655f9f9f01cb31d33115284d2a2c719d4844 commit 7a46655f9f9f01cb31d33115284d2a2c719d4844 Author: Evan Stade <estade@chromium.org> Date: Mon Sep 25 18:01:55 2017 Remove a use of ash::Shell() from c/b/ui/ash/multi_user Bug: 756085 Change-Id: I5e865a0c9222de8e41d0aee01f00de1c70daf5e3 Reviewed-on: https://chromium-review.googlesource.com/675868 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#504102} [modify] https://crrev.com/7a46655f9f9f01cb31d33115284d2a2c719d4844/chrome/browser/ui/ash/media_client.cc [modify] https://crrev.com/7a46655f9f9f01cb31d33115284d2a2c719d4844/chrome/browser/ui/ash/media_client.h [modify] https://crrev.com/7a46655f9f9f01cb31d33115284d2a2c719d4844/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ac0e5b0944f98a44b8060e0467f56ec035be3d8 commit 3ac0e5b0944f98a44b8060e0467f56ec035be3d8 Author: Evan Stade <estade@chromium.org> Date: Tue Sep 26 14:33:42 2017 Chrome OS : Simplify shelf animation for user switching. There are two branches currently: - if at least one user has a maximized window, fade shelf to black and back. Note that this branch is broken, and instead all you see is a white flash, but this is easily fixed if need be. - otherwise, set shelf to hidden and then let the user switch update the state from there. If we remove both of these branches and just let the user switch change the state of the shelf, the outcome is nearly indistinguishable. Scratching the second bullet point above seems to have no discernible effect. Scratching the first branch just means there will be no fade-to- black, however the addition and removal of launcher icons is animated regardless, so it still looks smooth. Additionally, the fade-to-black doesn't work on the system tray (clock, avatar), and hasn't worked at all for 4 months and no one noticed. In a sense, removing this branch is an improvement because it removes a white flash. Bug: 756085 Change-Id: If40c65e02035947709be31db466dea144ab0b462 Reviewed-on: https://chromium-review.googlesource.com/683035 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#504363} [modify] https://crrev.com/3ac0e5b0944f98a44b8060e0467f56ec035be3d8/ash/public/cpp/shelf_prefs.cc [modify] https://crrev.com/3ac0e5b0944f98a44b8060e0467f56ec035be3d8/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/3ac0e5b0944f98a44b8060e0467f56ec035be3d8/ash/shelf/shelf_layout_manager.h [modify] https://crrev.com/3ac0e5b0944f98a44b8060e0467f56ec035be3d8/ash/shelf/shelf_widget.cc [modify] https://crrev.com/3ac0e5b0944f98a44b8060e0467f56ec035be3d8/ash/shelf/shelf_widget.h [modify] https://crrev.com/3ac0e5b0944f98a44b8060e0467f56ec035be3d8/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/3ac0e5b0944f98a44b8060e0467f56ec035be3d8/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [modify] https://crrev.com/3ac0e5b0944f98a44b8060e0467f56ec035be3d8/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.h
There is some work needed here for single-process mash. Getting the mru list will work, but correlating with browser windows won't work as is.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d3311b882d1642fdf9687eb56cc2983881b8cb8 commit 6d3311b882d1642fdf9687eb56cc2983881b8cb8 Author: Scott Violet <sky@chromium.org> Date: Tue Nov 06 23:12:24 2018 chromeos: provides client-id to clients The id is necessary for single-process-mash so that the browser process can know it's id and lookup windows (everything runs in the same process in single-process-mash). Outside of single-process-mash the id is really only useful for debugging. BUG= 756085 TEST=covered by tests Change-Id: I3819c5492fe2bfeeb243c44c36cc948168824ab6 Reviewed-on: https://chromium-review.googlesource.com/c/1318447 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#605867} [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/content/renderer/mus/renderer_window_tree_client.cc [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/content/renderer/mus/renderer_window_tree_client.h [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/services/ws/public/mojom/window_tree.mojom [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/services/ws/test_window_tree_client.cc [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/services/ws/test_window_tree_client.h [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/services/ws/window_tree_binding.cc [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/services/ws/window_tree_client_unittest.cc [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/6d3311b882d1642fdf9687eb56cc2983881b8cb8/ui/aura/mus/window_tree_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8b6b277902bd74c79e9377e9d66d63fedd784a2 commit a8b6b277902bd74c79e9377e9d66d63fedd784a2 Author: Scott Violet <sky@chromium.org> Date: Wed Nov 07 19:35:00 2018 chromeos: exposes functions in ash to get window by window service ids This is useful in single-process-mash to correlate windows. BUG= 756085 TEST=none Change-Id: I8845b62754ba5c34d352b49491078e69a35719aa Reviewed-on: https://chromium-review.googlesource.com/c/1323705 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#606130} [modify] https://crrev.com/a8b6b277902bd74c79e9377e9d66d63fedd784a2/ash/BUILD.gn [add] https://crrev.com/a8b6b277902bd74c79e9377e9d66d63fedd784a2/ash/ws/window_lookup.cc [add] https://crrev.com/a8b6b277902bd74c79e9377e9d66d63fedd784a2/ash/ws/window_lookup.h [modify] https://crrev.com/a8b6b277902bd74c79e9377e9d66d63fedd784a2/services/ws/window_service.cc [modify] https://crrev.com/a8b6b277902bd74c79e9377e9d66d63fedd784a2/services/ws/window_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adbbbbd4f91560dd8d8657068db633281c46065a commit adbbbbd4f91560dd8d8657068db633281c46065a Author: Scott Violet <sky@chromium.org> Date: Wed Nov 07 20:10:14 2018 chromeos: removes unused function No one overrides MultiUserWindowManager::Observer::OnOwnerEntryFinished. BUG= 756085 TEST=none Change-Id: If91a4e3fc4c5d63ef762763534b93865466ae833 Reviewed-on: https://chromium-review.googlesource.com/c/1323621 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#606140} [modify] https://crrev.com/adbbbbd4f91560dd8d8657068db633281c46065a/chrome/browser/ui/ash/multi_user/multi_user_window_manager.h [modify] https://crrev.com/adbbbbd4f91560dd8d8657068db633281c46065a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b1a44bc8e7e6048bd2fb00e18769889684eb9a9 commit 6b1a44bc8e7e6048bd2fb00e18769889684eb9a9 Author: Scott Violet <sky@chromium.org> Date: Thu Nov 08 19:34:08 2018 chromeos: disables test as it fails This test enables tablet mode, but it enables tablet mode in such a way that MultiUserWindowManager doesn't see (and process) the change. When the test is updated to correctly notify MultiUserWindowManager the test then fails. I think this may indicate a regression from recent changes and needs to be investigated. I came across this while doing some refactoring to MultiUserWindowManager. I've updated the test to ensure MultiUserWindowManager is called correctly and disabled it. BUG= 756085 , 903427 TEST=none Change-Id: I7b6ead448ba8d942516e42d9ef5ee745a547cc2c Reviewed-on: https://chromium-review.googlesource.com/c/1327159 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#606567} [modify] https://crrev.com/6b1a44bc8e7e6048bd2fb00e18769889684eb9a9/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/834fcb0a7ecf2e043c16d6f15c84134fd5b6846b commit 834fcb0a7ecf2e043c16d6f15c84134fd5b6846b Author: Scott Violet <sky@chromium.org> Date: Fri Nov 09 21:58:11 2018 chromeos: adds option for TestSessionControllerClient not to use lower-case I'm converting some tests, and would like to avoid having to update a bunch of places to use lower case strings. BUG= 756085 TEST=none Change-Id: I4beba5088736a6f1c9dbf040741073ce19016097 Reviewed-on: https://chromium-review.googlesource.com/c/1329930 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#606986} [modify] https://crrev.com/834fcb0a7ecf2e043c16d6f15c84134fd5b6846b/ash/session/test_session_controller_client.cc [modify] https://crrev.com/834fcb0a7ecf2e043c16d6f15c84134fd5b6846b/ash/session/test_session_controller_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f983cd510e96c42de295197b672d22860ce21f18 commit f983cd510e96c42de295197b672d22860ce21f18 Author: Scott Violet <sky@chromium.org> Date: Fri Nov 09 23:29:42 2018 views: makes show from server not also activate If the server shows a window, views was also activating the window. Instead views should just show the window. If the server wants the window active, it'll activate the window. BUG= 756085 TEST=covered by test Change-Id: I208945a61d8c96b5dba0a070d7f32f6536342f28 Reviewed-on: https://chromium-review.googlesource.com/c/1330710 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607027} [modify] https://crrev.com/f983cd510e96c42de295197b672d22860ce21f18/ui/views/mus/desktop_window_tree_host_mus.cc [modify] https://crrev.com/f983cd510e96c42de295197b672d22860ce21f18/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2cd482207e4f063c9cd2292bef7314c9206ace1 commit b2cd482207e4f063c9cd2292bef7314c9206ace1 Author: Scott Violet <sky@chromium.org> Date: Mon Nov 12 19:17:57 2018 chromeos/user_manager: adds has_gaia_account to ash Specifically ash::mojom::UserInfo. I'm going to need this to have ash call into wallpaper code, which needs the gaia account. BUG= 756085 TEST=none Change-Id: I9a9c1970bd3cd28ce36cca3d5ff919225dee8084 Reviewed-on: https://chromium-review.googlesource.com/c/1328564 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607300} [modify] https://crrev.com/b2cd482207e4f063c9cd2292bef7314c9206ace1/ash/public/interfaces/user_info.mojom [modify] https://crrev.com/b2cd482207e4f063c9cd2292bef7314c9206ace1/chrome/browser/ui/ash/session_controller_client.cc [modify] https://crrev.com/b2cd482207e4f063c9cd2292bef7314c9206ace1/components/user_manager/user.cc [modify] https://crrev.com/b2cd482207e4f063c9cd2292bef7314c9206ace1/components/user_manager/user.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f347ba6a419120c7cb2e3d29848a0ea1f7a284a8 commit f347ba6a419120c7cb2e3d29848a0ea1f7a284a8 Author: Scott Violet <sky@chromium.org> Date: Tue Nov 13 21:03:49 2018 chromeos: copies file to ash This is a copy of c/b/ui/ash/multi_user_window_manager_chromeos* to ash. I'm doing this as a precursor to a refactoring so you can better see what changes. I've only changed things necessary to avoid presubmit checks. This file is purposely not compiled now as it needs to be cleaned up first. BUG= 756085 TEST=nothing new is compiled, so no tests. Change-Id: I946d9e3b582142761e6519bf754733649d1a7612 Reviewed-on: https://chromium-review.googlesource.com/c/1330078 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#607737} [add] https://crrev.com/f347ba6a419120c7cb2e3d29848a0ea1f7a284a8/ash/multi_user/OWNERS [add] https://crrev.com/f347ba6a419120c7cb2e3d29848a0ea1f7a284a8/ash/multi_user/multi_user_window_manager.cc [add] https://crrev.com/f347ba6a419120c7cb2e3d29848a0ea1f7a284a8/ash/multi_user/multi_user_window_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41f8a81f91026740a72d8633b35c3ccdfe5173f5 commit 41f8a81f91026740a72d8633b35c3ccdfe5173f5 Author: Scott Violet <sky@chromium.org> Date: Wed Nov 14 18:02:29 2018 chromeos: refactors MultiUserWindowManager into two classes One lives in ash, the other in the browser. The one in ash is responsible for the actual window management and animations, the one in the browser for forwarding to the one in ash and caching state. I'm happy to rename these classes in the future. BUG= 756085 ,875111 TEST=covered by test Change-Id: I2367534e0566742f3897c69fb8ece7dfff1b1aff Reviewed-on: https://chromium-review.googlesource.com/c/1328567 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#608022} [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/ash/BUILD.gn [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/ash/multi_user/multi_user_window_manager.h [add] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/ash/multi_user/multi_user_window_manager_delegate.h [rename] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/ash/multi_user/user_switch_animator.cc [rename] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/ash/multi_user/user_switch_animator.h [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/ash/launcher/DEPS [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/ash/multi_user/DEPS [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/ash/multi_user/multi_user_window_manager.h [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h [modify] https://crrev.com/41f8a81f91026740a72d8633b35c3ccdfe5173f5/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56483341806609d6e29b206433ecf95658d14dca commit 56483341806609d6e29b206433ecf95658d14dca Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Nov 15 01:52:17 2018 Revert "chromeos: refactors MultiUserWindowManager into two classes" This reverts commit 41f8a81f91026740a72d8633b35c3ccdfe5173f5. Reason for revert: broke browser_tests on chrome_os, see https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8900 Original change's description: > chromeos: refactors MultiUserWindowManager into two classes > > One lives in ash, the other in the browser. The one in ash is responsible > for the actual window management and animations, the one in the browser for > forwarding to the one in ash and caching state. I'm happy to rename these > classes in the future. > > BUG= 756085 ,875111 > TEST=covered by test > > Change-Id: I2367534e0566742f3897c69fb8ece7dfff1b1aff > Reviewed-on: https://chromium-review.googlesource.com/c/1328567 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608022} TBR=sky@chromium.org,afakhry@chromium.org Change-Id: I23f7126a5ff8e897b7ad2ced79277392f771f2f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 756085 , 875111 Reviewed-on: https://chromium-review.googlesource.com/c/1336792 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608217} [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/ash/BUILD.gn [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/ash/multi_user/multi_user_window_manager.h [delete] https://crrev.com/8b764625cfe5f18e10b3e5bca0267fdcb0751031/ash/multi_user/multi_user_window_manager_delegate.h [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/launcher/DEPS [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/multi_user/DEPS [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/multi_user/multi_user_window_manager.h [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h [modify] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [rename] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc [rename] https://crrev.com/56483341806609d6e29b206433ecf95658d14dca/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0 commit c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0 Author: Scott Violet <sky@chromium.org> Date: Fri Nov 16 18:05:28 2018 RELAND chromeos: refactors MultiUserWindowManager into two classes One lives in ash, the other in the browser. The one in ash is responsible for the actual window management and animations, the one in the browser for forwarding to the one in ash and caching state. I'm happy to rename these classes in the future. BUG= 756085 ,875111 TEST=covered by test Change-Id: Ida90f51a6b7efff82021a29e8a0185949a3e494a Reviewed-on: https://chromium-review.googlesource.com/c/1338161 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#608852} [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/ash/BUILD.gn [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/ash/multi_user/multi_user_window_manager.h [add] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/ash/multi_user/multi_user_window_manager_delegate.h [rename] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/ash/multi_user/user_switch_animator.cc [rename] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/ash/multi_user/user_switch_animator.h [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/ash/launcher/DEPS [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/ash/multi_user/DEPS [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/ash/multi_user/multi_user_window_manager.h [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h [modify] https://crrev.com/c4fc7889fa033e7240d8d281c0d1ebdb701fe7b0/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33ce18df70251bd803cc5206f9d3f42cde3f1afd commit 33ce18df70251bd803cc5206f9d3f42cde3f1afd Author: Scott Violet <sky@chromium.org> Date: Mon Nov 19 17:11:00 2018 chromeos: gets MultiUserWindowManager working with mus windows This routes changes to MultiUserWindowManager that impact mus windows over a mojom. This way the ash side can map these windows appropriately. BUG= 756085 ,875111 TEST=covered by test Change-Id: Ie69732f290d919e591505234669328e69cc4afc9 Reviewed-on: https://chromium-review.googlesource.com/c/1330719 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609338} [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/BUILD.gn [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/multi_user/multi_user_window_manager.h [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/public/interfaces/BUILD.gn [add] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/public/interfaces/multi_user_window_manager.mojom [add] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/ws/multi_user_window_manager_bridge.cc [add] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/ws/multi_user_window_manager_bridge.h [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/ws/window_lookup.cc [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/ws/window_lookup.h [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ash/ws/window_service_delegate_impl.cc [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/chrome/browser/ui/ash/multi_user/DEPS [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/services/ws/common/util.h [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/services/ws/window_service.cc [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/services/ws/window_service.h [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ui/aura/test/env_test_helper.h [modify] https://crrev.com/33ce18df70251bd803cc5206f9d3f42cde3f1afd/ui/aura/test/mus/change_completion_waiter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/448a24905cfffcb4d08d9cd5e343b0c409e57d99 commit 448a24905cfffcb4d08d9cd5e343b0c409e57d99 Author: Scott Violet <sky@chromium.org> Date: Mon Nov 19 18:56:09 2018 chromeos: use unique_ptr in MultiUserWindowManager BUG= 756085 ,875111 TEST=covered by test Change-Id: Idc65b7ca5b340401855694f1f123402612b73003 Reviewed-on: https://chromium-review.googlesource.com/c/1341021 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#609372} [modify] https://crrev.com/448a24905cfffcb4d08d9cd5e343b0c409e57d99/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/448a24905cfffcb4d08d9cd5e343b0c409e57d99/ash/multi_user/multi_user_window_manager.h [modify] https://crrev.com/448a24905cfffcb4d08d9cd5e343b0c409e57d99/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/448a24905cfffcb4d08d9cd5e343b0c409e57d99/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be589e1c47163f1cd9ba99e07507df737efd1152 commit be589e1c47163f1cd9ba99e07507df737efd1152 Author: Scott Violet <sky@chromium.org> Date: Tue Nov 27 04:30:08 2018 chromeos: adds client interface for MultiUserWindow The client is notified of changes to the window owner. BUG= 756085 ,875111 TEST=covered by test Change-Id: I8cec4fe2b547bb1f9f31899e2bc2a9437c186d27 Reviewed-on: https://chromium-review.googlesource.com/c/1343507 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#611017} [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/ash/BUILD.gn [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/ash/multi_user/multi_user_window_manager.h [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/ash/multi_user/multi_user_window_manager_delegate.h [add] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/ash/multi_user/multi_user_window_manager_window_delegate.h [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/ash/public/interfaces/multi_user_window_manager.mojom [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/ash/ws/multi_user_window_manager_bridge.cc [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/ash/ws/multi_user_window_manager_bridge.h [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/services/ws/window_service.cc [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/services/ws/window_service.h [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/services/ws/window_tree.cc [modify] https://crrev.com/be589e1c47163f1cd9ba99e07507df737efd1152/services/ws/window_tree.h
Single process mash now works. Multi-process mash will be handled as part of 875111.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e787f908883d2cffc066b1dba5ee244c67a49a70 commit e787f908883d2cffc066b1dba5ee244c67a49a70 Author: Scott Violet <sky@chromium.org> Date: Wed Nov 28 22:28:49 2018 chromeos: update current_account_id_ when user switch happens This got lost in the refactoring. Added test coverage. BUG= 756085 ,875111 TEST=covered by test Change-Id: I1b9bbc78b2657a1378b55542786b88f8911a4b9e Reviewed-on: https://chromium-review.googlesource.com/c/1351144 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611899} [modify] https://crrev.com/e787f908883d2cffc066b1dba5ee244c67a49a70/ash/multi_user/multi_user_window_manager.cc [modify] https://crrev.com/e787f908883d2cffc066b1dba5ee244c67a49a70/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
Comment 1 by jamescook@chromium.org
, Aug 16 2017