New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 756083 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Nov 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

UPSTREAM binder cleanups atop removal of one big binder lock

Project Member Reported by diand...@chromium.org, Aug 16 2017

Issue description

Forked from  bug #755697 ...

---

We have some local CHROMIUM changes in kernel 4.4:

CHROMIUM: android: binder: another use of binder_lock_interruptible
android: binder: Turn off warning for NO_WAIT allocation
CHROMIUM: android: binder: do not create thread when trying to kill it
CHROMIUM: android: binder: introduce binder_lock_interruptible
CHROMIUM: android: binder: do not take binder lock when thread forcibly woken up
CHROMIUM: android: binder: push binder_lock down into ioctl ops
CHROMIUM: android: binder: reset BINDER_LOOPER_STATE_NEED_RETURN earlier
FROMLIST: android: binder: check result of binder_get_thread() in binder_poll()
CHROMIUM: android: binder: Fix potential scheduling-while-atomic
android: binder: Disable preemption while holding the global binder lock.
android: binder: Use wake up hint for synchronous transactions.
CHROMIUM: android: binder: get rid of BINDER_LOOPER_STATE_WAITING

---

When we landed some these changes we evaluated the upstream "remove the big binder lock" patches, but Dmitry found some things there that he objected to.

This bug tracks the effort to submit patches upstream to cleanup the things that were not liked.  Possibly for inspiration we might want to apply some of the CHROMIUM patches above to upstream.

---

For now newer kernels (like 4.12) will use the pure upstream solution for binder.  Again, see  bug #755697 
 
Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.
<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!
I assume the patches were either rebased or dropped in the rebase.  Closing.
Status: Archived (was: Assigned)

Sign in to add a comment