mash: Remove ash access from chrome/browser/chromeos/ui |
||||||
Issue descriptionReplace with mojo apis. See ash/README.md and go/mustash. It's mostly accessibility focus ring stuff.
,
Sep 18 2017
,
Oct 26 2017
,
Feb 26 2018
,
Apr 19 2018
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e7d1df6a24ad234579cccfe308bd6cdf6ca01f0 commit 6e7d1df6a24ad234579cccfe308bd6cdf6ca01f0 Author: James Cook <jamescook@chromium.org> Date: Wed Apr 25 20:51:44 2018 cros: Remove ash access from consumer kiosk idle app notification This is necessary for out-of-process ash (go/mustash). Eliminate a call to ash::Shell::GetRootWindowForNewWindows(). The notification is only shown if the primary display is an internal Chromebook display (existing behavior) and it will now always appear on that display instead of potentially appearing on a secondary, non-internal display. Bug: 756082 Test: manual test on device Change-Id: Id56a87b56fd2e51a215a2dfeecfaee2417549257 Reviewed-on: https://chromium-review.googlesource.com/1028576 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#553734} [modify] https://crrev.com/6e7d1df6a24ad234579cccfe308bd6cdf6ca01f0/chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.cc [modify] https://crrev.com/6e7d1df6a24ad234579cccfe308bd6cdf6ca01f0/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36fade6abd290d8dab5952dc996cf466a8d9db6f commit 36fade6abd290d8dab5952dc996cf466a8d9db6f Author: James Cook <jamescook@chromium.org> Date: Wed Apr 25 23:31:19 2018 cros: Always show kiosk usb update notification on primary display This eliminates a call into ash::Shell::GetRootWindowForNewWindows, which we need to do for out-of-process ash (go/mustash). The existing code looks like it was just copied from another place that shows a similar notification. Regardless, the primary display should be fine. Bug: 372857 , 826569 Test: browser_tests KioskUpdateTest.* Change-Id: Iebe8a3a614bdb346fc30f8baab8b77e24ad466c2 Reviewed-on: https://chromium-review.googlesource.com/1029115 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#553821} [modify] https://crrev.com/36fade6abd290d8dab5952dc996cf466a8d9db6f/chrome/browser/chromeos/ui/kiosk_external_update_notification.cc
,
Aug 1
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jamescook@chromium.org
, Aug 16 2017