New issue
Advanced search Search tips

Issue 756077 link

Starred by 1 user
Status: Fixed
Owner:
chengx@chromium.org
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

ProfileChooserView::CreateOtherProfilesView is not used and should be deleted

Project Member Reported by chengx@chromium.org, Aug 16 2017 
Due to historical reasons, the CreateOtherProfilesView API was introduced in 
chrome/browser/ui/views/profiles/profile_chooser_view.cc but it is not used anymore. We should delete it to make our code base clean.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3c576ab9b5dd3670afb7948cdbe262187e1bfe4

commit c3c576ab9b5dd3670afb7948cdbe262187e1bfe4
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Aug 16 20:54:33 2017

Delete ProfileChooserView::CreateOtherProfilesView as it's not used now

This method is not used anywhere now, so should be deleted.

Bug:  756077 
Change-Id: I7a136195858872615b31f5da7f5617ede9f8535d
Reviewed-on: https://chromium-review.googlesource.com/617520
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494942}
[modify] https://crrev.com/c3c576ab9b5dd3670afb7948cdbe262187e1bfe4/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/c3c576ab9b5dd3670afb7948cdbe262187e1bfe4/chrome/browser/ui/views/profiles/profile_chooser_view.h

Comment 2 by chengx@chromium.org, Aug 22 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment