New issue
Advanced search Search tips

Issue 756074 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 678705



Sign in to add a comment

mash: Remove ash access from chrome/browser/chromeos/profiles

Project Member Reported by jamescook@chromium.org, Aug 16 2017

Issue description

Replace with mojo apis. See ash/README.md and go/mustash.

 
Blocking: 678705

Comment 2 by est...@chromium.org, Sep 18 2017

Owner: est...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b

commit b63da88a4bbd17c82c4a2bb42e5144295fac3f0b
Author: Evan Stade <estade@chromium.org>
Date: Wed Sep 20 22:27:52 2017

Move multiprofiles intro dialog from chrome/ to ash/.

This removes almost all ash deps from chrome/browser/chromeos/profiles/.

Bug:  756074 
Change-Id: I045f394550f69d7014c20ee86ff3a16408270fa3
Reviewed-on: https://chromium-review.googlesource.com/671673
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503270}
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/ash/BUILD.gn
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/ash/ash_strings.grd
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/ash/public/interfaces/session_controller.mojom
[add] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/ash/session/multiprofiles_intro_dialog.cc
[add] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/ash/session/multiprofiles_intro_dialog.h
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/ash/session/session_controller.cc
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/ash/session/session_controller.h
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/chrome/browser/chromeos/DEPS
[add] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/chrome/browser/chromeos/profiles/DEPS
[delete] https://crrev.com/c748cf6da5154efdfc975d3f7366d079b92a1595/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc
[delete] https://crrev.com/c748cf6da5154efdfc975d3f7366d079b92a1595/chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.h
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/chrome/browser/chromeos/profiles/profile_list_chromeos.cc
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/chrome/browser/ui/ash/session_controller_client.cc
[modify] https://crrev.com/b63da88a4bbd17c82c4a2bb42e5144295fac3f0b/chrome/browser/ui/ash/session_controller_client_unittest.cc

Components: -Internals>MUS Internals>Services>WindowService

Comment 5 by est...@chromium.org, Mar 13 2018

Status: Fixed (was: Started)

Sign in to add a comment